Manuscript (Case [Issue]22504) Kernel - OSPlatform>>currentWorkingDirectoryPathWithBuffer: fails

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Manuscript (Case [Issue]22504) Kernel - OSPlatform>>currentWorkingDirectoryPathWithBuffer: fails

Pharo Issue Tracker
Manuscript Notification
avatar
Alistair Grant opened Case 22504: OSPlatform>>currentWorkingDirectoryPathWithBuffer: fails and assigned it to Everyone:
Bug in Project:  Kernel: 1. Pharo Image  •  You are subscribed to this case
OSPlatform>>currentWorkingDirectoryPathWithBuffer: has a number of issues:

1. It doesn't find the primitive because the module isn't specified.
2. The primitive call fails because the primitive expects 0 arguments while the method passes one (which is unrelated to the primitive).

I'm not sure why the FFI fallback is required. If the primitive is failing, it should be fixed (I don't see how the primitive can fail under normal circumstances, it is effectively just getcwd()). Replacing the primitive with the FFI call is problematic at the moment as it fails sometimes, depending on which VM is used.

For now I'll just fix the code leaving the functionality as intended, and we can revisit it later if desired.

Proposed solution:

1. Split the FFI call out to a separate method.
2. Modify OSPlatform>>currentWorkingDirectoryPath to handle the fallback.

PR to be attached soon.
Priority Priority: 4 – Would be nice Status Status: Work Needed
Assigned To Assigned to: Everyone Milestone Milestone: Pharo7.0

Go to Case
No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

Manuscript

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker