Pharo Issue Tracker - Manuscript (Case [Issue]22603) Zinc - Binary file fails for ZnMimePart class>>#fieldName:fileNamed:

Manuscript Notification

	Wouter van Zuilen revised a previous entry on Case 22603: Binary file fails for ZnMimePart class>>#fieldName:fileNamed:: Bug in Zinc: 1. Pharo Image • You are subscribed to this case

In the latest Pharo 7 64 bit build running on MacOS the following fails:

<code>ZnMimePart fieldName: 'file' fileNamed: '/path/to/aPdfFile.pdf'</code>

In this method an instance of a ZnCharacterReadStream receives the message #binary which it not understands.

I would suggest the following fix:

<code>fieldName: fieldName fileNamed: fileName
| mimeType size fileStream entity baseName |
mimeType := ZnMimeType forFilenameExtension: (ZnFileSystemUtils extensionFor: fileName).
fileStream := mimeType isBinary
ifTrue: [ fileName asFileReference binaryReadStream ]
ifFalse: [ fileName asFileReference readStream ].
size := ZnFileSystemUtils fileSizeFor: fileName.
(entity := ZnStreamingEntity type: mimeType length: size) stream: fileStream.
baseName := ZnFileSystemUtils baseNameFor: fileName.
^ self fieldName: fieldName fileName: baseName entity: entity</code>

Ok? Then I'll Should I ensure closing the fileStream in this case?

If OK, I can make a the PR .

	Priority: 5 – Fix If Time		Status: Work Needed
	Assigned to: Everyone		Milestone: Later

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker