Manuscript (Case [Issue]22655) _Inbox - Better comments for PNGReadWriter >> formFromStream:

Sven Van Caekenberghe edited Case 22655: Better comments for PNGReadWriter >> formFromStream:: First Impression Counts in  _Inbox: Not Spam  •  You are subscribed to this case Why refer to another class there ? You write an example using PNGReadWriter in ImageReadWriter. ImageReadWriter does auto format detection. <code> ImageReadWriter formFromFileNamed: 'control-unit.png'. ImageReadWriter formFromStream: 'control-unit.png' asFileReference binaryReadStream. </code> #formFromStream does a #close (which makes sense in this case, but not in general for a read method), look at the implementation of #formFromFileNamed: Don't use File Priority: 5 – Fix If Time Status: Resolved (Fix Review Needed) Assigned to: Stephane Ducasse Milestone: Pharo7.0 Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences.

A Manuscript case was edited by Sven Van Caekenberghe. Case ID: 22655 Title: Better comments for PNGReadWriter >> formFromStream: Status: Resolved (Fix Review Needed) Category: First Impression Counts Project: _Inbox Area: Not Spam Priority: 5 - Fix If Time Milestone: Pharo7.0: 9/2/2018 (Past) Assigned To: Stephane Ducasse URL: https://pharo.manuscript.com/f/cases/22655 Why refer to another class there ? You write an example using PNGReadWriter in ImageReadWriter. ImageReadWriter does auto format detection. <code> ImageReadWriter formFromFileNamed: 'control-unit.png'. ImageReadWriter formFromStream: 'control-unit.png' asFileReference binaryReadStream. </code> #formFromStream does a #close (which makes sense in this case, but not in general for a read method), look at the implementation of #formFromFileNamed: Don't use File You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=22655) from this case.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker