Manuscript (Case [Issue]22727) Usability - NonInteractiveTranscript is broken with files

Sven Van Caekenberghe edited Case 22727: NonInteractiveTranscript is broken with files: Bug in  Usability: Misc  •  You are subscribed to this case About speed: the current implementation does a #critical: access and #flush after each #show: so it won't be that fast in execution speed, but fast in producing results in the output (std or file) which is important too. About encoding: neither Stdio nor File does any encoding on their raw streams, so writing anything but ASCII (or Latin1) will fail. These are separate points from the functional issue at hand. I would go for: <code> initializeStream "Open the file stream that I write to or connect to #stdout. I use the proper line end convention. I will append to regular files." ^ stream := self isStdout ifTrue: [ Stdio stdout ] ifFalse: [ self isStderr ifTrue: [ Stdio stderr ] ifFalse: [ (File named: self fileName) openForAppend ] ] </code> But I have to test it. We need some unit tests too. Do you want me to do a PR ? Priority: 1 – Show Stopper !!!!!! Status: Work Needed Assigned to: Everyone Milestone: Pharo7.0 Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences.

A Manuscript case was edited by Sven Van Caekenberghe. Case ID: 22727 Title: NonInteractiveTranscript is broken with files Status: Work Needed Category: Bug Project: Usability Area: Misc Priority: 1 - Show Stopper !!!!!! Milestone: Pharo7.0: 9/2/2018 (Past) Assigned To: Everyone URL: https://pharo.manuscript.com/f/cases/22727 About speed: the current implementation does a #critical: access and #flush after each #show: so it won't be that fast in execution speed, but fast in producing results in the output (std or file) which is important too. About encoding: neither Stdio nor File does any encoding on their raw streams, so writing anything but ASCII (or Latin1) will fail. These are separate points from the functional issue at hand. I would go for: <code> initializeStream "Open the file stream that I write to or connect to #stdout. I use the proper line end convention. I will append to regular files." ^ stream := self isStdout ifTrue: [ Stdio stdout ] ifFalse: [ self isStderr ifTrue: [ Stdio stderr ] ifFalse: [ (File named: self fileName) openForAppend ] ] </code> But I have to test it. We need some unit tests too. Do you want me to do a PR ? You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=22727) from this case.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker