Manuscript (Fall [Issue]21937) Crosscutting and Misc - Base64MimeConverter mimeDecodeToBytes: broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Manuscript (Fall [Issue]21937) Crosscutting and Misc - Base64MimeConverter mimeDecodeToBytes: broken

Pharo Issue Tracker
Manuscript Notification
avatar
Torsten Bergmann revised a previous entry on Case 21937: Base64MimeConverter mimeDecodeToBytes: broken :
Bug in Project:  Crosscutting and Misc: 1. Pharo Image  •  You are subscribed to this case
in latest Pharo the icon conversion from a base 64 encoded string is broken. This is horrible as loading packages with custom icons from a base 64 encoded source will break the world menu and make Pharo unusable.


Try to load QuickAccess, Seaside
, Roassal or other who usually create their icons like this:

seasideAdaptorRunningIcon
^ icons
at: #'seasideAdaptorRunningIcon'
ifAbsentPut:[ Form fromBinaryStream: (Base64MimeConverter mimeDecodeToBytes: self seasideAdaptorRunningIconContents readStream) ]

where Base64MimeConverter mimeDecodeToBytes: is now broken in recent Pharo 7 (Build 70925) and gives an error.

I guess because of the stream changes or because #mimeDecodeToBytes: uses the deprecated RWBinaryOrTextStream class.


As a workaround one can patch the method in Base64MimeConverter like this:

mimeDecodeToBytes: aStream
^(ZnBase64Encoder new decode: aStream contents) readStream

but I'm not sure this is the right solution.
Priority Priority: 1 – Show Stopper !!!!!! Status Status: Work Needed
Assigned To Assigned to: Everyone Milestone Milestone: Pharo7.0

Go to Case
No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

Manuscript

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker