Marking porting changes with 'self flag: #adaptedForCuis'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Marking porting changes with 'self flag: #adaptedForCuis'

Hannes Hirzel
On 1/21/13, Germán Arduino <[hidden email]> wrote:

> 2013/1/21 H. Hirzel <[hidden email]>:
>> Another feedback,
>>
>> Could you please mark changes with
>>
>>     self flag: #adaptedForCuis
>>
>> instead of just with a comment
>>
>>     "Squeak specific"
>>
>> example see below. That way it is easier to review the changes.
>>
>> --Hannes
>>
>
>
> "Squeak specific" comes from the original code, is not from me.
>
> But self flag: #adaptedForCuis sound ok, what think the other people?
>

I'll use it for an SQLite3 port.

--Hannes


>
> --
> Sincerely,
> Germán Arduino
> about.me/garduino
>

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
Reply | Threaded
Open this post in threaded view
|

Re: Marking porting changes with 'self flag: #adaptedForCuis'

garduino
2013/1/24 H. Hirzel <[hidden email]>:

> On 1/21/13, Germán Arduino <[hidden email]> wrote:
>> 2013/1/21 H. Hirzel <[hidden email]>:
>>> Another feedback,
>>>
>>> Could you please mark changes with
>>>
>>>     self flag: #adaptedForCuis
>>>
>>> instead of just with a comment
>>>
>>>     "Squeak specific"
>>>
>>> example see below. That way it is easier to review the changes.
>>>
>>> --Hannes
>>>
>>
>>
>> "Squeak specific" comes from the original code, is not from me.
>>
>> But self flag: #adaptedForCuis sound ok, what think the other people?
>>
>
> I'll use it for an SQLite3 port.
>
> --Hannes
>
>

Flagged as "Cuis specific" as Janko suggested and commited.

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org