Merge tool doesn't recognize method moves

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Merge tool doesn't recognize method moves

davidbuck
Select a method in Package A and move the method as an extension in
Package B. Publish as a branch. Now, load the original head version and
merge the branch. The merge tool shows no results and if you try to
publish, it claims that there are no changes to publish.  I consider
moving a method from one package to another to be a change I'd like to
see published. Is this a limitation of the Merge tool? Is it possible
that this could be addressed?

David Buck
Simberon Inc.
www.simberon.com

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

davidbuck
I should qualify the example.

I have both packages as part of a bundle which I publish and merge.

Old structure:

Bundle A
    Package A
       Class A
          method foo
    Package B

New structure:

Bundle A
    Package A
       Class A
    Package B
       Class A
          method foo

All publishing and merging is on Bundle A.

David Buck
Simberon Inc.
www.simberon.com

David Buck wrote:
Select a method in Package A and move the method as an extension in 
Package B. Publish as a branch. Now, load the original head version and 
merge the branch. The merge tool shows no results and if you try to 
publish, it claims that there are no changes to publish.  I consider 
moving a method from one package to another to be a change I'd like to 
see published. Is this a limitation of the Merge tool? Is it possible 
that this could be addressed?

David Buck
Simberon Inc.
www.simberon.com

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

kobetic
In reply to this post by davidbuck
That is something we do quite often. Did the bundle publish properly ? Which version of VW ?

"David Buck"<[hidden email]> wrote:

> I should qualify the example.
>
> I have both packages as part of a bundle which I publish and merge.
>
> Old structure:
>
> Bundle A
>     Package A
>        Class A
>           method foo
>     Package B
>
> New structure:
>
> Bundle A
>     Package A
>        Class A
>     Package B
>        Class A
>           method foo
>
> All publishing and merging is on Bundle A.
>
> David Buck
> Simberon Inc.
> www.simberon.com
>
> David Buck wrote:
> > Select a method in Package A and move the method as an extension in
> > Package B. Publish as a branch. Now, load the original head version and
> > merge the branch. The merge tool shows no results and if you try to
> > publish, it claims that there are no changes to publish.  I consider
> > moving a method from one package to another to be a change I'd like to
> > see published. Is this a limitation of the Merge tool? Is it possible
> > that this could be addressed?
> >
> > David Buck
> > Simberon Inc.
> > www.simberon.com
> >
> > _______________________________________________
> > vwnc mailing list
> > [hidden email]
> > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
> > ------------------------------------------------------------------------
> >
> >
> > No virus found in this incoming message.
> > Checked by AVG - www.avg.com
> > Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00
> >
> >  
>
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

davidbuck
Version 7.7.  The bundle published properly.  If I load the bundle directly, I see that the method was moved.  If I merge, it reports no changes.  Try it out.

David

[hidden email] wrote:
That is something we do quite often. Did the bundle publish properly ? Which version of VW ?

"David Buck"[hidden email] wrote:
  
I should qualify the example.

I have both packages as part of a bundle which I publish and merge.

Old structure:

Bundle A
    Package A
       Class A
          method foo
    Package B

New structure:

Bundle A
    Package A
       Class A
    Package B
       Class A
          method foo

All publishing and merging is on Bundle A.

David Buck
Simberon Inc.
www.simberon.com

David Buck wrote:
    
Select a method in Package A and move the method as an extension in 
Package B. Publish as a branch. Now, load the original head version and 
merge the branch. The merge tool shows no results and if you try to 
publish, it claims that there are no changes to publish.  I consider 
moving a method from one package to another to be a change I'd like to 
see published. Is this a limitation of the Merge tool? Is it possible 
that this could be addressed?

David Buck
Simberon Inc.
www.simberon.com

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00

  
      
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

    

No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

davidbuck
In reply to this post by kobetic
The same thing happens when you try to merge in a change where you move a class from one package to another.  It reports no changes.

David

[hidden email] wrote:
That is something we do quite often. Did the bundle publish properly ? Which version of VW ?

"David Buck"[hidden email] wrote:
  
I should qualify the example.

I have both packages as part of a bundle which I publish and merge.

Old structure:

Bundle A
    Package A
       Class A
          method foo
    Package B

New structure:

Bundle A
    Package A
       Class A
    Package B
       Class A
          method foo

All publishing and merging is on Bundle A.

David Buck
Simberon Inc.
www.simberon.com

David Buck wrote:
    
Select a method in Package A and move the method as an extension in 
Package B. Publish as a branch. Now, load the original head version and 
merge the branch. The merge tool shows no results and if you try to 
publish, it claims that there are no changes to publish.  I consider 
moving a method from one package to another to be a change I'd like to 
see published. Is this a limitation of the Merge tool? Is it possible 
that this could be addressed?

David Buck
Simberon Inc.
www.simberon.com

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00

  
      
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

    

No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

Samuel S. Shuster-2
In reply to this post by davidbuck
David:

> Select a method in Package A and move the method as an extension in
> Package B. Publish as a branch. Now, load the original head version and
> merge the branch. The merge tool shows no results and if you try to
> publish, it claims that there are no changes to publish.  I consider
> moving a method from one package to another to be a change I'd like to
> see published. Is this a limitation of the Merge tool? Is it possible
> that this could be addressed?


This is addressed in 7.7.1 with whole new (Glorp based) Merge and Comparison engines.

                                And So It Goes
                                     Sames
______________________________________________________________________

Samuel S. Shuster [|]
VisualWorks Engineering, Store Project
Smalltalk Enables Success -- What Are YOU Using?





_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

kobetic
In reply to this post by davidbuck
OK, I can confirm that problem in 7.7, it seems to be fixed in 7.7.1 builds. I'm being told that there were significant changes in the merge engine, so I can't offer a quick patch at this point.

"David Buck"<[hidden email]> wrote:

> The same thing happens when you try to merge in a change where you move
> a class from one package to another.  It reports no changes.
>
> David
>
> [hidden email] wrote:
> > That is something we do quite often. Did the bundle publish properly ? Which version of VW ?
> >
> > "David Buck"<[hidden email]> wrote:
> >  
> >> I should qualify the example.
> >>
> >> I have both packages as part of a bundle which I publish and merge.
> >>
> >> Old structure:
> >>
> >> Bundle A
> >>     Package A
> >>        Class A
> >>           method foo
> >>     Package B
> >>
> >> New structure:
> >>
> >> Bundle A
> >>     Package A
> >>        Class A
> >>     Package B
> >>        Class A
> >>           method foo
> >>
> >> All publishing and merging is on Bundle A.
> >>
> >> David Buck
> >> Simberon Inc.
> >> www.simberon.com
> >>
> >> David Buck wrote:
> >>    
> >>> Select a method in Package A and move the method as an extension in
> >>> Package B. Publish as a branch. Now, load the original head version and
> >>> merge the branch. The merge tool shows no results and if you try to
> >>> publish, it claims that there are no changes to publish.  I consider
> >>> moving a method from one package to another to be a change I'd like to
> >>> see published. Is this a limitation of the Merge tool? Is it possible
> >>> that this could be addressed?
> >>>
> >>> David Buck
> >>> Simberon Inc.
> >>> www.simberon.com
> >>>
> >>> _______________________________________________
> >>> vwnc mailing list
> >>> [hidden email]
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
> >>> ------------------------------------------------------------------------
> >>>
> >>>
> >>> No virus found in this incoming message.
> >>> Checked by AVG - www.avg.com
> >>> Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00
> >>>
> >>>  
> >>>      
> >> _______________________________________________
> >> vwnc mailing list
> >> [hidden email]
> >> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
> >>
> >>    
> >> ------------------------------------------------------------------------
> >>
> >>
> >> No virus found in this incoming message.
> >> Checked by AVG - www.avg.com
> >> Version: 9.0.819 / Virus Database: 271.1.1/2873 - Release Date: 05/14/10 02:26:00
> >>
> >>    
>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: Merge tool doesn't recognize method moves

davidbuck
In reply to this post by Samuel S. Shuster-2
Samuel S. Shuster wrote:
David:

  
Select a method in Package A and move the method as an extension in 
Package B. Publish as a branch. Now, load the original head version and 
merge the branch. The merge tool shows no results and if you try to 
publish, it claims that there are no changes to publish.  I consider 
moving a method from one package to another to be a change I'd like to 
see published. Is this a limitation of the Merge tool? Is it possible 
that this could be addressed?
    


This is addressed in 7.7.1 with whole new (Glorp based) Merge and Comparison engines.

                                And So It Goes
                                     Sames
  
Thanks, Sam and Martin. I look forward to seeing the new version.

David Buck


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc