Merging SUnit changes from Pharo

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Merging SUnit changes from Pharo

Holger Freyther
Hi all,

while toying with Grease and playing with the now removed ColorTest I noticed
that it is using the concept of expected failures and that it was added in
Pharo and that our copy of Pharo is lacking it.

I have started merging the SUnit changes back. The first patch is a
preparation, patch adds new selectors, patch three changes the meaning of
passed and failures and patch four is done by me as Pharo added new features
but no unit tests for SUnit.


 SUnit.st      |  109
++++++++++++++++++++++++++++++++++++++++++++++------------
 SUnitTests.st |   33 +++++++++++++++++
 2 files changed, 120 insertions(+), 22 deletions(-)


feedback is welcome, i will continue to merge in the other changes as well...

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-SUnit-Initialize-errors-failures-and-passed-in-the-i.patch (2K) Download Attachment
0002-SUnit-Add-new-selectors-from-Pharo-for-handling-un-e.patch (2K) Download Attachment
0003-SUnit-Use-the-new-selectors-for-un-expected-failure-.patch (2K) Download Attachment
0004-SUnit-Add-a-test-case-for-expectedDefects-and-unexpe.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Merging SUnit changes from Pharo

Paolo Bonzini-2
On 04/15/2010 02:56 PM, Holger Hans Peter Freyther wrote:
>       defaultLogPolicyClass [
>   <category: 'Accessing'>
> - ^TestCondensedLog
> + ^TestVerboseLog
>       ]

This is wrong, otherwise looks great.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Merging SUnit changes from Pharo

Holger Freyther
On Thursday 15 April 2010 15:41:27 you wrote:

> This is wrong, otherwise looks great.

oops, this must have sneaked in with the last rebase. Should I rebase and send
updated patches?



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Merging SUnit changes from Pharo

Holger Freyther
On Thursday 15 April 2010 16:37:26 you wrote:
> On Thursday 15 April 2010 15:41:27 you wrote:
> > This is wrong, otherwise looks great.
>
> oops, this must have sneaked in with the last rebase. Should I rebase and
> send updated patches?

Oh that was too fast. I will send updated patches I need to write ChangeLog
entries too. :)


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Merging SUnit changes from Pharo

Holger Freyther
On Thursday 15 April 2010 16:38:13 Holger Hans Peter Freyther wrote:
> On Thursday 15 April 2010 16:37:26 you wrote:
> > On Thursday 15 April 2010 15:41:27 you wrote:
> > > This is wrong, otherwise looks great.
> >
> > oops, this must have sneaked in with the last rebase. Should I rebase and
> > send updated patches?
>
> Oh that was too fast. I will send updated patches I need to write ChangeLog
> entries too. :)

Hi all,

this is an updated changeset, the patch four has the garbage removed and I
added ChangeLog entries. Is that ready to merge? Is there anything missing?

regards
        holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-SUnit-Initialize-errors-failures-and-passed-in-the-i.patch (3K) Download Attachment
0002-SUnit-Add-new-selectors-from-Pharo-for-handling-un-e.patch (3K) Download Attachment
0003-SUnit-Use-the-new-selectors-for-un-expected-failure-.patch (3K) Download Attachment
0004-SUnit-Add-a-test-case-for-expectedDefects-and-unexpe.patch (2K) Download Attachment