Smalltalk › Pharo › Pharo Smalltalk Users

Metacello with Git

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

38 messages Options

EstebanLM

Re: Metacello with Git

if you have iceberg metacello integration enabled (default in 7.0), the repository is resolved as part of iceberg and then it does not instances a MC*Repository but an IceMetacelloRepositoryAdaptor.
Then it works on baselines, etc.

Esteban

> On 2 Jan 2018, at 17:18, Sean P. DeNigris <[hidden email]> wrote:
>
> EstebanLM wrote
>> MC*Repository is not iceberg but monticello api.
>
> Except it is extended by Iceberg-Adapters for #httpsUrl and #scpUrl! Also,
> MCBitbucketRepository is hardcoded in
> IceProviderRepositoryType>>#mcRepository, which was mangling the URL (off
> the top of my head I assume because 'bitbucket' is longer than 'gitlab').
> This is all in #60528. I don't see how people could be using this unless
> it's fixed in 7.0 (which it doesn't appear to be because there still seems
> not to be an MCGitlabRepository) or they are using filetree:// or similar
> URLs in their baselines.
>
>
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html
>

Sean P. DeNigris

Re: Metacello with Git

Administrator

EstebanLM wrote
> if you have iceberg metacello integration enabled… Then it works on
> baselines, etc.

Strange. I did `Iceberg enableMetacelloIntegration: true.` first and still
got the error. I can't easily test in 7 because it depends on Magritte which
depends on Grease which doesn't seem to load yet. Maybe I can cobble
together a simpler test case.

The Git error I mentioned in my OP was caused because `LGitRepository >>
clone:options:to:` is trying to clone
'[hidden email]:nDeNigris/Quote-Me.git' based on
`gitlab://SeanDeNigris/Quote-Me:master/repository` from the baseline spec.
Earlier in the stack, `IceProviderRepositoryType >> mcRepository` is using
`MCBitbucketRepository` which is hardcoded.

All of the above is with iceberg metacello integration enabled.

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

alistairgrant

Re: Metacello with Git

Hi Sean,

On 2 January 2018 at 18:00, Sean P. DeNigris <[hidden email]> wrote:
> EstebanLM wrote
>> if you have iceberg metacello integration enabled… Then it works on
>> baselines, etc.
>
> Strange. I did `Iceberg enableMetacelloIntegration: true.` first and still
> got the error. I can't easily test in 7 because it depends on Magritte which
> depends on Grease which doesn't seem to load yet. Maybe I can cobble
> together a simpler test case.

This may not help, but...

Pharo 7.0
Build information:
Pharo-7.0+alpha.build.398.sha.52a28a857deec25612d302aba8ab09bdd6212b31
(32 Bit)

I have Pillar loaded, which in turn loads:

ConfigurationOfMagritte3-topa.126
Magritte-Model-SeanDeNigris.465
Magritte-Morph-SeanDeNigris.95
Magritte-Pharo3-Model-JohnCBorden.4
ConfigurationOfGrease-StephanEggermont.348
Grease-Core-JohanBrichau.97
Grease-Pharo30-Core-PavelKrivanek.22

The image was built about 4 days ago.

HTH,
Alistair

> The Git error I mentioned in my OP was caused because `LGitRepository >>
> clone:options:to:` is trying to clone
> '[hidden email]:nDeNigris/Quote-Me.git' based on
> `gitlab://SeanDeNigris/Quote-Me:master/repository` from the baseline spec.
> Earlier in the stack, `IceProviderRepositoryType >> mcRepository` is using
> `MCBitbucketRepository` which is hardcoded.
>
> All of the above is with iceberg metacello integration enabled.
>
>
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html
>

EstebanLM

Re: Metacello with Git

In reply to this post by Sean P. DeNigris

> On 2 Jan 2018, at 18:00, Sean P. DeNigris <[hidden email]> wrote:
>
> EstebanLM wrote
>> if you have iceberg metacello integration enabled… Then it works on
>> baselines, etc.
>
> Strange. I did `Iceberg enableMetacelloIntegration: true.` first and still
> got the error. I can't easily test in 7 because it depends on Magritte which
> depends on Grease which doesn't seem to load yet. Maybe I can cobble
> together a simpler test case.
>
> The Git error I mentioned in my OP was caused because `LGitRepository >>
> clone:options:to:` is trying to clone
> '[hidden email]:nDeNigris/Quote-Me.git' based on
> `gitlab://SeanDeNigris/Quote-Me:master/repository` from the baseline spec.
> Earlier in the stack, `IceProviderRepositoryType >> mcRepository` is using
> `MCBitbucketRepository` which is hardcoded.
>
> All of the above is with iceberg metacello integration enabled.

yep. that seems to be a bug.

Esteban

>
>
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html
>

Stephane Ducasse-3

Re: Metacello with Git

In reply to this post by alistairgrant

Hi Alistair

About pillar, we are working on a new pipeline and lot of cleaning
compared to the version available on smalltalkhub.
The new version Branch new pipeline seems broken (I will check it
tomorrow it cannot handle internal references).
I want to be able to build the old books with the new version. Now it
is not working.

Stef

On Tue, Jan 2, 2018 at 6:08 PM, Alistair Grant <[hidden email]> wrote:

> Hi Sean,
>
> On 2 January 2018 at 18:00, Sean P. DeNigris <[hidden email]> wrote:
>> EstebanLM wrote
>>> if you have iceberg metacello integration enabled… Then it works on
>>> baselines, etc.
>>
>> Strange. I did `Iceberg enableMetacelloIntegration: true.` first and still
>> got the error. I can't easily test in 7 because it depends on Magritte which
>> depends on Grease which doesn't seem to load yet. Maybe I can cobble
>> together a simpler test case.
>
> This may not help, but...
>
> Pharo 7.0
> Build information:
> Pharo-7.0+alpha.build.398.sha.52a28a857deec25612d302aba8ab09bdd6212b31
> (32 Bit)
>
> I have Pillar loaded, which in turn loads:
>
> ConfigurationOfMagritte3-topa.126
> Magritte-Model-SeanDeNigris.465
> Magritte-Morph-SeanDeNigris.95
> Magritte-Pharo3-Model-JohnCBorden.4
> ConfigurationOfGrease-StephanEggermont.348
> Grease-Core-JohanBrichau.97
> Grease-Pharo30-Core-PavelKrivanek.22
>
> The image was built about 4 days ago.
>
> HTH,
> Alistair
>
>
>
>> The Git error I mentioned in my OP was caused because `LGitRepository >>
>> clone:options:to:` is trying to clone
>> '[hidden email]:nDeNigris/Quote-Me.git' based on
>> `gitlab://SeanDeNigris/Quote-Me:master/repository` from the baseline spec.
>> Earlier in the stack, `IceProviderRepositoryType >> mcRepository` is using
>> `MCBitbucketRepository` which is hardcoded.
>>
>> All of the above is with iceberg metacello integration enabled.
>>
>>
>>
>> -----
>> Cheers,
>> Sean
>> --
>> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html
>>
>

Sean P. DeNigris

Re: Metacello with Git

Administrator

In reply to this post by EstebanLM

EstebanLM wrote
> yep. that seems to be a bug.

Okay, I hacked a solution. Before I submit the fix I want to verify: no one
has been successfully using gitlab:// URLs in a MetaC baseline spec for a
private dependent project (accessed via SSH keys), right?

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

NorbertHartl

Re: Metacello with Git

> Am 03.01.2018 um 00:26 schrieb Sean P. DeNigris <[hidden email]>:
>
> EstebanLM wrote
>> yep. that seems to be a bug.
>
> Okay, I hacked a solution. Before I submit the fix I want to verify: no one
> has been successfully using gitlab:// URLs in a MetaC baseline spec for a
> private dependent project (accessed via SSH keys), right?
>
>

There were no classes to support it. Only github and bitbucket. So, yes!!

Norbert
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

alistairgrant

Re: Metacello with Git

In reply to this post by Stephane Ducasse-3

Hi Stef,

On 2 January 2018 at 20:11, Stephane Ducasse <[hidden email]> wrote:

> Hi Alistair
>
> About pillar, we are working on a new pipeline and lot of cleaning
> compared to the version available on smalltalkhub.
> The new version Branch new pipeline seems broken (I will check it
> tomorrow it cannot handle internal references).
> I want to be able to build the old books with the new version. Now it
> is not working.
>
> Stef

Yep, I remember you also mentioning that you're planning to decouple
the core Pillar from Magritte and Grease. All of this will make our
lives easier.

Thanks,
Alistair

> On Tue, Jan 2, 2018 at 6:08 PM, Alistair Grant <[hidden email]> wrote:
>> Hi Sean,
>>
>> On 2 January 2018 at 18:00, Sean P. DeNigris <[hidden email]> wrote:
>>> EstebanLM wrote
>>>> if you have iceberg metacello integration enabled… Then it works on
>>>> baselines, etc.
>>>
>>> Strange. I did `Iceberg enableMetacelloIntegration: true.` first and still
>>> got the error. I can't easily test in 7 because it depends on Magritte which
>>> depends on Grease which doesn't seem to load yet. Maybe I can cobble
>>> together a simpler test case.
>>
>> This may not help, but...
>>
>> Pharo 7.0
>> Build information:
>> Pharo-7.0+alpha.build.398.sha.52a28a857deec25612d302aba8ab09bdd6212b31
>> (32 Bit)
>>
>> I have Pillar loaded, which in turn loads:
>>
>> ConfigurationOfMagritte3-topa.126
>> Magritte-Model-SeanDeNigris.465
>> Magritte-Morph-SeanDeNigris.95
>> Magritte-Pharo3-Model-JohnCBorden.4
>> ConfigurationOfGrease-StephanEggermont.348
>> Grease-Core-JohanBrichau.97
>> Grease-Pharo30-Core-PavelKrivanek.22
>>
>> The image was built about 4 days ago.
>>
>> HTH,
>> Alistair
>>
>>
>>
>>> The Git error I mentioned in my OP was caused because `LGitRepository >>
>>> clone:options:to:` is trying to clone
>>> '[hidden email]:nDeNigris/Quote-Me.git' based on
>>> `gitlab://SeanDeNigris/Quote-Me:master/repository` from the baseline spec.
>>> Earlier in the stack, `IceProviderRepositoryType >> mcRepository` is using
>>> `MCBitbucketRepository` which is hardcoded.
>>>
>>> All of the above is with iceberg metacello integration enabled.
>>>
>>>
>>>
>>> -----
>>> Cheers,
>>> Sean
>>> --
>>> Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html
>>>
>>
>

Stephane Ducasse-3

Re: Metacello with Git

>>
>> About pillar, we are working on a new pipeline and lot of cleaning
>> compared to the version available on smalltalkhub.
>> The new version Branch new pipeline seems broken (I will check it
>> tomorrow it cannot handle internal references).
>> I want to be able to build the old books with the new version. Now it
>> is not working.
>>
>> Stef
>
> Yep, I remember you also mentioning that you're planning to decouple
> the core Pillar from Magritte and Grease. All of this will make our
> lives easier.

There were some real glitches in the newpipeline and now I'm ready to
produce a booklet.
Now I will check and fix some more...
And yes I want to remove the dependencies to Magritte and Grease and
get a modular core.
But first I want to arrive to a stable point and migrate all the books
and booklets to Pillar 70.

Then I will work on a new version of Cocoon and integrate it to pillar
and remove magritte.
Some I imagine that it may take me 6 months (because I'm doing far too
many things).

Stef

Sean P. DeNigris

Re: Metacello with Git

Administrator

In reply to this post by EstebanLM

EstebanLM wrote
> yep. that seems to be a bug.

20953: Gitlab Private Project Support (via Iceberg)
https://pharo.fogbugz.com/f/cases/20953/

PRs issued
- https://github.com/pharo-project/pharo/pull/667
- https://github.com/pharo-vcs/iceberg/pull/559

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

Sean P. DeNigris

Re: Metacello with Git

Administrator

Sean P. DeNigris wrote
> 20953: Gitlab Private Project Support (via Iceberg)
> https://pharo.fogbugz.com/f/cases/20953/
>
> PRs issued
> - https://github.com/pharo-project/pharo/pull/667
> - https://github.com/pharo-vcs/iceberg/pull/559

These both have been integrated. Will someone confirm they are able to load
a private Gitlab project via Iceberg and SSH key authentication? You'll
probably have to update Iceberg, which I'm not sure how to do. Esteban?

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

Sean P. DeNigris

Re: Metacello with Git

Administrator

Sean P. DeNigris wrote
> These both have been integrated.

Hmm, I'm confused. PR #667, which seems definitely to include
MCGitlabRepository, has been merged into the dev branch [1], but
MCGitlabRepository is not present in a fresh Pharo 7 image with "Build
information:
Pharo-7.0+alpha.build.438.sha.b28d466f661cbf73f9b63f91174032bcee843d26 (32
Bit)". Is this because the build aborted? I logged into Jenkins [2], but
didn't see an option to restart the build…

1.
https://github.com/pharo-project/pharo/commit/b28d466f661cbf73f9b63f91174032bcee843d26
2.
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/438/

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

Sean P. DeNigris

Re: Metacello with Git

Administrator

In reply to this post by Sean P. DeNigris

An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean

Guillermo Polito

Re: Metacello with Git

I've seen that the other day. The package is in the repository but is not loaded in the image. Probably somebody committed it but not added it into any baseline.

On Fri, Feb 2, 2018 at 4:35 AM, Sean P. DeNigris <[hidden email]> wrote:

An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Guille Polito

Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille

CRIStAL - UMR 9189

French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io

Phone: +33 06 52 70 66 13

EstebanLM

Re: Metacello with Git

yes, I asked Pavel to look at it…

Esteban

On 2 Feb 2018, at 09:38, Guillermo Polito <[hidden email]> wrote:

I've seen that the other day. The package is in the repository but is not loaded in the image. Probably somebody committed it but not added it into any baseline.

On Fri, Feb 2, 2018 at 4:35 AM, Sean P. DeNigris <[hidden email]> wrote:
An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

--

Guille Polito
Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io
Phone: +33 06 52 70 66 13

Pavel Krivanek-3

Re: Metacello with Git

the pull request was against the issue branch, not the development one, so the merging of it had no real effect. I created a new one (https://github.com/pharo-project/pharo/pull/790)

-- Pavel

2018-02-02 9:47 GMT+01:00 Esteban Lorenzano <[hidden email]>:

yes, I asked Pavel to look at it…

Esteban

On 2 Feb 2018, at 09:38, Guillermo Polito <[hidden email]> wrote:

I've seen that the other day. The package is in the repository but is not loaded in the image. Probably somebody committed it but not added it into any baseline.

On Fri, Feb 2, 2018 at 4:35 AM, Sean P. DeNigris <[hidden email]> wrote:
An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

--

Guille Polito
Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io
Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

EstebanLM

Re: Metacello with Git

thanks!

On 2 Feb 2018, at 10:12, Pavel Krivanek <[hidden email]> wrote:

the pull request was against the issue branch, not the development one, so the merging of it had no real effect. I created a new one (https://github.com/pharo-project/pharo/pull/790)

-- Pavel

2018-02-02 9:47 GMT+01:00 Esteban Lorenzano <[hidden email]>:
yes, I asked Pavel to look at it…

Esteban

On 2 Feb 2018, at 09:38, Guillermo Polito <[hidden email]> wrote:

I've seen that the other day. The package is in the repository but is not loaded in the image. Probably somebody committed it but not added it into any baseline.

On Fri, Feb 2, 2018 at 4:35 AM, Sean P. DeNigris <[hidden email]> wrote:
An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

--

Guille Polito
Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io
Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank" class="">+33 06 52 70 66 13

Sean P. DeNigris

Re: Metacello with Git

Administrator

In reply to this post by Pavel Krivanek-3

Pavel Krivanek-3 wrote
> the pull request was against the issue branch, not the development one, so
> the merging of it had no real effect

Oops, he he thanks.

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Cheers,
Sean