MetaclassTest>>testMetaclassAndT
Locked
MetaclassTest>>testMetaclassAndT
 
|
Hi,
I am trying to load a new version of STON in Pharo 5 https://pharo.fogbugz.com/f/cases/16893/Update-STON One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass What should I do ? Did I do something wrong ? Should I add to the exceptions defined in the test or should I add them to ClassTrait ? I think the first sounds the most correct. Thx, Sven |
Re: MetaclassTest>>testMetaclassAndT
|
|
The issue should be unrelated:
https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism Best regards, Henrik -----Original Message----- From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe Sent: Saturday, February 20, 2016 11:05 AM To: Pharo Development List <[hidden email]> Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules Hi, I am trying to load a new version of STON in Pharo 5 https://pharo.fogbugz.com/f/cases/16893/Update-STON One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass What should I do ? Did I do something wrong ? Should I add to the exceptions defined in the test or should I add them to ClassTrait ? I think the first sounds the most correct. Thx, Sven |
Re: MetaclassTest>>testMetaclassAndT
|
|
If I add (in #50591) my methods to the exception set in the middle, the test is green
self assert: (Metaclass localSelectors difference: ClassTrait localSelectors) = {#externalTypeAlias:. #baseClass. #basicLocalSelectors:. #basicLocalSelectors. #classClass. #isClass. #stonName. "<<<" #stonOn:. "<<<" #environment. #fileOutOn:. #fileOutOn:initializing:. #postCopy. #traitComposition. #traitComposition:. #veryDeepCopyWith:} asSet. I don't know about the other failures. > On 20 Feb 2016, at 11:37, Henrik Nergaard <[hidden email]> wrote: > > The issue should be unrelated: > > https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism > > Best regards, > Henrik > > -----Original Message----- > From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe > Sent: Saturday, February 20, 2016 11:05 AM > To: Pharo Development List <[hidden email]> > Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > Hi, > > I am trying to load a new version of STON in Pharo 5 > > https://pharo.fogbugz.com/f/cases/16893/Update-STON > > One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass > > What should I do ? Did I do something wrong ? > > Should I add to the exceptions defined in the test or should I add them to ClassTrait ? > > I think the first sounds the most correct. > > Thx, > > Sven > > |
Re: MetaclassTest>>testMetaclassAndT
|
|
Ah, test testMetaclass. Somehow I only read testClass....
Moving those two methods from Metaclass to TApplyingOnClassSide should make the test happy. Best regards, Henrik -----Original Message----- From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe Sent: Saturday, February 20, 2016 11:58 AM To: Pharo Development List <[hidden email]> Subject: Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules If I add (in #50591) my methods to the exception set in the middle, the test is green self assert: (Metaclass localSelectors difference: ClassTrait localSelectors) = {#externalTypeAlias:. #baseClass. #basicLocalSelectors:. #basicLocalSelectors. #classClass. #isClass. #stonName. "<<<" #stonOn:. "<<<" #environment. #fileOutOn:. #fileOutOn:initializing:. #postCopy. #traitComposition. #traitComposition:. #veryDeepCopyWith:} asSet. I don't know about the other failures. > On 20 Feb 2016, at 11:37, Henrik Nergaard <[hidden email]> wrote: > > The issue should be unrelated: > > https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism > > Best regards, > Henrik > > -----Original Message----- > From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe > Sent: Saturday, February 20, 2016 11:05 AM > To: Pharo Development List <[hidden email]> > Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > Hi, > > I am trying to load a new version of STON in Pharo 5 > > https://pharo.fogbugz.com/f/cases/16893/Update-STON > > One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass > > What should I do ? Did I do something wrong ? > > Should I add to the exceptions defined in the test or should I add them to ClassTrait ? > > I think the first sounds the most correct. > > Thx, > > Sven > > |
Re: MetaclassTest>>testMetaclassAndT
|
|
> On 20 Feb 2016, at 12:34, Henrik Nergaard <[hidden email]> wrote: > > Ah, test testMetaclass. Somehow I only read testClass.... > > Moving those two methods from Metaclass to TApplyingOnClassSide should make the test happy. Well, that looked strange at first, but I studied it a bit further and you are most probably right. I decided to move the methods. Thx > Best regards, > Henrik > > -----Original Message----- > From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe > Sent: Saturday, February 20, 2016 11:58 AM > To: Pharo Development List <[hidden email]> > Subject: Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > If I add (in #50591) my methods to the exception set in the middle, the test is green > > self > assert: > (Metaclass localSelectors difference: ClassTrait localSelectors) > = > {#externalTypeAlias:. > #baseClass. > #basicLocalSelectors:. > #basicLocalSelectors. > #classClass. > #isClass. > #stonName. "<<<" > #stonOn:. "<<<" > #environment. > #fileOutOn:. > #fileOutOn:initializing:. > #postCopy. > #traitComposition. > #traitComposition:. > #veryDeepCopyWith:} asSet. > > I don't know about the other failures. > >> On 20 Feb 2016, at 11:37, Henrik Nergaard <[hidden email]> wrote: >> >> The issue should be unrelated: >> >> https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism >> >> Best regards, >> Henrik >> >> -----Original Message----- >> From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe >> Sent: Saturday, February 20, 2016 11:05 AM >> To: Pharo Development List <[hidden email]> >> Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> Hi, >> >> I am trying to load a new version of STON in Pharo 5 >> >> https://pharo.fogbugz.com/f/cases/16893/Update-STON >> >> One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass >> >> What should I do ? Did I do something wrong ? >> >> Should I add to the exceptions defined in the test or should I add them to ClassTrait ? >> >> I think the first sounds the most correct. >> >> Thx, >> >> Sven >> >> > > > |
|
|
In reply to this post by Henrik Nergaard
May be I got wrong what you say.
But we should not link metaclass or TApplyingOnClassSide on Ston. Le 20/2/16 12:34, Henrik Nergaard a écrit : > Ah, test testMetaclass. Somehow I only read testClass.... > > Moving those two methods from Metaclass to TApplyingOnClassSide should make the test happy. > > Best regards, > Henrik > > -----Original Message----- > From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe > Sent: Saturday, February 20, 2016 11:58 AM > To: Pharo Development List <[hidden email]> > Subject: Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules > > If I add (in #50591) my methods to the exception set in the middle, the test is green > > self > assert: > (Metaclass localSelectors difference: ClassTrait localSelectors) > = > {#externalTypeAlias:. > #baseClass. > #basicLocalSelectors:. > #basicLocalSelectors. > #classClass. > #isClass. > #stonName. "<<<" > #stonOn:. "<<<" > #environment. > #fileOutOn:. > #fileOutOn:initializing:. > #postCopy. > #traitComposition. > #traitComposition:. > #veryDeepCopyWith:} asSet. > > I don't know about the other failures. > >> On 20 Feb 2016, at 11:37, Henrik Nergaard <[hidden email]> wrote: >> >> The issue should be unrelated: >> >> https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism >> >> Best regards, >> Henrik >> >> -----Original Message----- >> From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe >> Sent: Saturday, February 20, 2016 11:05 AM >> To: Pharo Development List <[hidden email]> >> Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> Hi, >> >> I am trying to load a new version of STON in Pharo 5 >> >> https://pharo.fogbugz.com/f/cases/16893/Update-STON >> >> One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass >> >> What should I do ? Did I do something wrong ? >> >> Should I add to the exceptions defined in the test or should I add them to ClassTrait ? >> >> I think the first sounds the most correct. >> >> Thx, >> >> Sven >> >> > > > |
Re: MetaclassTest>>testMetaclassAndT
|
|
it is in an extension protocol, like fuel and others
> On 23 Feb 2016, at 08:39, stepharo <[hidden email]> wrote: > > May be I got wrong what you say. > > But we should not link metaclass or > > TApplyingOnClassSide on Ston. > > > Le 20/2/16 12:34, Henrik Nergaard a écrit : >> Ah, test testMetaclass. Somehow I only read testClass.... >> >> Moving those two methods from Metaclass to TApplyingOnClassSide should make the test happy. >> >> Best regards, >> Henrik >> >> -----Original Message----- >> From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe >> Sent: Saturday, February 20, 2016 11:58 AM >> To: Pharo Development List <[hidden email]> >> Subject: Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> If I add (in #50591) my methods to the exception set in the middle, the test is green >> >> self >> assert: >> (Metaclass localSelectors difference: ClassTrait localSelectors) >> = >> {#externalTypeAlias:. >> #baseClass. >> #basicLocalSelectors:. >> #basicLocalSelectors. >> #classClass. >> #isClass. >> #stonName. "<<<" >> #stonOn:. "<<<" >> #environment. >> #fileOutOn:. >> #fileOutOn:initializing:. >> #postCopy. >> #traitComposition. >> #traitComposition:. >> #veryDeepCopyWith:} asSet. >> >> I don't know about the other failures. >> >>> On 20 Feb 2016, at 11:37, Henrik Nergaard <[hidden email]> wrote: >>> >>> The issue should be unrelated: >>> >>> https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-Traits-Polymorphism >>> >>> Best regards, >>> Henrik >>> >>> -----Original Message----- >>> From: Pharo-dev [mailto:[hidden email]] On Behalf Of Sven Van Caekenberghe >>> Sent: Saturday, February 20, 2016 11:05 AM >>> To: Pharo Development List <[hidden email]> >>> Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >>> >>> Hi, >>> >>> I am trying to load a new version of STON in Pharo 5 >>> >>> https://pharo.fogbugz.com/f/cases/16893/Update-STON >>> >>> One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >>> >>> More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass >>> >>> What should I do ? Did I do something wrong ? >>> >>> Should I add to the exceptions defined in the test or should I add them to ClassTrait ? >>> >>> I think the first sounds the most correct. >>> >>> Thx, >>> >>> Sven >>> >>> >> >> >> > > |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |