Smalltalk › Gnu

MethodDictionary

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

MrGwen

MethodDictionary

Hi,

There is a small bug in the class description in dict.c;
the super class of MethodDictionary should be IdentityDictionary.
Changing the superclass introduce a regression in Seaside (I've just
quickly fix the regression may be it's wrong)

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

superclass-method.patch (1K) Download Attachment

MrGwen

Re: MethodDictionary

On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
> Hi,
>
> There is a small bug in the class description in dict.c;
> the super class of MethodDictionary should be IdentityDictionary.
> Changing the superclass introduce a regression in Seaside (I've just
> quickly fix the regression may be it's wrong)
>
> Gwen

Hi again ;-)

I've updated the vm to support identitydictionary with ivars

commits in branch safeMthDic (git://github.com/MrGwen/GNU-Smalltalk.git) :

9c1ac380352e5b5f8809
e872154d0f99360a2ba2
ccd4111352ca75ad78de

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Paolo Bonzini-2

Re: MethodDictionary

In reply to this post by MrGwen

On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
> Changing the superclass introduce a regression in Seaside (I've just
> quickly fix the regression may be it's wrong)

What's the problem? There should be no difference if #selectors starts
returning an IdentitySet rather than a Set.

Otherwise, you can override #keysClass in MethodDictionary to make it
return a Set, but I don't see why...

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

MrGwen

Re: MethodDictionary

In reply to this post by MrGwen

On 05/25/2011 04:17 PM, Gwenael Casaccio wrote:

> On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
>> Hi,
>>
>> There is a small bug in the class description in dict.c;
>> the super class of MethodDictionary should be IdentityDictionary.
>> Changing the superclass introduce a regression in Seaside (I've just
>> quickly fix the regression may be it's wrong)
>>
>> Gwen
>
> Hi again ;-)
>
> I've updated the vm to support identitydictionary with ivars
>
> commits in branch safeMthDic (git://github.com/MrGwen/GNU-Smalltalk.git) :
>
> 9c1ac380352e5b5f8809
> e872154d0f99360a2ba2
> ccd4111352ca75ad78de
>
> Gwen

And the last 0373c852bf7a0cf64660 :-)

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Paolo Bonzini-2

Re: MethodDictionary

On 05/26/2011 10:55 AM, Gwenael Casaccio wrote:

> On 05/25/2011 04:17 PM, Gwenael Casaccio wrote:
>> On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
>>> Hi,
>>>
>>> There is a small bug in the class description in dict.c;
>>> the super class of MethodDictionary should be IdentityDictionary.
>>> Changing the superclass introduce a regression in Seaside (I've just
>>> quickly fix the regression may be it's wrong)
>>>
>>> Gwen
>>
>> Hi again ;-)
>>
>> I've updated the vm to support identitydictionary with ivars
>>
>> commits in branch safeMthDic
>> (git://github.com/MrGwen/GNU-Smalltalk.git) :
>>
>> 9c1ac380352e5b5f8809
>> e872154d0f99360a2ba2
>> ccd4111352ca75ad78de
>>
>> Gwen
>
> And the last 0373c852bf7a0cf64660 :-)

Can you send a "compound" patch? I'm interested in this change too.
Thanks!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Paolo Bonzini-2

Re: MethodDictionary

In reply to this post by MrGwen

On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
> Hi,
>
> There is a small bug in the class description in dict.c;
> the super class of MethodDictionary should be IdentityDictionary.
> Changing the superclass introduce a regression in Seaside (I've just
> quickly fix the regression may be it's wrong)

I fixed Seaside to send #asArray in #filenames (Gwen explained on IRC
that the bug arises from using #includes: with Strings in an
IdentitySet). For 3.2 I'll also override MethodDictionary>>#keysClass
to return Set; for 3.3 this will not be there.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

MrGwen

Re: MethodDictionary

In reply to this post by Paolo Bonzini-2

On 05/26/2011 11:16 AM, Paolo Bonzini wrote:

> On 05/26/2011 10:55 AM, Gwenael Casaccio wrote:
>> On 05/25/2011 04:17 PM, Gwenael Casaccio wrote:
>>> On 05/25/2011 03:35 PM, Gwenael Casaccio wrote:
>>>> Hi,
>>>>
>>>> There is a small bug in the class description in dict.c;
>>>> the super class of MethodDictionary should be IdentityDictionary.
>>>> Changing the superclass introduce a regression in Seaside (I've just
>>>> quickly fix the regression may be it's wrong)
>>>>
>>>> Gwen
>>>
>>> Hi again ;-)
>>>
>>> I've updated the vm to support identitydictionary with ivars
>>>
>>> commits in branch safeMthDic
>>> (git://github.com/MrGwen/GNU-Smalltalk.git) :
>>>
>>> 9c1ac380352e5b5f8809
>>> e872154d0f99360a2ba2
>>> ccd4111352ca75ad78de
>>>
>>> Gwen
>>
>> And the last 0373c852bf7a0cf64660 :-)
>
> Can you send a "compound" patch? I'm interested in this change too. Thanks!
>
> Paolo

So here is the patch.

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

mehtoddictionary.patch (14K) Download Attachment

Paolo Bonzini-2

Re: MethodDictionary

On 05/26/2011 03:48 PM, Gwenael Casaccio wrote:
>
> So here is the patch.

Applied (to master only), thanks!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk