(MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

(MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sabine Manaa
Hi,

I need this, too.

http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html

The bug was closed after transferring it to fogbugs:

https://pharo.fogbugz.com/f/cases/4825

Sebastian, may I ask you, how did you solve this?

regards
Sabine
Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
Yes, indeed

QuotedPrintableMimeConverter>>#mimeEncode is missing.

It shouldn’t be too hard to implement, although it is a bit of a ‘human’ format rather than a technical one.

http://en.wikipedia.org/wiki/Quoted-printable

I’ll see what I can do.

Sven

On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]> wrote:

> Hi,
>
> I need this, too.
>
> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>
> The bug was closed after transferring it to fogbugs:
>
> https://pharo.fogbugz.com/f/cases/4825
>
> Sebastian, may I ask you, how did you solve this?
>
> regards
> Sabine
>
>
>
>
> --
> View this message in context: http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.
>


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sabine Manaa
Hi Sven,

this would be great.

I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.

Example:
Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=

Regards
Sabine 


On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email]> wrote:
Yes, indeed

QuotedPrintableMimeConverter>>#mimeEncode is missing.

It shouldn’t be too hard to implement, although it is a bit of a ‘human’ format rather than a technical one.

http://en.wikipedia.org/wiki/Quoted-printable

I’ll see what I can do.

Sven

On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]> wrote:

> Hi,
>
> I need this, too.
>
> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>

> The bug was closed after transferring it to fogbugs:
>
> https://pharo.fogbugz.com/f/cases/4825
>
> Sebastian, may I ask you, how did you solve this?
>
> regards
> Sabine
>
>
>
>
> --
> View this message in context: http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.
>





If you reply to this email, your message will be added to the discussion below:
http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
To start a new topic under Pharo Smalltalk Users, email [hidden email]
To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sabine,

this is not of immediate help for you, but I once wrote a
QuotedPrintableEncode for VA Smalltalk. It is in productive use and
should handle both encoding and decoding just fine.
You can find it on vastgoodies.com and I am sure it is not hard to port
to Pharo.

More details:
http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/

HTH,

Joachim


Am 06.12.13 11:11, schrieb Sabine Knöfel:

> Hi Sven,
>
> this would be great.
>
> I need it for sending mails and some mail reader, e.g. Thunderbird on
> Mac (Thank you Joachim for reporting this bug :-) ) need this in the
> subject if there are special signs in it.
>
> Example:
> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>
> Regards
> Sabine
>
>
> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via
> Smalltalk] <[hidden email]
> </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>
>     Yes, indeed
>
>     QuotedPrintableMimeConverter>>#mimeEncode is missing.
>
>     It shouldn’t be too hard to implement, although it is a bit of a
>     ‘human’ format rather than a technical one.
>
>     http://en.wikipedia.org/wiki/Quoted-printable
>
>     I’ll see what I can do.
>
>     Sven
>
>     On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>     <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>
>     > Hi,
>     >
>     > I need this, too.
>     >
>     >
>     http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>     >
>
>     > The bug was closed after transferring it to fogbugs:
>     >
>     > https://pharo.fogbugz.com/f/cases/4825
>     >
>     > Sebastian, may I ask you, how did you solve this?
>     >
>     > regards
>     > Sabine
>     >
>     >
>     >
>     >
>     > --
>     > View this message in context:
>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>     > Sent from the Pharo Smalltalk Users mailing list archive at
>     Nabble.com.
>     >
>
>
>
>
>     ------------------------------------------------------------------------
>     If you reply to this email, your message will be added to the
>     discussion below:
>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>
>     To start a new topic under Pharo Smalltalk Users, email [hidden
>     email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>     To unsubscribe from (MimeConverter forEncoding:
>     'quoted-printable') subclass responsibility, click here.
>     NAML
>     <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
>
>
>
> ------------------------------------------------------------------------
> View this message in context: Re: (MimeConverter forEncoding:
> 'quoted-printable') subclass responsibility
> <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
> Sent from the Pharo Smalltalk Users mailing list archive
> <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.


--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
Hi Joachim,

On 06 Dec 2013, at 11:22, [hidden email] wrote:

> Hi Sabine,
>
> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.

So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?

How do you I get at the actual code ?

When doing a download, I get a .dat file. How do I open that ?

Sven

> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>
> HTH,
>
> Joachim
>
>
> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>> Hi Sven,
>>
>> this would be great.
>>
>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>
>> Example:
>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>
>> Regards
>> Sabine
>>
>>
>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>
>>    Yes, indeed
>>
>>    QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>
>>    It shouldn’t be too hard to implement, although it is a bit of a
>>    ‘human’ format rather than a technical one.
>>
>>    http://en.wikipedia.org/wiki/Quoted-printable
>>
>>    I’ll see what I can do.
>>
>>    Sven
>>
>>    On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>    <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>
>>    > Hi,
>>    >
>>    > I need this, too.
>>    >
>>    >
>>    http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>    >
>>
>>    > The bug was closed after transferring it to fogbugs:
>>    >
>>    > https://pharo.fogbugz.com/f/cases/4825
>>    >
>>    > Sebastian, may I ask you, how did you solve this?
>>    >
>>    > regards
>>    > Sabine
>>    >
>>    >
>>    >
>>    >
>>    > --
>>    > View this message in context:
>>    http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>    > Sent from the Pharo Smalltalk Users mailing list archive at
>>    Nabble.com.
>>    >
>>
>>
>>
>>
>>    ------------------------------------------------------------------------
>>    If you reply to this email, your message will be added to the
>>    discussion below:
>>    http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>
>>    To start a new topic under Pharo Smalltalk Users, email [hidden
>>    email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>    To unsubscribe from (MimeConverter forEncoding:
>>    'quoted-printable') subclass responsibility, click here.
>>    NAML
>>    <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sven,

Of course I don't mind. I'll be happy if you find it useful enough to
use it in Pharo.

The .dat is VAST's proprietary export format for code. So you'd have to
install VAST to get it.

I am not a Pharo contributor yet, so I will see if I can send you a
fileout of the code that should beasier to import into Pharo. I know
this is stupid, but I never worried about the license of such
mini-contributions. So if you want, it's MIT ;-)

Joachim



Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:

> Hi Joachim,
>
> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>
>> Hi Sabine,
>>
>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>
> How do you I get at the actual code ?
>
> When doing a download, I get a .dat file. How do I open that ?
>
> Sven
>
>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>
>> HTH,
>>
>> Joachim
>>
>>
>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>> Hi Sven,
>>>
>>> this would be great.
>>>
>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>
>>> Example:
>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>
>>> Regards
>>> Sabine
>>>
>>>
>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>
>>>     Yes, indeed
>>>
>>>     QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>
>>>     It shouldn’t be too hard to implement, although it is a bit of a
>>>     ‘human’ format rather than a technical one.
>>>
>>>     http://en.wikipedia.org/wiki/Quoted-printable
>>>
>>>     I’ll see what I can do.
>>>
>>>     Sven
>>>
>>>     On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>     <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>
>>>     > Hi,
>>>     >
>>>     > I need this, too.
>>>     >
>>>     >
>>>     http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>     >
>>>
>>>     > The bug was closed after transferring it to fogbugs:
>>>     >
>>>     > https://pharo.fogbugz.com/f/cases/4825
>>>     >
>>>     > Sebastian, may I ask you, how did you solve this?
>>>     >
>>>     > regards
>>>     > Sabine
>>>     >
>>>     >
>>>     >
>>>     >
>>>     > --
>>>     > View this message in context:
>>>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>     > Sent from the Pharo Smalltalk Users mailing list archive at
>>>     Nabble.com.
>>>     >
>>>
>>>
>>>
>>>
>>>     ------------------------------------------------------------------------
>>>     If you reply to this email, your message will be added to the
>>>     discussion below:
>>>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>
>>>     To start a new topic under Pharo Smalltalk Users, email [hidden
>>>     email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>     To unsubscribe from (MimeConverter forEncoding:
>>>     'quoted-printable') subclass responsibility, click here.
>>>     NAML
>>>     <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>
>> --
>> -----------------------------------------------------------------------
>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>> Fliederweg 1                         http://www.objektfabrik.de
>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>
>


--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2

On 06 Dec 2013, at 12:04, [hidden email] wrote:

> Hi Sven,
>
> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.

Great!

> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>
> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)

Yes, please send some .st files.

> Joachim
>
>
>
> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>> Hi Joachim,
>>
>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>
>>> Hi Sabine,
>>>
>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>
>> How do you I get at the actual code ?
>>
>> When doing a download, I get a .dat file. How do I open that ?
>>
>> Sven
>>
>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>
>>> HTH,
>>>
>>> Joachim
>>>
>>>
>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>> Hi Sven,
>>>>
>>>> this would be great.
>>>>
>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>
>>>> Example:
>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>
>>>> Regards
>>>> Sabine
>>>>
>>>>
>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>
>>>>    Yes, indeed
>>>>
>>>>    QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>
>>>>    It shouldn’t be too hard to implement, although it is a bit of a
>>>>    ‘human’ format rather than a technical one.
>>>>
>>>>    http://en.wikipedia.org/wiki/Quoted-printable
>>>>
>>>>    I’ll see what I can do.
>>>>
>>>>    Sven
>>>>
>>>>    On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>    <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>
>>>>    > Hi,
>>>>    >
>>>>    > I need this, too.
>>>>    >
>>>>    >
>>>>    http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>    >
>>>>
>>>>    > The bug was closed after transferring it to fogbugs:
>>>>    >
>>>>    > https://pharo.fogbugz.com/f/cases/4825
>>>>    >
>>>>    > Sebastian, may I ask you, how did you solve this?
>>>>    >
>>>>    > regards
>>>>    > Sabine
>>>>    >
>>>>    >
>>>>    >
>>>>    >
>>>>    > --
>>>>    > View this message in context:
>>>>    http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>    > Sent from the Pharo Smalltalk Users mailing list archive at
>>>>    Nabble.com.
>>>>    >
>>>>
>>>>
>>>>
>>>>
>>>>    ------------------------------------------------------------------------
>>>>    If you reply to this email, your message will be added to the
>>>>    discussion below:
>>>>    http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>
>>>>    To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>    email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>    To unsubscribe from (MimeConverter forEncoding:
>>>>    'quoted-printable') subclass responsibility, click here.
>>>>    NAML
>>>>    <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------
>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>
>>> --
>>> -----------------------------------------------------------------------
>>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>>> Fliederweg 1                         http://www.objektfabrik.de
>>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>
>>
>
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>
>


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sven,

here you are.
It's possible you get into minor troubles parsing the files, but the
code is short enough to even copy/paste it into Pharo I guess. Since it
is a fileout from VAST, you may need to tweak the categories for
monticello and such.

Please let me know if there are problems with the code, if you add new
tests or find bugs. I'd like to add stuff back to my code then.

Good luck,

Joachim



Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:

> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>
>> Hi Sven,
>>
>> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.
> Great!
>
>> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>>
>> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)
> Yes, please send some .st files.
>
>> Joachim
>>
>>
>>
>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>> Hi Joachim,
>>>
>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>
>>>> Hi Sabine,
>>>>
>>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>>
>>> How do you I get at the actual code ?
>>>
>>> When doing a download, I get a .dat file. How do I open that ?
>>>
>>> Sven
>>>
>>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>
>>>> HTH,
>>>>
>>>> Joachim
>>>>
>>>>
>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>> Hi Sven,
>>>>>
>>>>> this would be great.
>>>>>
>>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>>
>>>>> Example:
>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>
>>>>> Regards
>>>>> Sabine
>>>>>
>>>>>
>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>
>>>>>     Yes, indeed
>>>>>
>>>>>     QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>
>>>>>     It shouldn’t be too hard to implement, although it is a bit of a
>>>>>     ‘human’ format rather than a technical one.
>>>>>
>>>>>     http://en.wikipedia.org/wiki/Quoted-printable
>>>>>
>>>>>     I’ll see what I can do.
>>>>>
>>>>>     Sven
>>>>>
>>>>>     On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>     <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>
>>>>>     > Hi,
>>>>>     >
>>>>>     > I need this, too.
>>>>>     >
>>>>>     >
>>>>>     http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>     >
>>>>>
>>>>>     > The bug was closed after transferring it to fogbugs:
>>>>>     >
>>>>>     > https://pharo.fogbugz.com/f/cases/4825
>>>>>     >
>>>>>     > Sebastian, may I ask you, how did you solve this?
>>>>>     >
>>>>>     > regards
>>>>>     > Sabine
>>>>>     >
>>>>>     >
>>>>>     >
>>>>>     >
>>>>>     > --
>>>>>     > View this message in context:
>>>>>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>     > Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>     Nabble.com.
>>>>>     >
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>     ------------------------------------------------------------------------
>>>>>     If you reply to this email, your message will be added to the
>>>>>     discussion below:
>>>>>     http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>
>>>>>     To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>     email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>     To unsubscribe from (MimeConverter forEncoding:
>>>>>     'quoted-printable') subclass responsibility, click here.
>>>>>     NAML
>>>>>     <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------
>>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>> --
>>>> -----------------------------------------------------------------------
>>>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>>>> Fliederweg 1                         http://www.objektfabrik.de
>>>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>
>>
>> --
>> -----------------------------------------------------------------------
>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>> Fliederweg 1                         http://www.objektfabrik.de
>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>
>>
>
>

--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


QuotedPrintableCoder.st (1K) Download Attachment
QuotedPrintableCoderTest.st (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sven,

I just see there will be some problems with the test Strings in Pharo.
VAST is not Unicode aware yet, so the fileout of german umlauts and such
will very likely be wrong when pasting into Pharo.
I am happy to send you corrections for the decoded strings in the test
code if your German doesn't suffice. Just tell me which sentences are
imported wrong into Pharo...

I have never tested any other special characters than German ones.

Joachim


Am 06.12.13 12:14, schrieb [hidden email]:

> Hi Sven,
>
> here you are.
> It's possible you get into minor troubles parsing the files, but the
> code is short enough to even copy/paste it into Pharo I guess. Since
> it is a fileout from VAST, you may need to tweak the categories for
> monticello and such.
>
> Please let me know if there are problems with the code, if you add new
> tests or find bugs. I'd like to add stuff back to my code then.
>
> Good luck,
>
> Joachim
>
>
>
> Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
>> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>>
>>> Hi Sven,
>>>
>>> Of course I don't mind. I'll be happy if you find it useful enough
>>> to use it in Pharo.
>> Great!
>>
>>> The .dat is VAST's proprietary export format for code. So you'd have
>>> to install VAST to get it.
>>>
>>> I am not a Pharo contributor yet, so I will see if I can send you a
>>> fileout of the code that should beasier to import into Pharo. I know
>>> this is stupid, but I never worried about the license of such
>>> mini-contributions. So if you want, it's MIT ;-)
>> Yes, please send some .st files.
>>
>>> Joachim
>>>
>>>
>>>
>>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>>> Hi Joachim,
>>>>
>>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>>
>>>>> Hi Sabine,
>>>>>
>>>>> this is not of immediate help for you, but I once wrote a
>>>>> QuotedPrintableEncode for VA Smalltalk. It is in productive use
>>>>> and should handle both encoding and decoding just fine.
>>>>> You can find it on vastgoodies.com and I am sure it is not hard to
>>>>> port to Pharo.
>>>> So I guess you are OK with me looking at / porting your code ? Is
>>>> it MIT licensed or compatible ? Are you already a signed up Pharo
>>>> contributor ?
>>>>
>>>> How do you I get at the actual code ?
>>>>
>>>> When doing a download, I get a .dat file. How do I open that ?
>>>>
>>>> Sven
>>>>
>>>>> More details:
>>>>> http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>>
>>>>> HTH,
>>>>>
>>>>> Joachim
>>>>>
>>>>>
>>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>>> Hi Sven,
>>>>>>
>>>>>> this would be great.
>>>>>>
>>>>>> I need it for sending mails and some mail reader, e.g.
>>>>>> Thunderbird on Mac (Thank you Joachim for reporting this bug :-)
>>>>>> ) need this in the subject if there are special signs in it.
>>>>>>
>>>>>> Example:
>>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>>
>>>>>> Regards
>>>>>> Sabine
>>>>>>
>>>>>>
>>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via
>>>>>> Smalltalk] <[hidden email]
>>>>>> </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>>
>>>>>>     Yes, indeed
>>>>>>
>>>>>>     QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>>
>>>>>>     It shouldn’t be too hard to implement, although it is a bit of a
>>>>>>     ‘human’ format rather than a technical one.
>>>>>>
>>>>>>     http://en.wikipedia.org/wiki/Quoted-printable
>>>>>>
>>>>>>     I’ll see what I can do.
>>>>>>
>>>>>>     Sven
>>>>>>
>>>>>>     On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>> <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>>
>>>>>>     > Hi,
>>>>>>     >
>>>>>>     > I need this, too.
>>>>>>     >
>>>>>>     >
>>>>>> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>>     >
>>>>>>
>>>>>>     > The bug was closed after transferring it to fogbugs:
>>>>>>     >
>>>>>>     > https://pharo.fogbugz.com/f/cases/4825
>>>>>>     >
>>>>>>     > Sebastian, may I ask you, how did you solve this?
>>>>>>     >
>>>>>>     > regards
>>>>>>     > Sabine
>>>>>>     >
>>>>>>     >
>>>>>>     >
>>>>>>     >
>>>>>>     > --
>>>>>>     > View this message in context:
>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>>     > Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>>     Nabble.com.
>>>>>>     >
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>>     If you reply to this email, your message will be added to the
>>>>>>     discussion below:
>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>>
>>>>>>     To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>>     email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>>     To unsubscribe from (MimeConverter forEncoding:
>>>>>>     'quoted-printable') subclass responsibility, click here.
>>>>>>     NAML
>>>>>> <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> View this message in context: Re: (MimeConverter forEncoding:
>>>>>> 'quoted-printable') subclass responsibility
>>>>>> <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>>>
>>>>>> Sent from the Pharo Smalltalk Users mailing list archive
>>>>>> <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at
>>>>>> Nabble.com.
>>>>> --
>>>>> -----------------------------------------------------------------------
>>>>>
>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>
>>>
>>> --
>>> -----------------------------------------------------------------------
>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>> Fliederweg 1 http://www.objektfabrik.de
>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>
>>>
>>
>>
>
>


--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
Hi Joachim,

The code is perfectly readable, including the German (which I can read/understand more or less, speaking/writing is quite bad though), thanks a lot. I will try to port it later today or this evening.

Sven

On 06 Dec 2013, at 12:26, [hidden email] wrote:

> Hi Sven,
>
> I just see there will be some problems with the test Strings in Pharo. VAST is not Unicode aware yet, so the fileout of german umlauts and such will very likely be wrong when pasting into Pharo.
> I am happy to send you corrections for the decoded strings in the test code if your German doesn't suffice. Just tell me which sentences are imported wrong into Pharo...
>
> I have never tested any other special characters than German ones.
>
> Joachim
>
>
> Am 06.12.13 12:14, schrieb [hidden email]:
>> Hi Sven,
>>
>> here you are.
>> It's possible you get into minor troubles parsing the files, but the code is short enough to even copy/paste it into Pharo I guess. Since it is a fileout from VAST, you may need to tweak the categories for monticello and such.
>>
>> Please let me know if there are problems with the code, if you add new tests or find bugs. I'd like to add stuff back to my code then.
>>
>> Good luck,
>>
>> Joachim
>>
>>
>>
>> Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
>>> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>>>
>>>> Hi Sven,
>>>>
>>>> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.
>>> Great!
>>>
>>>> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>>>>
>>>> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)
>>> Yes, please send some .st files.
>>>
>>>> Joachim
>>>>
>>>>
>>>>
>>>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>>>> Hi Joachim,
>>>>>
>>>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>>>
>>>>>> Hi Sabine,
>>>>>>
>>>>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>>>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>>>>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>>>>
>>>>> How do you I get at the actual code ?
>>>>>
>>>>> When doing a download, I get a .dat file. How do I open that ?
>>>>>
>>>>> Sven
>>>>>
>>>>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>>>
>>>>>> HTH,
>>>>>>
>>>>>> Joachim
>>>>>>
>>>>>>
>>>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>>>> Hi Sven,
>>>>>>>
>>>>>>> this would be great.
>>>>>>>
>>>>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>>>>
>>>>>>> Example:
>>>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>>>
>>>>>>> Regards
>>>>>>> Sabine
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>>>
>>>>>>>    Yes, indeed
>>>>>>>
>>>>>>>    QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>>>
>>>>>>>    It shouldn’t be too hard to implement, although it is a bit of a
>>>>>>>    ‘human’ format rather than a technical one.
>>>>>>>
>>>>>>>    http://en.wikipedia.org/wiki/Quoted-printable
>>>>>>>
>>>>>>>    I’ll see what I can do.
>>>>>>>
>>>>>>>    Sven
>>>>>>>
>>>>>>>    On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>>> <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>>>
>>>>>>>    > Hi,
>>>>>>>    >
>>>>>>>    > I need this, too.
>>>>>>>    >
>>>>>>>    >
>>>>>>> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>>>    >
>>>>>>>
>>>>>>>    > The bug was closed after transferring it to fogbugs:
>>>>>>>    >
>>>>>>>    > https://pharo.fogbugz.com/f/cases/4825
>>>>>>>    >
>>>>>>>    > Sebastian, may I ask you, how did you solve this?
>>>>>>>    >
>>>>>>>    > regards
>>>>>>>    > Sabine
>>>>>>>    >
>>>>>>>    >
>>>>>>>    >
>>>>>>>    >
>>>>>>>    > --
>>>>>>>    > View this message in context:
>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>>>    > Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>>>    Nabble.com.
>>>>>>>    >
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------
>>>>>>>    If you reply to this email, your message will be added to the
>>>>>>>    discussion below:
>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>>>
>>>>>>>    To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>>>    email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>>>    To unsubscribe from (MimeConverter forEncoding:
>>>>>>>    'quoted-printable') subclass responsibility, click here.
>>>>>>>    NAML
>>>>>>> <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------
>>>>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>>>> --
>>>>>> -----------------------------------------------------------------------
>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>
>>>>
>>>> --
>>>> -----------------------------------------------------------------------
>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>> Fliederweg 1 http://www.objektfabrik.de
>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>
>>>>
>>>
>>>
>>
>>
>
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>
>


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
Hi Joachim,

I loaded/copied your code into Pharo 3.0 and made the necessary changes, as well as some simplifications, to make everything work. See the attached fileouts.

The tests were almost immediately green.

I have one question though, I had to change two tests to make them work:

#testDecodeCRLF

  self
   assert: (coder decode: 'This is the first line=0D=0A and this is the second')
   equals: 'This is the first line', String crlf, ' and this is the second’

You originally had a simple line break in the method’s string literal. But that results in a CR in Pharo. I added an explicit CRLF.

I had to make similar changes to #testEncodeSoftLinebreak.

Is that OK or not ?  What do you think ?

Sven


 


On 06 Dec 2013, at 12:52, Sven Van Caekenberghe <[hidden email]> wrote:

> Hi Joachim,
>
> The code is perfectly readable, including the German (which I can read/understand more or less, speaking/writing is quite bad though), thanks a lot. I will try to port it later today or this evening.
>
> Sven
>
> On 06 Dec 2013, at 12:26, [hidden email] wrote:
>
>> Hi Sven,
>>
>> I just see there will be some problems with the test Strings in Pharo. VAST is not Unicode aware yet, so the fileout of german umlauts and such will very likely be wrong when pasting into Pharo.
>> I am happy to send you corrections for the decoded strings in the test code if your German doesn't suffice. Just tell me which sentences are imported wrong into Pharo...
>>
>> I have never tested any other special characters than German ones.
>>
>> Joachim
>>
>>
>> Am 06.12.13 12:14, schrieb [hidden email]:
>>> Hi Sven,
>>>
>>> here you are.
>>> It's possible you get into minor troubles parsing the files, but the code is short enough to even copy/paste it into Pharo I guess. Since it is a fileout from VAST, you may need to tweak the categories for monticello and such.
>>>
>>> Please let me know if there are problems with the code, if you add new tests or find bugs. I'd like to add stuff back to my code then.
>>>
>>> Good luck,
>>>
>>> Joachim
>>>
>>>
>>>
>>> Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
>>>> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>>>>
>>>>> Hi Sven,
>>>>>
>>>>> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.
>>>> Great!
>>>>
>>>>> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>>>>>
>>>>> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)
>>>> Yes, please send some .st files.
>>>>
>>>>> Joachim
>>>>>
>>>>>
>>>>>
>>>>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>>>>> Hi Joachim,
>>>>>>
>>>>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>>>>
>>>>>>> Hi Sabine,
>>>>>>>
>>>>>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>>>>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>>>>>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>>>>>
>>>>>> How do you I get at the actual code ?
>>>>>>
>>>>>> When doing a download, I get a .dat file. How do I open that ?
>>>>>>
>>>>>> Sven
>>>>>>
>>>>>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>>>>
>>>>>>> HTH,
>>>>>>>
>>>>>>> Joachim
>>>>>>>
>>>>>>>
>>>>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>>>>> Hi Sven,
>>>>>>>>
>>>>>>>> this would be great.
>>>>>>>>
>>>>>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>>>>>
>>>>>>>> Example:
>>>>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Sabine
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>>>>
>>>>>>>>   Yes, indeed
>>>>>>>>
>>>>>>>>   QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>>>>
>>>>>>>>   It shouldn’t be too hard to implement, although it is a bit of a
>>>>>>>>   ‘human’ format rather than a technical one.
>>>>>>>>
>>>>>>>>   http://en.wikipedia.org/wiki/Quoted-printable
>>>>>>>>
>>>>>>>>   I’ll see what I can do.
>>>>>>>>
>>>>>>>>   Sven
>>>>>>>>
>>>>>>>>   On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>>>> <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I need this, too.
>>>>>>>>>
>>>>>>>>>
>>>>>>>> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>>>>>
>>>>>>>>
>>>>>>>>> The bug was closed after transferring it to fogbugs:
>>>>>>>>>
>>>>>>>>> https://pharo.fogbugz.com/f/cases/4825
>>>>>>>>>
>>>>>>>>> Sebastian, may I ask you, how did you solve this?
>>>>>>>>>
>>>>>>>>> regards
>>>>>>>>> Sabine
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> View this message in context:
>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>>>>   Nabble.com.
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>   If you reply to this email, your message will be added to the
>>>>>>>>   discussion below:
>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>>>>
>>>>>>>>   To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>>>>   email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>>>>   To unsubscribe from (MimeConverter forEncoding:
>>>>>>>>   'quoted-printable') subclass responsibility, click here.
>>>>>>>>   NAML
>>>>>>>> <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>>>>> --
>>>>>>> -----------------------------------------------------------------------
>>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>>
>>>>>
>>>>> --
>>>>> -----------------------------------------------------------------------
>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> -----------------------------------------------------------------------
>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>> Fliederweg 1                         http://www.objektfabrik.de
>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>
>>
>


QuotedPrintableCoder.st (7K) Download Attachment
QuotedPrintableCoderTest.st (9K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sven,
Sven,

sorry for my late reply. On the weekends, I try to be away from
Smalltalk. Sometimes I succeed, sometimes I don't ;-)

So first of all, thanks for porting the code and even adding those nice
comments. I like the way "my" code looks now ;-)

About the CRLF stuff: this is a complicated area, even if it looks so
simple. As I mentioned, VAST is not yet Unicode aware, so it adapts
itself to the current platform's line-end conversion. So what I did to
build tests fast was just add line breaks in literals in the test code
and let envy handle the rest. That is, of course, neither a nice coding
convention, nor a perfect solution. I don't know much about Pharo's
handling of line-end conventions of its host platform, so I cannot
comment on the correct way to do this in Pharo.

It is important in VAST to convert to the correct line-endings of the OS
in VAST, and for this VAST provides some pool constants:
CldtConstants::UNIXLineDelimiter and CldtConstants::WinLineDelimiter. As
I understand it, you Pharo guys don't like Pool Dictionaries very
deerly, so I guess there is another place to ask for this if needed.

So in the end, I cannot really judge if your changes are correct. You'd
have to test on both Win and Mac/Linux to see if your changes are
correct. For me, String>>crlf sounds wrong, because it it always returns
both cr and lf. If Pharo also uses the local line-end convention, this
would be wrong in Unix/Mac.

I hope this long version of "I have no idea" is helpful... ;-)

Joachim




Am 06.12.13 20:18, schrieb Sven Van Caekenberghe:

> Hi Joachim,
>
> I loaded/copied your code into Pharo 3.0 and made the necessary changes, as well as some simplifications, to make everything work. See the attached fileouts.
>
> The tests were almost immediately green.
>
> I have one question though, I had to change two tests to make them work:
>
> #testDecodeCRLF
>
>    self
>     assert: (coder decode: 'This is the first line=0D=0A and this is the second')
>     equals: 'This is the first line', String crlf, ' and this is the second’
>
> You originally had a simple line break in the method’s string literal. But that results in a CR in Pharo. I added an explicit CRLF.
>
> I had to make similar changes to #testEncodeSoftLinebreak.
>
> Is that OK or not ?  What do you think ?
>
> Sven
>
>
>
>  
>
>
>
> On 06 Dec 2013, at 12:52, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> Hi Joachim,
>>
>> The code is perfectly readable, including the German (which I can read/understand more or less, speaking/writing is quite bad though), thanks a lot. I will try to port it later today or this evening.
>>
>> Sven
>>
>> On 06 Dec 2013, at 12:26, [hidden email] wrote:
>>
>>> Hi Sven,
>>>
>>> I just see there will be some problems with the test Strings in Pharo. VAST is not Unicode aware yet, so the fileout of german umlauts and such will very likely be wrong when pasting into Pharo.
>>> I am happy to send you corrections for the decoded strings in the test code if your German doesn't suffice. Just tell me which sentences are imported wrong into Pharo...
>>>
>>> I have never tested any other special characters than German ones.
>>>
>>> Joachim
>>>
>>>
>>> Am 06.12.13 12:14, schrieb [hidden email]:
>>>> Hi Sven,
>>>>
>>>> here you are.
>>>> It's possible you get into minor troubles parsing the files, but the code is short enough to even copy/paste it into Pharo I guess. Since it is a fileout from VAST, you may need to tweak the categories for monticello and such.
>>>>
>>>> Please let me know if there are problems with the code, if you add new tests or find bugs. I'd like to add stuff back to my code then.
>>>>
>>>> Good luck,
>>>>
>>>> Joachim
>>>>
>>>>
>>>>
>>>> Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
>>>>> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>>>>>
>>>>>> Hi Sven,
>>>>>>
>>>>>> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.
>>>>> Great!
>>>>>
>>>>>> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>>>>>>
>>>>>> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)
>>>>> Yes, please send some .st files.
>>>>>
>>>>>> Joachim
>>>>>>
>>>>>>
>>>>>>
>>>>>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>>>>>> Hi Joachim,
>>>>>>>
>>>>>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>>>>>
>>>>>>>> Hi Sabine,
>>>>>>>>
>>>>>>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>>>>>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>>>>>>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>>>>>>
>>>>>>> How do you I get at the actual code ?
>>>>>>>
>>>>>>> When doing a download, I get a .dat file. How do I open that ?
>>>>>>>
>>>>>>> Sven
>>>>>>>
>>>>>>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>>>>>
>>>>>>>> HTH,
>>>>>>>>
>>>>>>>> Joachim
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>>>>>> Hi Sven,
>>>>>>>>>
>>>>>>>>> this would be great.
>>>>>>>>>
>>>>>>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>>>>>>
>>>>>>>>> Example:
>>>>>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> Sabine
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>>>>>
>>>>>>>>>    Yes, indeed
>>>>>>>>>
>>>>>>>>>    QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>>>>>
>>>>>>>>>    It shouldn’t be too hard to implement, although it is a bit of a
>>>>>>>>>    ‘human’ format rather than a technical one.
>>>>>>>>>
>>>>>>>>>    http://en.wikipedia.org/wiki/Quoted-printable
>>>>>>>>>
>>>>>>>>>    I’ll see what I can do.
>>>>>>>>>
>>>>>>>>>    Sven
>>>>>>>>>
>>>>>>>>>    On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>>>>> <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I need this, too.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>>>>>> The bug was closed after transferring it to fogbugs:
>>>>>>>>>>
>>>>>>>>>> https://pharo.fogbugz.com/f/cases/4825
>>>>>>>>>>
>>>>>>>>>> Sebastian, may I ask you, how did you solve this?
>>>>>>>>>>
>>>>>>>>>> regards
>>>>>>>>>> Sabine
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> View this message in context:
>>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>>>>>    Nabble.com.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>>    If you reply to this email, your message will be added to the
>>>>>>>>>    discussion below:
>>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>>>>>
>>>>>>>>>    To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>>>>>    email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>>>>>    To unsubscribe from (MimeConverter forEncoding:
>>>>>>>>>    'quoted-printable') subclass responsibility, click here.
>>>>>>>>>    NAML
>>>>>>>>> <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>>>>>> --
>>>>>>>> -----------------------------------------------------------------------
>>>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>> --
>>>>>> -----------------------------------------------------------------------
>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>> --
>>> -----------------------------------------------------------------------
>>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>>> Fliederweg 1                         http://www.objektfabrik.de
>>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>
>>>


--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
Joachim,

On 08 Dec 2013, at 10:06, [hidden email] wrote:

> Hi Sven,
> Sven,
>
> sorry for my late reply. On the weekends, I try to be away from Smalltalk. Sometimes I succeed, sometimes I don't ;-)

No problem!

> So first of all, thanks for porting the code and even adding those nice comments. I like the way "my" code looks now ;-)

The code was quite readable and clean to begin with !

> About the CRLF stuff: this is a complicated area, even if it looks so simple. As I mentioned, VAST is not yet Unicode aware, so it adapts itself to the current platform's line-end conversion. So what I did to build tests fast was just add line breaks in literals in the test code and let envy handle the rest. That is, of course, neither a nice coding convention, nor a perfect solution. I don't know much about Pharo's handling of line-end conventions of its host platform, so I cannot comment on the correct way to do this in Pharo.
>
> It is important in VAST to convert to the correct line-endings of the OS in VAST, and for this VAST provides some pool constants: CldtConstants::UNIXLineDelimiter and CldtConstants::WinLineDelimiter. As I understand it, you Pharo guys don't like Pool Dictionaries very deerly, so I guess there is another place to ask for this if needed.
>
> So in the end, I cannot really judge if your changes are correct. You'd have to test on both Win and Mac/Linux to see if your changes are correct. For me, String>>crlf sounds wrong, because it it always returns both cr and lf. If Pharo also uses the local line-end convention, this would be wrong in Unix/Mac.
>
> I hope this long version of "I have no idea" is helpful... ;-)
>
> Joachim

Inside a Pharo image, CR is the line end on all platforms (Windows, Mac, Linux). Going to the outside world (files, sockets, clipboard), there are options for conversion or automatic conversion, or none at all. When reading lines, most code can handle all 3 conventions transparently.

I modified the code to assume CR as Pharo platform standard line end convention when decoding, when encoding any line end convention works. I intend to make the actual line end convention a parameter, defaulting to CR. I added an error when the char code is > 255. I added/changed a couple of tests. Please have a look.  

Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.

Sven



> Am 06.12.13 20:18, schrieb Sven Van Caekenberghe:
>> Hi Joachim,
>>
>> I loaded/copied your code into Pharo 3.0 and made the necessary changes, as well as some simplifications, to make everything work. See the attached fileouts.
>>
>> The tests were almost immediately green.
>>
>> I have one question though, I had to change two tests to make them work:
>>
>> #testDecodeCRLF
>>
>>   self
>>    assert: (coder decode: 'This is the first line=0D=0A and this is the second')
>>    equals: 'This is the first line', String crlf, ' and this is the second’
>>
>> You originally had a simple line break in the method’s string literal. But that results in a CR in Pharo. I added an explicit CRLF.
>>
>> I had to make similar changes to #testEncodeSoftLinebreak.
>>
>> Is that OK or not ?  What do you think ?
>>
>> Sven
>>
>>
>>
>>  
>>
>>
>> On 06 Dec 2013, at 12:52, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>>> Hi Joachim,
>>>
>>> The code is perfectly readable, including the German (which I can read/understand more or less, speaking/writing is quite bad though), thanks a lot. I will try to port it later today or this evening.
>>>
>>> Sven
>>>
>>> On 06 Dec 2013, at 12:26, [hidden email] wrote:
>>>
>>>> Hi Sven,
>>>>
>>>> I just see there will be some problems with the test Strings in Pharo. VAST is not Unicode aware yet, so the fileout of german umlauts and such will very likely be wrong when pasting into Pharo.
>>>> I am happy to send you corrections for the decoded strings in the test code if your German doesn't suffice. Just tell me which sentences are imported wrong into Pharo...
>>>>
>>>> I have never tested any other special characters than German ones.
>>>>
>>>> Joachim
>>>>
>>>>
>>>> Am 06.12.13 12:14, schrieb [hidden email]:
>>>>> Hi Sven,
>>>>>
>>>>> here you are.
>>>>> It's possible you get into minor troubles parsing the files, but the code is short enough to even copy/paste it into Pharo I guess. Since it is a fileout from VAST, you may need to tweak the categories for monticello and such.
>>>>>
>>>>> Please let me know if there are problems with the code, if you add new tests or find bugs. I'd like to add stuff back to my code then.
>>>>>
>>>>> Good luck,
>>>>>
>>>>> Joachim
>>>>>
>>>>>
>>>>>
>>>>> Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
>>>>>> On 06 Dec 2013, at 12:04, [hidden email] wrote:
>>>>>>
>>>>>>> Hi Sven,
>>>>>>>
>>>>>>> Of course I don't mind. I'll be happy if you find it useful enough to use it in Pharo.
>>>>>> Great!
>>>>>>
>>>>>>> The .dat is VAST's proprietary export format for code. So you'd have to install VAST to get it.
>>>>>>>
>>>>>>> I am not a Pharo contributor yet, so I will see if I can send you a fileout of the code that should beasier to import into Pharo. I know this is stupid, but I never worried about the license of such mini-contributions. So if you want, it's MIT ;-)
>>>>>> Yes, please send some .st files.
>>>>>>
>>>>>>> Joachim
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
>>>>>>>> Hi Joachim,
>>>>>>>>
>>>>>>>> On 06 Dec 2013, at 11:22, [hidden email] wrote:
>>>>>>>>
>>>>>>>>> Hi Sabine,
>>>>>>>>>
>>>>>>>>> this is not of immediate help for you, but I once wrote a QuotedPrintableEncode for VA Smalltalk. It is in productive use and should handle both encoding and decoding just fine.
>>>>>>>>> You can find it on vastgoodies.com and I am sure it is not hard to port to Pharo.
>>>>>>>> So I guess you are OK with me looking at / porting your code ? Is it MIT licensed or compatible ? Are you already a signed up Pharo contributor ?
>>>>>>>>
>>>>>>>> How do you I get at the actual code ?
>>>>>>>>
>>>>>>>> When doing a download, I get a .dat file. How do I open that ?
>>>>>>>>
>>>>>>>> Sven
>>>>>>>>
>>>>>>>>> More details: http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
>>>>>>>>>
>>>>>>>>> HTH,
>>>>>>>>>
>>>>>>>>> Joachim
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 06.12.13 11:11, schrieb Sabine Knöfel:
>>>>>>>>>> Hi Sven,
>>>>>>>>>>
>>>>>>>>>> this would be great.
>>>>>>>>>>
>>>>>>>>>> I need it for sending mails and some mail reader, e.g. Thunderbird on Mac (Thank you Joachim for reporting this bug :-) ) need this in the subject if there are special signs in it.
>>>>>>>>>>
>>>>>>>>>> Example:
>>>>>>>>>> Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> Sabine
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email] </user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
>>>>>>>>>>
>>>>>>>>>>   Yes, indeed
>>>>>>>>>>
>>>>>>>>>>   QuotedPrintableMimeConverter>>#mimeEncode is missing.
>>>>>>>>>>
>>>>>>>>>>   It shouldn’t be too hard to implement, although it is a bit of a
>>>>>>>>>>   ‘human’ format rather than a technical one.
>>>>>>>>>>
>>>>>>>>>>   http://en.wikipedia.org/wiki/Quoted-printable
>>>>>>>>>>
>>>>>>>>>>   I’ll see what I can do.
>>>>>>>>>>
>>>>>>>>>>   Sven
>>>>>>>>>>
>>>>>>>>>>   On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
>>>>>>>>>> <http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I need this, too.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
>>>>>>>>>>> The bug was closed after transferring it to fogbugs:
>>>>>>>>>>>
>>>>>>>>>>> https://pharo.fogbugz.com/f/cases/4825
>>>>>>>>>>>
>>>>>>>>>>> Sebastian, may I ask you, how did you solve this?
>>>>>>>>>>>
>>>>>>>>>>> regards
>>>>>>>>>>> Sabine
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> View this message in context:
>>>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
>>>>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive at
>>>>>>>>>>   Nabble.com.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>>>   If you reply to this email, your message will be added to the
>>>>>>>>>>   discussion below:
>>>>>>>>>> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
>>>>>>>>>>
>>>>>>>>>>   To start a new topic under Pharo Smalltalk Users, email [hidden
>>>>>>>>>>   email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
>>>>>>>>>>   To unsubscribe from (MimeConverter forEncoding:
>>>>>>>>>>   'quoted-printable') subclass responsibility, click here.
>>>>>>>>>>   NAML
>>>>>>>>>> <http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>>> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility <http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
>>>>>>>>>> Sent from the Pharo Smalltalk Users mailing list archive <http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
>>>>>>>>> --
>>>>>>>>> -----------------------------------------------------------------------
>>>>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>>> --
>>>>>>> -----------------------------------------------------------------------
>>>>>>> Objektfabrik Joachim Tuchel mailto:[hidden email]
>>>>>>> Fliederweg 1 http://www.objektfabrik.de
>>>>>>> D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
>>>>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> -----------------------------------------------------------------------
>>>> Objektfabrik Joachim Tuchel          mailto:[hidden email]
>>>> Fliederweg 1                         http://www.objektfabrik.de
>>>> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
>>>> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>>>>
>>>>
>
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>
>


--
Sven Van Caekenberghe
Proudly supporting Pharo
http://pharo.org
http://association.pharo.org
http://consortium.pharo.org





QuotedPrintableCoder.st (7K) Download Attachment
QuotedPrintableCoderTest.st (14K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2

On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:

> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.

Done:

  https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete 

RESOLVED

Slice in 3.0 inbox:

===
Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 8 December 2013, 11:45:09.148454 pm
UUID: af015099-e48b-47f5-9553-840fca62d8e2
Ancestors:
Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92

A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.

Note that the older code lacked the encoding part and had no tests at all.
===

Sven
Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

jtuchel
Hi Sven,

thanks for porting this and making it available. I will re-integrate
your improvements in the VAST code if that's okay with you.

Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))

Joachim


Am 08.12.13 23:49, schrieb Sven Van Caekenberghe:

> On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.
> Done:
>
>    https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
>
> RESOLVED
>
> Slice in 3.0 inbox:
>
> ===
> Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
> Author: SvenVanCaekenberghe
> Time: 8 December 2013, 11:45:09.148454 pm
> UUID: af015099-e48b-47f5-9553-840fca62d8e2
> Ancestors:
> Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
>
> A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
>
> Note that the older code lacked the encoding part and had no tests at all.
> ===
>
> Sven


--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sabine Manaa
Hi Joachim, hi Sven,

thank yor very much for your work! I am looking forward to use Pharo 3.0 next year. :-)

Sabine


On Mon, Dec 9, 2013 at 11:11 AM, jtuchel [via Smalltalk] <[hidden email]> wrote:
Hi Sven,

thanks for porting this and making it available. I will re-integrate
your improvements in the VAST code if that's okay with you.

Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))

Joachim


Am <a href="tel:08.12.13%2023" value="+498121323" target="_blank">08.12.13 23:49, schrieb Sven Van Caekenberghe:

> On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:
>
>> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.
> Done:
>
>    https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
>

> RESOLVED
>
> Slice in 3.0 inbox:
>
> ===
> Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
> Author: SvenVanCaekenberghe
> Time: 8 December 2013, 11:45:<a href="tel:09.148454" value="+499148454" target="_blank">09.148454 pm
> UUID: af015099-e48b-47f5-9553-840fca62d8e2
> Ancestors:
> Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
>
> A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
>
> Note that the older code lacked the encoding part and had no tests at all.
> ===
>
> Sven

--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel          mailto:[hidden email]
Fliederweg 1                         http://www.objektfabrik.de
D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
Telefon: <a href="tel:%2B49%207141%2056%2010%2086%200" value="+4971415610860" target="_blank">+49 7141 56 10 86 0         Fax: <a href="tel:%2B49%207141%2056%2010%2086%201" value="+4971415610861" target="_blank">+49 7141 56 10 86 1





If you reply to this email, your message will be added to the discussion below:
http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728698.html
To start a new topic under Pharo Smalltalk Users, email [hidden email]
To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
In reply to this post by jtuchel
Joachim,

On 09 Dec 2013, at 11:09, [hidden email] wrote:

> Hi Sven,
>
> thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you.

Yes, please do, that is the least we could do back. All Pharo code is MIT licensed.

> Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))

And the code is already part of Pharo 3.0 (it went through the whole process with automatic validation by the CI system and finally integration):

One way to see the changes is via github

  https://github.com/pharo-project/pharo-core/commit/76bf0c7bf67d5ce70f6b704375f7fa37172061ef

So if you download Pharo 3.0 today should get a version 30633 or later. You’ll find your code in QuotedPrintableMimeConverter[Tests].

Thanks again !

Regards,

Sven

> Joachim
>
>
> Am 08.12.13 23:49, schrieb Sven Van Caekenberghe:
>> On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>>> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.
>> Done:
>>
>>   https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
>>
>> RESOLVED
>>
>> Slice in 3.0 inbox:
>>
>> ===
>> Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
>> Author: SvenVanCaekenberghe
>> Time: 8 December 2013, 11:45:09.148454 pm
>> UUID: af015099-e48b-47f5-9553-840fca62d8e2
>> Ancestors:
>> Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
>>
>> A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
>>
>> Note that the older code lacked the encoding part and had no tests at all.
>> ===
>>
>> Sven
>
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: +49 7141 56 10 86 0         Fax: +49 7141 56 10 86 1
>
>


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sven Van Caekenberghe-2
In reply to this post by Sabine Manaa

On 09 Dec 2013, at 12:34, Sabine Knöfel <[hidden email]> wrote:

> Hi Joachim, hi Sven,
>
> thank yor very much for your work! I am looking forward to use Pharo 3.0 next year. :-)

If you need this code earlier, I see no reason why you should not be able to file out the QuotedPrintableMimeConverter[Tests] classes from 3.0 and file them in in 2.0 - there are no dependencies as far as I can see.

Maybe this could even be officially back ported to 2.0.

> Sabine
>
>
> On Mon, Dec 9, 2013 at 11:11 AM, jtuchel [via Smalltalk] <[hidden email]> wrote:
> Hi Sven,
>
> thanks for porting this and making it available. I will re-integrate
> your improvements in the VAST code if that's okay with you.
>
> Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))
>
> Joachim
>
>
> Am <a href="tel:08.12.13%2023" value="+498121323" target="_blank">08.12.13 23:49, schrieb Sven Van Caekenberghe:
>
> > On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:
> >
> >> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.
> > Done:
> >
> >    https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
> >
>
> > RESOLVED
> >
> > Slice in 3.0 inbox:
> >
> > ===
> > Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
> > Author: SvenVanCaekenberghe
> > Time: 8 December 2013, 11:45:<a href="tel:09.148454" value="+499148454" target="_blank">09.148454 pm
> > UUID: af015099-e48b-47f5-9553-840fca62d8e2
> > Ancestors:
> > Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
> >
> > A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
> >
> > Note that the older code lacked the encoding part and had no tests at all.
> > ===
> >
> > Sven
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: <a href="tel:%2B49%207141%2056%2010%2086%200" value="+4971415610860" target="_blank">+49 7141 56 10 86 0         Fax: <a href="tel:%2B49%207141%2056%2010%2086%201" value="+4971415610861" target="_blank">+49 7141 56 10 86 1
>
>
>
>
> If you reply to this email, your message will be added to the discussion below:
> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728698.html
> To start a new topic under Pharo Smalltalk Users, email [hidden email]
> To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here.
> NAML
>
>
> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.


Reply | Threaded
Open this post in threaded view
|

Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility

Sabine Manaa
Hi Sven,

I read that Pharo 30 will be released in March 2013, so it is absolutely sufficient for me to wait a few months, I want to concentrate on features I really really need to go online officially. This will also take time til Pharo30....

Sabine


On Mon, Dec 9, 2013 at 12:41 PM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email]> wrote:

On 09 Dec 2013, at 12:34, Sabine Knöfel <[hidden email]> wrote:

> Hi Joachim, hi Sven,
>
> thank yor very much for your work! I am looking forward to use Pharo 3.0 next year. :-)

If you need this code earlier, I see no reason why you should not be able to file out the QuotedPrintableMimeConverter[Tests] classes from 3.0 and file them in in 2.0 - there are no dependencies as far as I can see.

Maybe this could even be officially back ported to 2.0.

> Sabine
>

>
> On Mon, Dec 9, 2013 at 11:11 AM, jtuchel [via Smalltalk] <[hidden email]> wrote:
> Hi Sven,
>
> thanks for porting this and making it available. I will re-integrate
> your improvements in the VAST code if that's okay with you.
>
> Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))
>
> Joachim
>
>
> Am <a href="tel:08.12.13%2023" value="<a href="tel:%2B498121323" value="+498121323" target="_blank">+498121323" target="_blank"><a href="tel:08.12.13%2023" value="+498121323" target="_blank">08.12.13 23:49, schrieb Sven Van Caekenberghe:
>
> > On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <[hidden email]> wrote:
> >
> >> Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good.
> > Done:
> >
> >    https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
> >
>
> > RESOLVED
> >
> > Slice in 3.0 inbox:
> >
> > ===
> > Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1
> > Author: SvenVanCaekenberghe
> > Time: 8 December 2013, 11:45:<a href="tel:<a href="tel:09.148454" value="+499148454" target="_blank">09.148454" value="<a href="tel:%2B499148454" value="+499148454" target="_blank">+499148454" target="_blank"><a href="tel:09.148454" value="+499148454" target="_blank">09.148454 pm
> > UUID: af015099-e48b-47f5-9553-840fca62d8e2

> > Ancestors:
> > Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
> >
> > A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
> >
> > Note that the older code lacked the encoding part and had no tests at all.
> > ===
> >
> > Sven
>
> --
> -----------------------------------------------------------------------
> Objektfabrik Joachim Tuchel          mailto:[hidden email]
> Fliederweg 1                         http://www.objektfabrik.de
> D-71640 Ludwigsburg                  http://joachimtuchel.wordpress.com
> Telefon: <a href="tel:%2B49%207141%2056%2010%2086%200" value="<a href="tel:%2B4971415610860" value="+4971415610860" target="_blank">+4971415610860" target="_blank"><a href="tel:%2B49%207141%2056%2010%2086%200" value="+4971415610860" target="_blank">+49 7141 56 10 86 0         Fax: <a href="tel:%2B49%207141%2056%2010%2086%201" value="+4971415610861" target="_blank">+49 7141 56 10 86 1
>
>
>
>
> If you reply to this email, your message will be added to the discussion below:
> http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728698.html
> To start a new topic under Pharo Smalltalk Users, email [hidden email]
> To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here.
> NAML
>
>
> View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
> Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.





If you reply to this email, your message will be added to the discussion below:
http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728723.html
To start a new topic under Pharo Smalltalk Users, email [hidden email]
To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here.
NAML