Minor DBConnection bug / suggestion for improvement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Minor DBConnection bug / suggestion for improvement

David Gorisek-5
If there is an error during DBConnection>>exec: the method does not
automatically free its DBStatement handle, neither does it return it to the
sender.

This means it will wait for the finalization to do the job of releasing the
handle.

If there are many DB errors it can happen that the image consumes all
available handles and then nothing works anymore.

I think it would be better to have #ifCurtailed: around this method which
would then clean up the handle right away in case of a DBError.

Best regards,

David


Reply | Threaded
Open this post in threaded view
|

Re: Minor DBConnection bug / suggestion for improvement

Andy Bower-2
David,

> If there is an error during DBConnection>>exec: the method does not
> automatically free its DBStatement handle, neither does it return it to
the
> sender.
>
> This means it will wait for the finalization to do the job of releasing
the
> handle.
>
> If there are many DB errors it can happen that the image consumes all
> available handles and then nothing works anymore.
>
> I think it would be better to have #ifCurtailed: around this method which
> would then clean up the handle right away in case of a DBError.

Thanks.. I've recorded this as issue number #1335.

Best Regards

Andy Bower
Dolphin Support