Minor bugs

I seem to be in the mood for finding trivial bugs recently.  Here's a couple
more:

--------------------

The various SearchPolicy "singletons" aren't.  E.g.

    IdentitySearchPolicy allInstances size.

answers 31 in my image.

--------------------

The CHB, in its categories "mode" doesn't reflect changes a method's categories
made from another CHB.
I think that MethodBrowser>>onMethodCategorized: should run the changed method
through its filter block, since the filter may be based (partly) on categories.
Something like:

onMethodCategorized: aCompiledMethod
   "Private - The development system has re-categorized aCompiledMethod, update
it if
    in the receiver's list of methods."

   (filter value: aCompiledMethod)
      ifTrue: [self model updateItem: aCompiledMethod ifAbsent: [self model
add: aCompiledMethod]]
      ifFalse: [self model remove: aCompiledMethod ifAbsent: []]

(Of course, this bug affects all other method browsers too, which is why I care
about it)
--------------------

    -- chris

Chris

"Chris Uppal" <[hidden email]> wrote in message
news:3ddcaf8a$0$126$[hidden email]...
> I seem to be in the mood for finding trivial bugs recently.  Here's a
couple
> more:
>
> --------------------
>
> The various SearchPolicy "singletons" aren't.  E.g.
>
>     IdentitySearchPolicy allInstances size.
>
> answers 31 in my image.

This is because the classes aren't arranging to use the STBSingletonProxy on
file out, and hence unique copies are created on file in (#1079). You must
have a lot of windows open to have that many though :-).


> --------------------
>
> The CHB, in its categories "mode" doesn't reflect changes a method's
categories
> made from another CHB.
> I think that MethodBrowser>>onMethodCategorized: should run the changed
method
> through its filter block, since the filter may be based (partly) on
categories.
>....

Do you know, I encountered that very thing this morning. I was checking for
unclassified methods by browsing the 'unclassified' category, and noticed
that the methods didn't drop out of the browser when classified. Thanks for
the fix though (#1080).

Regards

Blair

Blair,

> This is because the classes aren't arranging to use the STBSingletonProxy on
> file out, and hence unique copies are created on file in (#1079). You must
> have a lot of windows open to have that many though :-).

Hmm...

    Shell allSubinstances size.  --> 4
    IdentitySearchPolicy allInstances size. --> 29

Aha!  Found I had 4 dead Views, killed 'em, now have only 7
IdentitySearchPolicies.  Cheers!

    -- chris