Smalltalk › Frameworks & Tools › GLORP

Missing GAMysqlDriver>>queryEncoding

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Laurent L

Missing GAMysqlDriver>>queryEncoding

Hi,

while using Garage Glorp in Pharo 6.1 I had a DNU in

PharoDatabaseAccessor>>encoding
^self connection queryEncoding

So I've added GAMysqlDriver>>queryEncoding to fix. See: http://smalltalkhub.com/#!/~LaurentLaffont/Garage/versions/Garage-Mysql-LaurentLaffont.25

I'm not sure if the fix is right because GAMysqlDriver also implements #encoding.

Anyway, is there a way to have pull request in SmalltalkHub like GitHub to submit fixes ?

Regards,

Laurent Laffont

--
You received this message because you are subscribed to the Google Groups "glorp-group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/glorp-group.
For more options, visit https://groups.google.com/d/optout.

Herby Vojčík

Re: Missing GAMysqlDriver>>queryEncoding

Laurent L wrote:
> Hi,
>
> while using Garage Glorp in Pharo 6.1 I had a DNU in
>
> PharoDatabaseAccessor>>encoding
> ^self connection queryEncoding

I had queryEncoding problems w/ garage as well. I was told Garage is not
supported any more and in Pharo 6 you should use UDBC drivers.

Herby

> So I've added GAMysqlDriver>>queryEncoding to fix. See:
> http://smalltalkhub.com/#!/~LaurentLaffont/Garage/versions/Garage-Mysql-LaurentLaffont.25
>
> I'm not sure if the fix is right because GAMysqlDriver also implements
> #encoding.
>
> Anyway, is there a way to have pull request in SmalltalkHub like GitHub
> to submit fixes ?
>
> Regards,
>
> Laurent Laffont
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "glorp-group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [hidden email]
> <mailto:[hidden email]>.
> To post to this group, send email to [hidden email]
> <mailto:[hidden email]>.
> Visit this group at https://groups.google.com/group/glorp-group.
> For more options, visit https://groups.google.com/d/optout.