Missing info in the change log

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Missing info in the change log

hernan.wilkinson
Hi,
 we realized (after pharo crash) that there are some code changes that are not save to the changes file. Most of the are related to dynamically defining the "change".
 For example:
   1) when saving a method that references a non created class and after creating the class selecting "Define new class"
   2) when saving a method that references a non declared instance variable and selecting "declare instance"
   3) categorizing methods using drag and drop
 
 I could not find a reported bug on this issues... does anybody know if they are reported? 

Thanks
Hernan.

 

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Missing info in the change log

Stéphane Ducasse

On May 15, 2009, at 12:04 AM, Hernan Wilkinson wrote:

> Hi,
>  we realized (after pharo crash) that there are some code changes  
> that are not save to the changes file. Most of the are related to  
> dynamically defining the "change".

Yes some are missing and the class definition in cs would be really  
welcomed because doit for classdef is annoying.
Now when you see the state of the fileout code you want to run away.  
One of these days we will have to fix that.

>  For example:
>    1) when saving a method that references a non created class and  
> after creating the class selecting "Define new class"

strange
>    2) when saving a method that references a non declared instance  
> variable and selecting "declare instance"
>    3) categorizing methods using drag and drop

that strange because I imagine that normally catgeory changes are  
captures and are funnel to a category and that this raises the  
systemchangeNotifier.
So may be the browser short cuts some of the call
>
>  I could not find a reported bug on this issues... does anybody know  
> if they are reported?

I remember that there is one issue but if you can complete it with  
precise information this will help fixing it.

Stef




>
> Thanks
> Hernan.
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Missing info in the change log

hernan.wilkinson


On Fri, May 15, 2009 at 3:20 AM, Stéphane Ducasse <[hidden email]> wrote:

On May 15, 2009, at 12:04 AM, Hernan Wilkinson wrote:

> Hi,
>  we realized (after pharo crash) that there are some code changes
> that are not save to the changes file. Most of the are related to
> dynamically defining the "change".

Yes some are missing and the class definition in cs would be really
welcomed because doit for classdef is annoying.

I agree, but it has one downsize. Juan Manuel did that on Cuis, but then you can not port code from it to Pharo/Squeak. 
Of course the answer could be "who cares", but just raising an issue. Maybe having an option to turn on/off would be better until all use the same format..
 

Now when you see the state of the fileout code you want to run away.
One of these days we will have to fix that.

jeje, I'll see if I can help.
 

>  For example:
>    1) when saving a method that references a non created class and
> after creating the class selecting "Define new class"

strange
>    2) when saving a method that references a non declared instance
> variable and selecting "declare instance"
>    3) categorizing methods using drag and drop

that strange because I imagine that normally catgeory changes are
captures and are funnel to a category and that this raises the
systemchangeNotifier.
So may be the browser short cuts some of the call
>
>  I could not find a reported bug on this issues... does anybody know
> if they are reported?

I remember that there is one issue but if you can complete it with
precise information this will help fixing it.

Ok, I will look again for the bug but if I can not find it I'll open a new one

Thanks!
Hernan 


Stef




>
> Thanks
> Hernan.
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Missing info in the change log

Stéphane Ducasse
> > Hi,
> >  we realized (after pharo crash) that there are some code changes
> > that are not save to the changes file. Most of the are related to
> > dynamically defining the "change".
>
> Yes some are missing and the class definition in cs would be really
> welcomed because doit for classdef is annoying.
>
> I agree, but it has one downsize. Juan Manuel did that on Cuis, but  
> then you can not port code from it to Pharo/Squeak.
> Of course the answer could be "who cares", but just raising an  
> issue. Maybe having an option to turn on/off would be better until  
> all use the same format..

I know I checked Cuis.
I think that this is should be done so that we can load code
from pharo in other smalltalk.

In general we should clean or rewrite the fileout code.


> jeje, I'll see if I can help.

I would suggest to think in terms of a complete new project to fileout  
code
because when I see that code I often waht to run away.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Missing info in the change log

Mariano Martinez Peck
This problem has also been reported in squeak today. See this ticket:

http://bugs.squeak.org/view.php?id=7354

Cheers,

Mariano

On Fri, May 15, 2009 at 4:21 PM, Stéphane Ducasse <[hidden email]> wrote:
> > Hi,
> >  we realized (after pharo crash) that there are some code changes
> > that are not save to the changes file. Most of the are related to
> > dynamically defining the "change".
>
> Yes some are missing and the class definition in cs would be really
> welcomed because doit for classdef is annoying.
>
> I agree, but it has one downsize. Juan Manuel did that on Cuis, but
> then you can not port code from it to Pharo/Squeak.
> Of course the answer could be "who cares", but just raising an
> issue. Maybe having an option to turn on/off would be better until
> all use the same format..

I know I checked Cuis.
I think that this is should be done so that we can load code
from pharo in other smalltalk.

In general we should clean or rewrite the fileout code.


> jeje, I'll see if I can help.

I would suggest to think in terms of a complete new project to fileout
code
because when I see that code I often waht to run away.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project