Smalltalk › Pharo › Pharo Smalltalk Developers

Missing refresh after method definition

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

14 messages Options

Stephane Ducasse-3

Missing refresh after method definition

I often defined method and let the system guess and propose the addition to new instance variables and (they are red) but once I created the instance variables they should not be red anymore. Now nautilus does not refresh the pane and I end up having a warning about a non defined instance which is not one.

Did you see this glitch?

Stef

Ben Coman

Re: Missing refresh after method definition

haven't noticed it so far.
btw, which build are you on?
cheers -ben

On Tue, Mar 28, 2017 at 6:39 PM, Stephane Ducasse
<[hidden email]> wrote:

> Hi
>
> I often defined method and let the system guess and propose the addition to
> new instance variables and (they are red) but once I created the instance
> variables they should not be red anymore. Now nautilus does not refresh the
> pane and I end up having a warning about a non defined instance which is not
> one.
> Did you see this glitch?
>
> Stef

philippeback

Re: Missing refresh after method definition

In reply to this post by Stephane Ducasse-3

Yes I do see that.

The system also does not removes the unused tempvars as it used to do in the past, they are now marked yellow:

Phil

On Tue, Mar 28, 2017 at 12:39 PM, Stephane Ducasse <[hidden email]> wrote:

Hi

I often defined method and let the system guess and propose the addition to new instance variables and (they are red) but once I created the instance variables they should not be red anymore. Now nautilus does not refresh the pane and I end up having a warning about a non defined instance which is not one.
Did you see this glitch?

Stef

Denis Kudriashov

Re: Missing refresh after method definition

2017-03-28 14:23 GMT+02:00 [hidden email] <[hidden email]>:

Yes I do see that.

The system also does not removes the unused tempvars as it used to do in the past, they are now marked yellow:

It is feature :)

CyrilFerlicot

Re: Missing refresh after method definition

In reply to this post by Stephane Ducasse-3

On 28/03/2017 12:39, Stephane Ducasse wrote:

> Hi
>
> I often defined method and let the system guess and propose the addition
> to new instance variables and (they are red) but once I created the
> instance variables they should not be red anymore. Now nautilus does not
> refresh the pane and I end up having a warning about a non defined
> instance which is not one.
> Did you see this glitch?
>
> Stef

I opened an issue last year:
https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor

--
Cyril Ferlicot

http://www.synectique.eu

2 rue Jacques Prévert 01,
59650 Villeneuve d'ascq France

signature.asc (817 bytes) Download Attachment

philippeback

Re: Missing refresh after method definition

In reply to this post by Denis Kudriashov

I want a "remove all of the yellowish tempvars from this method" refactoring then.

I am finding myself clicking around and deleting these things too many times for my taste.

Phil

On Tue, Mar 28, 2017 at 2:30 PM, Denis Kudriashov <[hidden email]> wrote:

2017-03-28 14:23 GMT+02:00 [hidden email] <[hidden email]>:
Yes I do see that.

The system also does not removes the unused tempvars as it used to do in the past, they are now marked yellow:

It is feature :)

Thierry Goubier

Re: Missing refresh after method definition

In reply to this post by CyrilFerlicot

Le 28/03/2017 à 14:31, Cyril Ferlicot D. a écrit :

> On 28/03/2017 12:39, Stephane Ducasse wrote:
>> Hi
>>
>> I often defined method and let the system guess and propose the addition
>> to new instance variables and (they are red) but once I created the
>> instance variables they should not be red anymore. Now nautilus does not
>> refresh the pane and I end up having a warning about a non defined
>> instance which is not one.
>> Did you see this glitch?
>>
>> Stef
>
> I opened an issue last year:
> https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor

Good point.

Need to refresh code view on a class method (and subclass methods) when
class reorganized event is sent... take care of not removing unsaved
changes then. Maybe toggling off and on syntax highlighting may be enough.

Thierry

Denis Kudriashov

Re: Missing refresh after method definition

In reply to this post by CyrilFerlicot

2017-03-28 14:31 GMT+02:00 Cyril Ferlicot D. <[hidden email]>:

I opened an issue last year:
https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor

I look at it and could not reproduce

Denis Kudriashov

Re: Missing refresh after method definition

In reply to this post by philippeback

2017-03-28 14:38 GMT+02:00 [hidden email] <[hidden email]>:

I want a "remove all of the yellowish tempvars from this method" refactoring then.

Generally we need more intelligence on critic icons. Now they not allow "fix it" action.

philippeback

Re: Missing refresh after method definition

In reply to this post by Thierry Goubier

On Tue, Mar 28, 2017 at 2:44 PM, Thierry Goubier <[hidden email]> wrote:

Le 28/03/2017 à 14:31, Cyril Ferlicot D. a écrit :

On 28/03/2017 12:39, Stephane Ducasse wrote:

Hi

I often defined method and let the system guess and propose the addition
to new instance variables and (they are red) but once I created the
instance variables they should not be red anymore. Now nautilus does not
refresh the pane and I end up having a warning about a non defined
instance which is not one.
Did you see this glitch?

Stef

I opened an issue last year:
https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor

Good point.

Need to refresh code view on a class method (and subclass methods) when class reorganized event is sent... take care of not removing unsaved changes then. Maybe toggling off and on syntax highlighting may be enough.

There is also the change code in debugger, have it compiled but the method is still the same on the next run.

Phil

Thierry

philippeback

Re: Missing refresh after method definition

In reply to this post by Denis Kudriashov

On Tue, Mar 28, 2017 at 2:59 PM, Denis Kudriashov <[hidden email]> wrote:

2017-03-28 14:38 GMT+02:00 [hidden email] <[hidden email]>:
I want a "remove all of the yellowish tempvars from this method" refactoring then.

Generally we need more intelligence on critic icons. Now they not allow "fix it" action.

I'd add that we need to segregate "navigation icons" from "indication icons" from "action icons" (e.g. overriden/overriding method vs test pass vs run test/initialize).

And also allow for more than one action on a browser entry (method/protocol/... etc). The mechanism for extension is powerful but is crippled by the inability to have more than one thing (e.g. I would like to have support for several pragmas or name matches). These should at least appear as actions in the popup menu in a special section if we only allow a single top priority action on an item. This icon stuff proved problematic when refactoring some tests as there was no way to move up/down in the inherited methods because a green/red/gray bubble was on top (same for <script> BTW).

This is super powerful and complements the GT ideas pretty neatly I think.

I dream of Calypso meeting Nautilus and giving us the full feature set with clean code.

Phil

Thierry Goubier

Re: Missing refresh after method definition

In reply to this post by philippeback

Le 28/03/2017 à 14:59, [hidden email] a écrit :

>
> On Tue, Mar 28, 2017 at 2:44 PM, Thierry Goubier
> <[hidden email] <mailto:[hidden email]>> wrote:
>
> Le 28/03/2017 à 14:31, Cyril Ferlicot D. a écrit :
>
> On 28/03/2017 12:39, Stephane Ducasse wrote:
>
> Hi
>
> I often defined method and let the system guess and propose
> the addition
> to new instance variables and (they are red) but once I
> created the
> instance variables they should not be red anymore. Now
> nautilus does not
> refresh the pane and I end up having a warning about a non
> defined
> instance which is not one.
> Did you see this glitch?
>
> Stef
>
>
> I opened an issue last year:
> https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor
> <https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor>
>
>
> Good point.
>
> Need to refresh code view on a class method (and subclass methods)
> when class reorganized event is sent... take care of not removing
> unsaved changes then. Maybe toggling off and on syntax highlighting
> may be enough.
>
>
> There is also the change code in debugger, have it compiled but the
> method is still the same on the next run.

Are you sure? Each time I modify and save in the debugger, the system
browser view of the method is updated as well.

Thierry

>
> Phil
>
>
>
>
> Thierry
>
>

philippeback

Re: Missing refresh after method definition

On Tue, Mar 28, 2017 at 3:31 PM, Thierry Goubier <[hidden email]> wrote:

Le 28/03/2017 à 14:59, [hidden email] a écrit :

On Tue, Mar 28, 2017 at 2:44 PM, Thierry Goubier
<[hidden email] <mailto:[hidden email]>> wrote:

Le 28/03/2017 à 14:31, Cyril Ferlicot D. a écrit :

On 28/03/2017 12:39, Stephane Ducasse wrote:

Hi

I often defined method and let the system guess and propose
the addition
to new instance variables and (they are red) but once I
created the
instance variables they should not be red anymore. Now
nautilus does not
refresh the pane and I end up having a warning about a non
defined
instance which is not one.
Did you see this glitch?

Stef

I opened an issue last year:
https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor
<https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor>

Good point.

Need to refresh code view on a class method (and subclass methods)
when class reorganized event is sent... take care of not removing
unsaved changes then. Maybe toggling off and on syntax highlighting
may be enough.

There is also the change code in debugger, have it compiled but the
method is still the same on the next run.

Are you sure? Each time I modify and save in the debugger, the system browser view of the method is updated as well.

Definitely happens when I go back in the stack, restart, change the code, and do that a few times. Looks like it is related to code in a block or something I've been told. I do not remember which but I remember that I am doing fileouts of some code to be sure I am not going to lose my changes. When that happens, I end up shouting loudly. Happens a few times a week.

Phil

Thierry

Phil

Thierry

Thierry Goubier

Re: Missing refresh after method definition

Le 28/03/2017 à 15:45, [hidden email] a écrit :

>
>
> On Tue, Mar 28, 2017 at 3:31 PM, Thierry Goubier
> <[hidden email] <mailto:[hidden email]>> wrote:
>
> Le 28/03/2017 à 14:59, [hidden email]
> <mailto:[hidden email]> a écrit :
>
>
> On Tue, Mar 28, 2017 at 2:44 PM, Thierry Goubier
> <[hidden email] <mailto:[hidden email]>
> <mailto:[hidden email]
> <mailto:[hidden email]>>> wrote:
>
> Le 28/03/2017 à 14:31, Cyril Ferlicot D. a écrit :
>
> On 28/03/2017 12:39, Stephane Ducasse wrote:
>
> Hi
>
> I often defined method and let the system guess and
> propose
> the addition
> to new instance variables and (they are red) but once I
> created the
> instance variables they should not be red anymore. Now
> nautilus does not
> refresh the pane and I end up having a warning about
> a non
> defined
> instance which is not one.
> Did you see this glitch?
>
> Stef
>
>
> I opened an issue last year:
>
> https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor
> <https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor>
>
> <https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor
> <https://pharo.fogbugz.com/f/cases/19150/Generating-new-instance-variable-could-refresh-the-highlight-of-the-code-editor>>
>
>
> Good point.
>
> Need to refresh code view on a class method (and subclass
> methods)
> when class reorganized event is sent... take care of not
> removing
> unsaved changes then. Maybe toggling off and on syntax
> highlighting
> may be enough.
>
>
> There is also the change code in debugger, have it compiled but the
> method is still the same on the next run.
>
>
> Are you sure? Each time I modify and save in the debugger, the
> system browser view of the method is updated as well.
>
>
> Definitely happens when I go back in the stack, restart, change the
> code, and do that a few times. Looks like it is related to code in a
> block or something I've been told. I do not remember which but I
> remember that I am doing fileouts of some code to be sure I am not going
> to lose my changes. When that happens, I end up shouting loudly. Happens
> a few times a week.

A few times a week is far too often.

I wonder if we could instrument that to get a trace when it happens.

Thierry

>
> Phil
>
>
> Thierry
>
>
> Phil
>
>
>
>
> Thierry
>
>
>
>
>