Monticello Bug introduced in Pharo 8

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Monticello Bug introduced in Pharo 8

Peter Newton
Hi. I'm a Smalltalk newcomer, slowly exploring Pharo to understand its
potential and in the process I've found and fixed what seems to be a bug in
Metacello (although it could be more widespread). So what now, how to best
report the bug and my fix?

To reproduce the bug, in Pharo 8 or 9, simply chose 'Save' from the
Monticello browser when a repository is selected and edit either the version
name or the log message, you should see the error "/MCSaveVersionDialog
doesn't understand #selectedClassOrMetaClass/".

As far as I can tell, Pharo 8 introduced the idea of a CompletionEngine for
Smalltalk text areas that sends /#selectedClassOrMetaClass/ to the text
area. This method is implemented in descendants of MCCodeTool but doesn't
exist in the parent MCTool - which is what MCSaveVersionDialog derives from.

My fix reworks /MCTool>>textMorph:/ to allow the version dialog text areas
to be constructed with the message #beForSmalltalkComment rather than
#beForSmalltalkScripting. This works, but I have no idea if this is the best
way, how to share my fix, or how to raise this as a bug with the Pharo
maintainers to make Pharo a more stable platform. All advice is most
welcome.



--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html

Reply | Threaded
Open this post in threaded view
|

Re: Monticello Bug introduced in Pharo 8

Marcus Denker-4


> On 10 Jun 2020, at 04:01, Peter Newton <[hidden email]> wrote:
>
> Hi. I'm a Smalltalk newcomer, slowly exploring Pharo to understand its
> potential and in the process I've found and fixed what seems to be a bug in
> Metacello (although it could be more widespread). So what now, how to best
> report the bug and my fix?
>

We have some information on the website. I think the best is if you try to follow
those, because this way we can see if they are enough or if we need to improve
them:  

Reporting issues
        https://www.pharo.org/contribute-report-bug

Propose a bugfix
        https://www.pharo.org/contribute-propose-fix


(these are linked from  https://www.pharo.org/contribute )


        Marcus


Reply | Threaded
Open this post in threaded view
|

Re: Monticello Bug introduced in Pharo 8

Stéphane Ducasse
In reply to this post by Peter Newton
Welcome on board Peter and thanks for your time and willingness to improve Pharo.

> On 10 Jun 2020, at 04:01, Peter Newton <[hidden email]> wrote:
>
> Hi. I'm a Smalltalk newcomer, slowly exploring Pharo to understand its
> potential and in the process I've found and fixed what seems to be a bug in
> Metacello (although it could be more widespread). So what now, how to best
> report the bug and my fix?
>
> To reproduce the bug, in Pharo 8 or 9, simply chose 'Save' from the
> Monticello browser when a repository is selected and edit either the version
> name or the log message, you should see the error "/MCSaveVersionDialog
> doesn't understand #selectedClassOrMetaClass/".
>
> As far as I can tell, Pharo 8 introduced the idea of a CompletionEngine for
> Smalltalk text areas that sends /#selectedClassOrMetaClass/ to the text
> area. This method is implemented in descendants of MCCodeTool but doesn't
> exist in the parent MCTool - which is what MCSaveVersionDialog derives from.
>
> My fix reworks /MCTool>>textMorph:/ to allow the version dialog text areas
> to be constructed with the message #beForSmalltalkComment rather than
> #beForSmalltalkScripting. This works, but I have no idea if this is the best
> way, how to share my fix, or how to raise this as a bug with the Pharo
> maintainers to make Pharo a more stable platform. All advice is most
> welcome.

I do not know in fact. What is the kind of text that is displayed in MCTool?

S
Reply | Threaded
Open this post in threaded view
|

Re: Monticello Bug introduced in Pharo 8

Peter Newton
In reply to this post by Marcus Denker-4
Thanks Markus, I will check there and post an bug report.



--
Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html