Monticello diff between image and tonel repo

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Monticello diff between image and tonel repo

HilaireFernandes
Hi,

I think I already report it but I still see this issue. From Monticello
when I request changes between image and my tonel repo I got wrong diff
report.  It is a bit scarry. Will code be lost? You are not sure about
what really change.

Or do I misunderstand something?

See screenshot

Hilaire

--
Dr. Geo
http://drgeo.eu


MissMatchMonticello.png (477K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Monticello diff between image and tonel repo

Ben Coman
Its hard to determine what is wrong from the screen shot.
I'm probably not the one able to provide an answer, 
but anyway... can you provide steps-to-reproduce in a fresh Image?

cheers -ben


On Sat, 16 Feb 2019 at 06:13, Hilaire <[hidden email]> wrote:
Hi,

I think I already report it but I still see this issue. From Monticello
when I request changes between image and my tonel repo I got wrong diff
report.  It is a bit scarry. Will code be lost? You are not sure about
what really change.

Or do I misunderstand something?

See screenshot

Hilaire

--
Dr. Geo
http://drgeo.eu

Reply | Threaded
Open this post in threaded view
|

Re: Monticello diff between image and tonel repo

HilaireFernandes
Hi Ben,

The screenshot shows two things:

 1. In the top (black background), it shows the first lines of the file
    'DrGAngle3ptsOrientedItem.class.st' from the tonel repository, in
    the DrGeoII-Core tonel package. In this source, you see a
    'CostumeClasse' method.
 2. In the second half of the screenshot, in the Pharo environment,
    there are three windows to look at:
     1. in the background the Monticello window with the DrGeoII-Core
        package selected from the tonel repo (the same as in 1.);
     2. on top of the Monticello window, the repository is open and you
        can see its packages. The DrGeoII-Core package is selected;
     3. then the foreground window shows the changes between two
        packages: one is the tonel package, the other one I don't know
        (HilaireFernandes.7). Importantly, it look like costumClass
        method does not exist in the tonel package, which is wrong as
        seen in 1.

At the minimum, the information misrepresented, or I miss use the tool.
Anyway it is confusing for me or not obvious, likely more confusing for
newbie which may think the tool is unreliable, and they want to go away.

To reproduce, create a tonel repo, add package to this repo, or repo to
the package, and test the same as explained above.

Hilaire


Le 16/02/2019 à 07:23, Ben Coman a écrit :
> Its hard to determine what is wrong from the screen shot.
> I'm probably not the one able to provide an answer, 
> but anyway... can you provide steps-to-reproduce in a fresh Image?
>
--
Dr. Geo
http://drgeo.eu



Reply | Threaded
Open this post in threaded view
|

Re: Monticello diff between image and tonel repo

Ben Coman
Le 16/02/2019 à 07:23, Ben Coman a écrit :
> Its hard to determine what is wrong from the screen shot.
> I'm probably not the one able to provide an answer, 
> but anyway... can you provide steps-to-reproduce in a fresh Image?

On Sat, 16 Feb 2019 at 16:49, Hilaire <[hidden email]> wrote:
Hi Ben,

The screenshot shows two things:

 1. In the top (black background), it shows the first lines of the file
    'DrGAngle3ptsOrientedItem.class.st' from the tonel repository, in
    the DrGeoII-Core tonel package. In this source, you see a
    'CostumeClasse' method.
 2. In the second half of the screenshot, in the Pharo environment,
    there are three windows to look at:
     1. in the background the Monticello window with the DrGeoII-Core
        package selected from the tonel repo (the same as in 1.);
     2. on top of the Monticello window, the repository is open and you
        can see its packages. The DrGeoII-Core package is selected;
     3. then the foreground window shows the changes between two
        packages: one is the tonel package, the other one I don't know
        (HilaireFernandes.7). Importantly, it look like costumClass
        method does not exist in the tonel package, which is wrong as
        seen in 1.

That helped my understanding a lot.  Its still a static snapshot though.
It would be much easier to comment if I could scroll that changes list looking for patterns.

 
 At the minimum, the information misrepresented, or I miss use the tool.
Anyway it is confusing for me or not obvious, likely more confusing for
newbie which may think the tool is unreliable, and they want to go away.

To reproduce, create a tonel repo, add package to this repo, or repo to
the package, and test the same as explained above.

That isn't even close to "steps to reproduce".

Thats just a lot of effort for me to produce scenario B that has a high chance of 
being entirely unrelated to scenario A you presented.

To make it easiest to help you, "steps to reproduce" means you hold my hand to *exactly* 
reproduce your screenshot.  If you code is proprietary, you need to create a non-proprietary 
scenario B with the same problem which you can share in full.  If that is too much effort for you,
then its too much effort for me to GUESS at producing scenario B that is remotely close to your problem.

Anyway, I'm a sucker and went digging anyway. I'm only *guessing* this is the referenced code...

What I notice is that all the "green-plus" methods are missing from there,
and the "red-cross" method exists.

So while I forget the semantics of each changes pane, 
perhaps you are reading it in reverse?
"green-plus" methods are in Monticello package
"red-cross" methods are missing from Monticello package

HTH, YMMV,
cheers -ben
Reply | Threaded
Open this post in threaded view
|

Re: Monticello diff between image and tonel repo

HilaireFernandes
Hi Ben,

I am not looking at you reproducing the scenario (you asked for) as it
is some work and the outcome may not be reliable as you mentioned it.
Nevertheless, the steps I described will likely get you on the trouble
and are easy to get in.

But more on sharing experience on this topic, as I meet it several
times. I think it is an important issue, I have since migrating to
Tonel, and it needs to be reported.

Closing Monticello windows and opening a fresh one helped to get the
changes right, sometime... Other time, forcing flush cash on Monticello
helps.

But still, this really makes fell the environment to be fragile and
inconstant for serious work. It seems Monticello is confused by two
sources of package tonel, and mcz. Already meet this problem too.

Hilaire


PS: DrGeo is free software.

Le 16/02/2019 à 10:52, Ben Coman a écrit :
> That isn't even close to "steps to reproduce".
>
> Thats just a lot of effort for me to produce scenario B that has a
> high chance of 
> being entirely unrelated to scenario A you presented.
>
--
Dr. Geo
http://drgeo.eu



Reply | Threaded
Open this post in threaded view
|

Re: Monticello diff between image and tonel repo

HilaireFernandes
I confirm again this issue, while annoying, flushing Monticello helps to
get a proper diff.

https://github.com/pharo-project/pharo/issues/2583

Hilaire

Le 16/02/2019 à 11:56, Hilaire a écrit :
> Closing Monticello windows and opening a fresh one helped to get the
> changes right, sometime... Other time, forcing flush cash on Monticello
> helps.

--
Dr. Geo
http://drgeo.eu