More bugs, sorry :)

Good morning
    Last night I managed to obtain a couple of new walkbacks and a
possible enhancement;

SmalltalkSystemShell
--------------------

- Right clicking on the background with no item selected brings up the
  popup menu with the 'Whats this?' option enabled, when clicked it
  gives a walkback. Appears a simple fix to queryCommand: .

- Right clicking some of the non-OA items such as Ian's chunk browser
  and selecting 'Whats this?' will produce a walkback. helpId when nil
  tries to access self view (SmalltalkSystemIcon), which doesn't exist?

ClassBrowserShell|SystemBrowserShell
------------------------------------

- When saving a method change with an error, a message will appear on
  the third section of the status bar. At this point the fourth section
  is not used. The third section is not necessarily big enough for the
  message, could it be expanded to take all space in this situation?

    I apologise for pounding like a frenzied monkey all over the
environment but this bug-hunting is becoming notably more fun that
actually doing any (non-dolphin) work :D .

    cheers

        Andrew

"Andrew Lawson" <[hidden email]> wrote in message
news:[hidden email]...
Recorded as #2024. Will  be patched in  PL1.

> - Right clicking some of the non-OA items such as Ian's chunk browser
>  and selecting 'Whats this?' will produce a walkback. helpId when nil
>  tries to access self view (SmalltalkSystemIcon), which doesn't exist?

Erm, is this an OA problem?

>
> ClassBrowserShell|SystemBrowserShell
> ------------------------------------
>
> - When saving a method change with an error, a message will appear on
>  the third section of the status bar. At this point the fourth section
>  is not used. The third section is not necessarily big enough for the
>  message, could it be expanded to take all space in this situation?

This was previously reported in the beta (#1927), and some adjustment was
made, but I agree it is not enough.  I'll re-open that one.

>
>    I apologise for pounding like a frenzied monkey all over the
> environment but this bug-hunting is becoming notably more fun that
> actually doing any (non-dolphin) work :D .

Pound away.

Regards

Blair

Blair,

>> - Right clicking some of the non-OA items such as Ian's chunk browser
>>  and selecting 'Whats this?' will produce a walkback. helpId when nil
>>  tries to access self view (SmalltalkSystemIcon), which doesn't exist?
>
> Erm, is this an OA problem?

Whilst having a look to see what additions are needed I noticed that
when right clicking in an empty area of the SmalltalkSystemShell the
"What's this" menu option is enabled (Properties isn't) and raises a
walkback when selected.

--
Ian

Use the Reply-To address to contact me.
Mail sent to the From address is ignored.

Blair McGlashan wrote:
> "Andrew Lawson" <[hidden email]> wrote in message
>> - Right clicking some of the non-OA items such as Ian's chunk browser
>>  and selecting 'Whats this?' will produce a walkback. helpId when nil
>>  tries to access self view (SmalltalkSystemIcon), which doesn't exist?
>
> Erm, is this an OA problem?

Errr ... I think so :) It appears (to me) that the helpId is an index
into the OA documentation. What should a writer of add-ons answer at
this point? Secondly, the 'self view' call confuses me,
SmalltalkSystemIcon doesn't have a view, or does it?

        Cheers

                Andrew

Andrew,

Yes, it is a bug or rather a "copyio" (like a typo but where a method
has been copied and then not appropriately edited). I suspect Blair
probably isn't aware of the machinations in the helpId stuff since I
was responsible for it. Anyway I have entered it as #2029 and it will
be fixed in the next patch level.

For the momemt the fix can be applied with:
--
!SmalltalkSystemIcon methodsFor!

helpId
        "Answer an integer ID used to associate the receicer with pop-up help"

        ^helpId ifNil: [-1]! !
!SmalltalkSystemIcon categoriesFor: #helpId!accessing!public! !
--

Best regards,

--
Andy Bower
Dolphin Support
www.object-arts.com