Multiple cookies in the HTTP headers

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Multiple cookies in the HTTP headers

Boris Popov, DeepCove Labs (SNN)
Attached file-outs (VisualWorks) include a fix to multiple equivalent
cookies being added to the response. Specifically, the initial request
would go through WASession>>start: and subsequently
WASession>>redirectWithCookies: which would add a session cookie to the
response, but WASession>>respond: would also add the same cookie to the
same response. While the correct fix might be to not do a
redirectWithCookies on session start when using cookies, the attached
fixes ensure that adding equivalent cookie to the response will never
result in it being listed there multiple times.

Cheers!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.


_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

WAResponse-addCookie.st (620 bytes) Download Attachment
Root.Smalltalk.Seaside.WACookie-comparing.st (868 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Multiple cookies in the HTTP headers

Philippe Marschall
Hi

I had a look at the patches and have a question:
For equality you take the key, value, expiry and path into account.
Does this make sense (semantically)? Wouldn't it be better to just use
the key and path? Or just the key? I mean it's called key for a
reason.

Cheers
Philippe


2006/10/10, Boris Popov <[hidden email]>:

> Attached file-outs (VisualWorks) include a fix to multiple equivalent
> cookies being added to the response. Specifically, the initial request
> would go through WASession>>start: and subsequently
> WASession>>redirectWithCookies: which would add a session cookie to the
> response, but WASession>>respond: would also add the same cookie to the
> same response. While the correct fix might be to not do a
> redirectWithCookies on session start when using cookies, the attached
> fixes ensure that adding equivalent cookie to the response will never
> result in it being listed there multiple times.
>
> Cheers!
>
> -Boris
>
> --
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
>
> [hidden email]
>
> CONFIDENTIALITY NOTICE
>
> This email is intended only for the persons named in the message
> header. Unless otherwise indicated, it contains information that is
> private and confidential. If you have received it in error, please
> notify the sender and delete the entire message including any
> attachments.
>
> Thank you.
>
>
>
> _______________________________________________
> Seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>
>
>
>
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside