My first try at bug fixing for Helios , issue 967

Hi!

Cool to have you trying to fix issues. Keep pushing :)

First, SourceArea is a class of the legacy IDE, not Helios. You should
have a look at HLSourceWidget and its subclasses instead.

About this issue, you should have a look at the
HLBrowserModel>>showComment: method. It uses #withChangesDo: which will
check for unsaved changes leading to this bug. You could try to simply remove
#withChangesDo: ?

HTH,
Nico

kilon alios <[hidden email]> writes:

> So I decided to try to fix issue 967 that can be found here
>
> https://github.com/amber-smalltalk/amber/issues/967
>
> As it says in the description if you try to edit a method and then disable
> comment it will ask you for storing the methods modified content first
> which of course makes no sense since documentation and method source should
> be two separate things.
>
> The last few days I have been reading the code of Helios to try to find the
> bug but I have not been successful so I thought instead of hitting my head
> against the wall it would be better to ask for directions and general
> advice first.
>
> Now from my study I have identified that source code is handled at IDE
> package SourceArea class while documentation is handled at Helios-Browser
> package HLDocumentationWidget class.
>
> But also I have been unsuccessful finding the code causing the dialog to
> appear. I fear this happens at the CodeMirror side which is of course
> outside Helios code when textarea is refreshed with contents modified.
>
> Another thing that bothered me is that I went to SourceArea >> setEditorOn:
> and modified it by adding the cofiguration lineWrapping: true and nothing
> happend, no wrapping at all. Commited the package and restarted Helios,
> nothing.
>
> So what am I missing here ? Take your time to reply, I will keep looking in
> the mean time and learn as much I can from Helios.
>
> Also is this kind of discussions ok for the list or should I direct them to
> the issue tracker directly ? I can copy paste this message there too if you
> want.

--
Nicolas Petton
http://nicolas-petton.fr

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.