New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

Juan Vuletich-4
Hi Folks,

I have just updated https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev 
. When we are happy with this, I can do a 4.3 release, as the
enhancements to Features are quite important.

These changes include Ken's enhancements to support version ranges in
FeatureRequisite, and a couple of new convenience methods in Feature, to
enable things like
     Feature require: 'Sound'
     Feature require: 'Tests' version: 1.0
     (FeatureRequirement name: #'Sound' minVersion: 1 minRevision: 23
maxVersion: 3) require

They also support Benhard's suggestion for more flexible package
directory structure, without needing to specify the location of the
dependences. In Bernhard's words: "a) Search all subdirectories of the
image directory whose name starts with "Cuis-Smalltalk" (and possibly
subdirectories named Packages?) It would rely on the convention that
everyone names their Cuis package repositories accordingly. IMO this
would be good anyway for consistency and SEO reasons."

I also made the fullPathName of installed packages to be cleared when
the image is moved around, or when the saved path doesn't exist. But not
when image is saved and stored in the same place.

Finally, I also did some misc cleanup, fixed a couple of bugs you have
reported (blinking cursor in bold text, and failing extended clipboard
tests), and my own fix to a bug in precedence of inherited class
variables and globals, discussed recently in squeak-dev.

I still need to move StyledTextEditor to its own repo, and I guess a
million other details, but I want you to try this without additional delay.

Cheers,
Juan Vuletich

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
Reply | Threaded
Open this post in threaded view
|

Re: New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

Hannes Hirzel
Great updates, Juan. Thank you. I have a suggestion of a  small
additional requirement, see below.

--Hannes

On 7/30/13, Juan Vuletich <[hidden email]> wrote:

> Hi Folks,
>
> I have just updated https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
> . When we are happy with this, I can do a 4.3 release, as the
> enhancements to Features are quite important.
>
> These changes include Ken's enhancements to support version ranges in
> FeatureRequisite, and a couple of new convenience methods in Feature, to
> enable things like
>      Feature require: 'Sound'
>      Feature require: 'Tests' version: 1.0
>      (FeatureRequirement name: #'Sound' minVersion: 1 minRevision: 23
> maxVersion: 3) require
>
> They also support Benhard's suggestion for more flexible package
> directory structure, without needing to specify the location of the
> dependences. In Bernhard's words:

"a) Search all subdirectories of the
> image directory whose name starts with "Cuis-Smalltalk" (and possibly
> subdirectories named Packages?) It would rely on the convention that
> everyone names their Cuis package repositories accordingly. IMO this
> would be good anyway for consistency and SEO reasons."

Instead of "Search all subdirectories of the image directory"

do

"Search all subdirectories and siblings directories of the image directory"

End of last year and early this year we had the discussion how to
arrange the directory structure and what we agreed at was to have an
image directory and then the other packages residing in siblings
directories. I found that to be quite handy for github reasons.

At least for github is easier to manage if I have the image directory
and the repositories for the packages all on the same hierarchical
level rather than having the packages repositories residing in
subdirectories of the image directory.

If we go for
"Search all subdirectories and siblings directories of the image directory"
both options are possible, the one we  had earlier this year and the
one Bernhard prefers.



> I also made the fullPathName of installed packages to be cleared when
> the image is moved around, or when the saved path doesn't exist. But not
> when image is saved and stored in the same place.
>
> Finally, I also did some misc cleanup, fixed a couple of bugs you have
> reported (blinking cursor in bold text, and failing extended clipboard
> tests), and my own fix to a bug in precedence of inherited class
> variables and globals, discussed recently in squeak-dev.
>
> I still need to move StyledTextEditor to its own repo, and I guess a
> million other details, but I want you to try this without additional delay.
>
> Cheers,
> Juan Vuletich
>
> _______________________________________________
> Cuis mailing list
> [hidden email]
> http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
>

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
Reply | Threaded
Open this post in threaded view
|

Re: New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

Juan Vuletich-4
Hi Hannes,

You are right. Just did a new commit to fix this. Please test it, or
take a look at #placesToLookForPackagesDo: and criticize.

Cheers,
Juan Vuletich

On 7/30/2013 10:45 AM, H. Hirzel wrote:

> Great updates, Juan. Thank you. I have a suggestion of a  small
> additional requirement, see below.
>
> --Hannes
>
> On 7/30/13, Juan Vuletich<[hidden email]>  wrote:
>> Hi Folks,
>>
>> I have just updated https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>> . When we are happy with this, I can do a 4.3 release, as the
>> enhancements to Features are quite important.
>>
>> These changes include Ken's enhancements to support version ranges in
>> FeatureRequisite, and a couple of new convenience methods in Feature, to
>> enable things like
>>       Feature require: 'Sound'
>>       Feature require: 'Tests' version: 1.0
>>       (FeatureRequirement name: #'Sound' minVersion: 1 minRevision: 23
>> maxVersion: 3) require
>>
>> They also support Benhard's suggestion for more flexible package
>> directory structure, without needing to specify the location of the
>> dependences. In Bernhard's words:
> "a) Search all subdirectories of the
>> image directory whose name starts with "Cuis-Smalltalk" (and possibly
>> subdirectories named Packages?) It would rely on the convention that
>> everyone names their Cuis package repositories accordingly. IMO this
>> would be good anyway for consistency and SEO reasons."
> Instead of "Search all subdirectories of the image directory"
>
> do
>
> "Search all subdirectories and siblings directories of the image directory"
>
> End of last year and early this year we had the discussion how to
> arrange the directory structure and what we agreed at was to have an
> image directory and then the other packages residing in siblings
> directories. I found that to be quite handy for github reasons.
>
> At least for github is easier to manage if I have the image directory
> and the repositories for the packages all on the same hierarchical
> level rather than having the packages repositories residing in
> subdirectories of the image directory.
>
> If we go for
> "Search all subdirectories and siblings directories of the image directory"
> both options are possible, the one we  had earlier this year and the
> one Bernhard prefers.
>
>
>
>> I also made the fullPathName of installed packages to be cleared when
>> the image is moved around, or when the saved path doesn't exist. But not
>> when image is saved and stored in the same place.
>>
>> Finally, I also did some misc cleanup, fixed a couple of bugs you have
>> reported (blinking cursor in bold text, and failing extended clipboard
>> tests), and my own fix to a bug in precedence of inherited class
>> variables and globals, discussed recently in squeak-dev.
>>
>> I still need to move StyledTextEditor to its own repo, and I guess a
>> million other details, but I want you to try this without additional delay.
>>
>> Cheers,
>> Juan Vuletich
>>
>> _______________________________________________
>> Cuis mailing list
>> [hidden email]
>> http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
>>
> _______________________________________________
> Cuis mailing list
> [hidden email]
> http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
>


_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
Reply | Threaded
Open this post in threaded view
|

Re: New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

KenDickey
In reply to this post by Juan Vuletich-4
On Tue, 30 Jul 2013 08:37:53 -0300
Juan Vuletich <[hidden email]> wrote:

> I have just updated https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev 
> . When we are happy with this, I can do a 4.3 release, as the
> enhancements to Features are quite important.
..
> I still need to move StyledTextEditor to its own repo, and I guess a
> million other details, but I want you to try this without additional delay.

Juan,

Cool stuff!  

Two small suggestions:

FeatureRequirement>>install
        -- Method comment is bogus.
        Perhaps something like: "Preconditions have been satisfied.  I install the required package."
       
CodePackage>>save
        -- after checks (but before self writeOnStream: file), perhaps increment the revision number??
         [Note helpers: Feature>>newRevision, Feature>>newVersion which return new Feature instances, but you might prefer to  side-effect/assign-to the instance variables]


--
Ken [dot] Dickey [at] whidbey [dot] com

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
-KenD
Reply | Threaded
Open this post in threaded view
|

Re: New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

KenDickey
In reply to this post by Juan Vuletich-4
FYI,

I added a 2nd requirement (worked) and also tried requiring a feature beyond current revision (failed as expected).

This is pretty nice so far!

--
Ken [dot] Dickey [at] whidbey [dot] com

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org
-KenD
Reply | Threaded
Open this post in threaded view
|

Re: New updates (Supporting packages with their own Git repository was: Loading StyledText using a script)

Juan Vuletich-4
In reply to this post by KenDickey
On 7/30/2013 6:42 PM, Ken Dickey wrote:

> On Tue, 30 Jul 2013 08:37:53 -0300
> Juan Vuletich<[hidden email]>  wrote:
>
>> I have just updated https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
>> . When we are happy with this, I can do a 4.3 release, as the
>> enhancements to Features are quite important.
> ..
>> I still need to move StyledTextEditor to its own repo, and I guess a
>> million other details, but I want you to try this without additional delay.
> Juan,
>
> Cool stuff!
>
> Two small suggestions:
>
> FeatureRequirement>>install
> -- Method comment is bogus.
> Perhaps something like: "Preconditions have been satisfied.  I install the required package."
>
> CodePackage>>save
> -- after checks (but before self writeOnStream: file), perhaps increment the revision number??
> [Note helpers: Feature>>newRevision, Feature>>newVersion which return new Feature instances, but you might prefer to  side-effect/assign-to the instance variables]
>
>

Thanks Ken. I updated the repo after your suggestions. I also made the
package list show version numbers. However, I made revision number to
autoincrement the moment a package gets dirty, not on save. I think it
is better this way. Besides, if you increment major version number (from
an inspector so far!), the intended version number is actually used
(otherwise it would be modified again on save).

I couldn't help it, so I also did some cleanup in CodePackage :)

Still missing features include incrementing the major version number,
and showing and editing dependencies.

Cheers,
Juan Vuletich

_______________________________________________
Cuis mailing list
[hidden email]
http://jvuletich.org/mailman/listinfo/cuis_jvuletich.org