Non-SmallLand colour theme lying around?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Non-SmallLand colour theme lying around?

Frank Shearar-3
Does anyone have a ColorTheme that does NOT subclass SmallLandColorTheme?

I'm looking to set ColorTheme current to something that doesn't
reference a SmallLand thing.

frank

Reply | Threaded
Open this post in threaded view
|

Re: Non-SmallLand colour theme lying around?

Chris Muller-3
I see no reason ColorTheme should have any abstract methods (defined
as subclassResponsibility) instead of simply a default color of some
kind.  In fact, if we would just give it some state (with default
values) instead of only methods, perhaps even Smallland would no
longer need the subclasses.

I think we should give ColorTheme some state (perhaps a Dictionary of
key->value pairs so it can be flexible with Themes that may want to
specify one or two additional colorizable attributes).




On Thu, Jul 4, 2013 at 2:32 PM, Frank Shearar <[hidden email]> wrote:
> Does anyone have a ColorTheme that does NOT subclass SmallLandColorTheme?
>
> I'm looking to set ColorTheme current to something that doesn't
> reference a SmallLand thing.
>
> frank
>

Reply | Threaded
Open this post in threaded view
|

Re: Non-SmallLand colour theme lying around?

Hannes Hirzel
On 7/4/13, Chris Muller <[hidden email]> wrote:
> I see no reason ColorTheme should have any abstract methods (defined
> as subclassResponsibility) instead of simply a default color of some
> kind.

+1

 In fact, if we would just give it some state (with default

> values) instead of only methods, perhaps even Smallland would no
> longer need the subclasses.
>
> I think we should give ColorTheme some state (perhaps a Dictionary of
> key->value pairs so it can be flexible with Themes that may want to
> specify one or two additional colorizable attributes).
>
>
>
>
> On Thu, Jul 4, 2013 at 2:32 PM, Frank Shearar <[hidden email]>
> wrote:
>> Does anyone have a ColorTheme that does NOT subclass SmallLandColorTheme?
>>
>> I'm looking to set ColorTheme current to something that doesn't
>> reference a SmallLand thing.
>>
>> frank
>>
>
>