> One other thing... when doing the SystemWindow lookup in
> ScrollPane... there > is (with Polymorph) a #window method implemented in Morph that might > simplify the changes. Ah! Excellent! I updated the code. Morphic-Alexandre_Bergel.395 in PharoTaskForces Cheers, Alexandre > > Regards, Gary > > ----- Original Message ----- > From: "Alexandre Bergel" <[hidden email]> > To: <[hidden email]> > Sent: Friday, January 08, 2010 1:17 PM > Subject: Re: [Pharo-project] Notifications of windows opening/ > closing/focus > > >> Thanks for your comments. >> I renamed the announcement accordingly to your comments. I attached a >> screenshot of the new hierarchy >> >> Better? >> >> Alexandre >> >> >> > > > -------------------------------------------------------------------------------- > > > > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >> >>> Looks ok to me. >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: "Stéphane Ducasse" <[hidden email]> >>> To: <[hidden email]> >>> Sent: Thursday, January 07, 2010 8:27 PM >>> Subject: Re: [Pharo-project] Notifications of windows opening/ >>> closing/focus >>> >>> >>>> >>>>> Hi! >>>>> >>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>> includes the window announcement I have been working on for few >>>>> months >>>>> already. >>>>> >>>>> Here is an example of a unit test. >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>> >>>>> | t window newWindowCreated r | >>>>> t := 0. >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>> t := t + 1. newWindowCreated := ann window]. >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | >>>>> t := >>>>> t + 10. newWindowCreated := ann window]. >> I don't particularly like the naming. >> >> - Why including Announcement at the end? >> - Why does one contain a verb, and the other a >> - When are they fired? Closing implies to me it's not been closed >> yet, but fired somewhere after the closing has started, while >> CreationWindow I have no idea what means. >> >> MorphicWindowOpen(ed/ing) >> MorphicWindowClos(ed/ing) >> >> are both easier to read for me, shorter, and more in line with the >> naming convention for Pragma announcements already in Pharo. >> >> Cheers, >> Henry >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > -------------------------------------------------------------------------------- > > >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
Stef,
Fair enough. What do you think of the shared lookup table I posted? Bill -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse Sent: Friday, January 08, 2010 5:06 AM To: [hidden email] Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus Build something and propose it. Continue to discuss and get a group of people working on the solution. Good solution should emerge but code is important. Stef > Henry, > > Then we need to fix the weak collections. Dolphin (of the mid-90's) already had thread-safe weak collections and a high-priority process to detect and clean up "damage" to them; it's time to catch up. > > The more I think about it, your idea is sounding a lot like the dependency days of MVC - remember #release? I'm trying to forget. > > I am not trying to be confrontational, but we can and should do better than this. > > Bill > > > > -----Original Message----- > From: [hidden email] > [mailto:[hidden email]] On Behalf Of > Henrik Sperre Johansen > Sent: Thursday, January 07, 2010 8:27 PM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows > opening/closing/focus > > On 08.01.2010 02:07, Schwab,Wilhelm K wrote: >> Henry, >> >> No argument, your solution is simpler. However, we do not have announcements like this now, and it appears that the poor state of weak collections in Squeak/Pharo is standing in the way of a clean implementation. My vote is to tackle the weaklings, at least until they work well enough to support what we should have in this case. Otherwise, we kick the weak can down the road as has been done all along rather than fixing it, AND we end up with a sub-standard announcments-based framework. >> >> Let's do it right. We will then have an evolving/improving weak collection and something in the image that puts some stress on same. If I'm missing something, please enlighten me. >> >> Bill >> > Weak collections does not stand in the way of making the use case of unregistering dynamic registrations manually easier. > They stand in the way of the use case of unregistrating registeration automatically. > > Here's what you're missing: > No matter how you implement the automatic unregistering, it will be nondetermenistic, for the exact same reasons finalization is nondeterministic. > Thus, if you require deterministic unregistration, you have to do it manually, and the use case of making that easier to do have value in its own right. > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
The discussion diverged into two tracks:
1 - windows event 2 - weak collections in announcer I do not have a solution for 2). But for 1), I proposed a new version of Morphic in PharoTaskForces. Gary had a look at it and is ok with the code. Alexandre On 8 Jan 2010, at 07:06, Stéphane Ducasse wrote: > Build something and propose it. > Continue to discuss and get a group of people working on the solution. > Good solution should emerge but code is important. > > Stef > >> Henry, >> >> Then we need to fix the weak collections. Dolphin (of the >> mid-90's) already had thread-safe weak collections and a high- >> priority process to detect and clean up "damage" to them; it's time >> to catch up. >> >> The more I think about it, your idea is sounding a lot like the >> dependency days of MVC - remember #release? I'm trying to forget. >> >> I am not trying to be confrontational, but we can and should do >> better than this. >> >> Bill >> >> >> >> -----Original Message----- >> From: [hidden email] [mailto:[hidden email] >> ] On Behalf Of Henrik Sperre Johansen >> Sent: Thursday, January 07, 2010 8:27 PM >> To: [hidden email] >> Subject: Re: [Pharo-project] Notifications of windows opening/ >> closing/focus >> >> On 08.01.2010 02:07, Schwab,Wilhelm K wrote: >>> Henry, >>> >>> No argument, your solution is simpler. However, we do not have >>> announcements like this now, and it appears that the poor state of >>> weak collections in Squeak/Pharo is standing in the way of a clean >>> implementation. My vote is to tackle the weaklings, at least >>> until they work well enough to support what we should have in this >>> case. Otherwise, we kick the weak can down the road as has been >>> done all along rather than fixing it, AND we end up with a sub- >>> standard announcments-based framework. >>> >>> Let's do it right. We will then have an evolving/improving weak >>> collection and something in the image that puts some stress on >>> same. If I'm missing something, please enlighten me. >>> >>> Bill >>> >> Weak collections does not stand in the way of making the use case >> of unregistering dynamic registrations manually easier. >> They stand in the way of the use case of unregistrating >> registeration automatically. >> >> Here's what you're missing: >> No matter how you implement the automatic unregistering, it will be >> nondetermenistic, for the exact same reasons finalization is >> nondeterministic. >> Thus, if you require deterministic unregistration, you have to do >> it manually, and the use case of making that easier to do have >> value in its own right. >> >> Cheers, >> Henry >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Schwab,Wilhelm K
I'm dull on this kind of topics ;)
and this is why I listen and try to understand from the discussion. I learned a lot this year already on a lot of topics (float, complex....) stef On Jan 8, 2010, at 7:23 PM, Schwab,Wilhelm K wrote: > Stef, > > Fair enough. What do you think of the shared lookup table I posted? > > Bill > > > > -----Original Message----- > From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse > Sent: Friday, January 08, 2010 5:06 AM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus > > Build something and propose it. > Continue to discuss and get a group of people working on the solution. > Good solution should emerge but code is important. > > Stef > >> Henry, >> >> Then we need to fix the weak collections. Dolphin (of the mid-90's) already had thread-safe weak collections and a high-priority process to detect and clean up "damage" to them; it's time to catch up. >> >> The more I think about it, your idea is sounding a lot like the dependency days of MVC - remember #release? I'm trying to forget. >> >> I am not trying to be confrontational, but we can and should do better than this. >> >> Bill >> >> >> >> -----Original Message----- >> From: [hidden email] >> [mailto:[hidden email]] On Behalf Of >> Henrik Sperre Johansen >> Sent: Thursday, January 07, 2010 8:27 PM >> To: [hidden email] >> Subject: Re: [Pharo-project] Notifications of windows >> opening/closing/focus >> >> On 08.01.2010 02:07, Schwab,Wilhelm K wrote: >>> Henry, >>> >>> No argument, your solution is simpler. However, we do not have announcements like this now, and it appears that the poor state of weak collections in Squeak/Pharo is standing in the way of a clean implementation. My vote is to tackle the weaklings, at least until they work well enough to support what we should have in this case. Otherwise, we kick the weak can down the road as has been done all along rather than fixing it, AND we end up with a sub-standard announcments-based framework. >>> >>> Let's do it right. We will then have an evolving/improving weak collection and something in the image that puts some stress on same. If I'm missing something, please enlighten me. >>> >>> Bill >>> >> Weak collections does not stand in the way of making the use case of unregistering dynamic registrations manually easier. >> They stand in the way of the use case of unregistrating registeration automatically. >> >> Here's what you're missing: >> No matter how you implement the automatic unregistering, it will be nondetermenistic, for the exact same reasons finalization is nondeterministic. >> Thus, if you require deterministic unregistration, you have to do it manually, and the use case of making that easier to do have value in its own right. >> >> Cheers, >> Henry >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Alexandre Bergel
Alexandre
as soon as we will got the names right publish, add a bug tracker item and this will be integrated now about the names Closing or Closed? Collapsed? WindowMoved? what is the convention? when the event happens at the end I would prefer ed when it occurs over a long action ing any english-oriented/design remarks? ? > > Alexandre > > > <Picture 3.png> > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >> >>> Looks ok to me. >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: "Stéphane Ducasse" <[hidden email]> >>> To: <[hidden email]> >>> Sent: Thursday, January 07, 2010 8:27 PM >>> Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus >>> >>> >>>> >>>>> Hi! >>>>> >>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>> includes the window announcement I have been working on for few months >>>>> already. >>>>> >>>>> Here is an example of a unit test. >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>> >>>>> | t window newWindowCreated r | >>>>> t := 0. >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>> t := t + 1. newWindowCreated := ann window]. >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | t := >>>>> t + 10. newWindowCreated := ann window]. >> I don't particularly like the naming. >> >> - Why including Announcement at the end? >> - Why does one contain a verb, and the other a >> - When are they fired? Closing implies to me it's not been closed yet, but fired somewhere after the closing has started, while CreationWindow I have no idea what means. >> >> MorphicWindowOpen(ed/ing) >> MorphicWindowClos(ed/ing) >> >> are both easier to read for me, shorter, and more in line with the naming convention for Pragma announcements already in Pharo. >> >> Cheers, >> Henry >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
If "after the fact" I'd vote for the "ed" suffix too. Make it match what
is/has happening/happened. As a side note, WindowClosing is common to give a potential veto chance (i.e. deny close). Should also be a WindowClosed if it does get that far... Regards, Gary ----- Original Message ----- From: "Stéphane Ducasse" <[hidden email]> To: <[hidden email]> Sent: Friday, January 08, 2010 8:19 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus Alexandre as soon as we will got the names right publish, add a bug tracker item and this will be integrated now about the names Closing or Closed? Collapsed? WindowMoved? what is the convention? when the event happens at the end I would prefer ed when it occurs over a long action ing any english-oriented/design remarks? ? > > Alexandre > > > <Picture 3.png> > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >> >>> Looks ok to me. >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: "Stéphane Ducasse" <[hidden email]> >>> To: <[hidden email]> >>> Sent: Thursday, January 07, 2010 8:27 PM >>> Subject: Re: [Pharo-project] Notifications of windows >>> opening/closing/focus >>> >>> >>>> >>>>> Hi! >>>>> >>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>> includes the window announcement I have been working on for few months >>>>> already. >>>>> >>>>> Here is an example of a unit test. >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>> >>>>> | t window newWindowCreated r | >>>>> t := 0. >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>> t := t + 1. newWindowCreated := ann window]. >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | t := >>>>> t + 10. newWindowCreated := ann window]. >> I don't particularly like the naming. >> >> - Why including Announcement at the end? >> - Why does one contain a verb, and the other a >> - When are they fired? Closing implies to me it's not been closed yet, >> but fired somewhere after the closing has started, while CreationWindow I >> have no idea what means. >> >> MorphicWindowOpen(ed/ing) >> MorphicWindowClos(ed/ing) >> >> are both easier to read for me, shorter, and more in line with the naming >> convention for Pragma announcements already in Pharo. >> >> Cheers, >> Henry >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
Stef,
I find it difficult to imagine your being dull on anything, but I guess we all have limits. I have been pushing a little firmly on weak collections because Squeak/Pharo are _way_ behind where Dolphin was 12+ years ago, and it seems avoidable. So far I have created very simple thread safe (hopefully) wrappers around Dictionary (SharedLookupTable) and Set. The dictionary can be weak in keys or values. I subclass from Object to minimize problems with super classes filling gaps w/o my knowledge. Bill -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse Sent: Friday, January 08, 2010 3:16 PM To: [hidden email] Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus I'm dull on this kind of topics ;) and this is why I listen and try to understand from the discussion. I learned a lot this year already on a lot of topics (float, complex....) stef On Jan 8, 2010, at 7:23 PM, Schwab,Wilhelm K wrote: > Stef, > > Fair enough. What do you think of the shared lookup table I posted? > > Bill > > > > -----Original Message----- > From: [hidden email] > [mailto:[hidden email]] On Behalf Of > Stéphane Ducasse > Sent: Friday, January 08, 2010 5:06 AM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows > opening/closing/focus > > Build something and propose it. > Continue to discuss and get a group of people working on the solution. > Good solution should emerge but code is important. > > Stef > >> Henry, >> >> Then we need to fix the weak collections. Dolphin (of the mid-90's) already had thread-safe weak collections and a high-priority process to detect and clean up "damage" to them; it's time to catch up. >> >> The more I think about it, your idea is sounding a lot like the dependency days of MVC - remember #release? I'm trying to forget. >> >> I am not trying to be confrontational, but we can and should do better than this. >> >> Bill >> >> >> >> -----Original Message----- >> From: [hidden email] >> [mailto:[hidden email]] On Behalf Of >> Henrik Sperre Johansen >> Sent: Thursday, January 07, 2010 8:27 PM >> To: [hidden email] >> Subject: Re: [Pharo-project] Notifications of windows >> opening/closing/focus >> >> On 08.01.2010 02:07, Schwab,Wilhelm K wrote: >>> Henry, >>> >>> No argument, your solution is simpler. However, we do not have announcements like this now, and it appears that the poor state of weak collections in Squeak/Pharo is standing in the way of a clean implementation. My vote is to tackle the weaklings, at least until they work well enough to support what we should have in this case. Otherwise, we kick the weak can down the road as has been done all along rather than fixing it, AND we end up with a sub-standard announcments-based framework. >>> >>> Let's do it right. We will then have an evolving/improving weak collection and something in the image that puts some stress on same. If I'm missing something, please enlighten me. >>> >>> Bill >>> >> Weak collections does not stand in the way of making the use case of unregistering dynamic registrations manually easier. >> They stand in the way of the use case of unregistrating registeration automatically. >> >> Here's what you're missing: >> No matter how you implement the automatic unregistering, it will be nondetermenistic, for the exact same reasons finalization is nondeterministic. >> Thus, if you require deterministic unregistration, you have to do it manually, and the use case of making that easier to do have value in its own right. >> >> Cheers, >> Henry >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
On Jan 8, 2010, at 9:38 PM, Schwab,Wilhelm K wrote: > Stef, > > I find it difficult to imagine your being dull on anything, but I guess we all have limits. :) > I have been pushing a little firmly on weak collections because Squeak/Pharo are _way_ behind where Dolphin was 12+ years ago, and it seems avoidable. Yes I imagine well. > So far I have created very simple thread safe (hopefully) wrappers around Dictionary (SharedLookupTable) and Set. The dictionary can be weak in keys or values. I subclass from Object to minimize problems with super classes filling gaps w/o my knowledge. this is why I suggest you publish some code in the PharoTaskForces and get some arguments with others and we all learn :) _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Gary Chambers-4
On 08.01.2010 21:37, Gary Chambers wrote:
> If "after the fact" I'd vote for the "ed" suffix too. Make it match what > is/has happening/happened. > As a side note, WindowClosing is common to give a potential veto chance > (i.e. deny close). Should also be a WindowClosed if it does get that far... > > Regards, Gary > I suggest having both ...ing/...ed versions of close, move and resize, and ...ed for the rest, at least for now. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Gary Chambers-4
Why not something like : #aboutToClose and #closed ? Benoit St-Jean Yahoo! Messenger: bstjean Blog: lamneth.wordpress.com A standpoint is an intellectual horizon of radius zero. (Albert Einstein) From: Gary Chambers <[hidden email]> To: [hidden email] Sent: Fri, January 8, 2010 3:37:39 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus If "after the fact" I'd vote for the "ed" suffix too. Make it match what is/has happening/happened. As a side note, WindowClosing is common to give a potential veto chance (i.e. deny close). Should also be a WindowClosed if it does get that far... Regards, Gary ----- Original Message ----- From: "Stéphane Ducasse" <[hidden email]> To: <[hidden email]> Sent: Friday, January 08, 2010 8:19 PM Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus Alexandre as soon as we will got the names right publish, add a bug tracker item and this will be integrated now about the names Closing or Closed? Collapsed? WindowMoved? what is the convention? when the event happens at the end I would prefer ed when it occurs over a long action ing any english-oriented/design remarks? ? > > Alexandre > > > <Picture 3.png> > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >> >>> Looks ok to me. >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: "Stéphane Ducasse" <[hidden email]> >>> To: <[hidden email]> >>> Sent: Thursday, January 07, 2010 8:27 PM >>> Subject: Re: [Pharo-project] Notifications of windows >>> opening/closing/focus >>> >>> >>>> >>>>> Hi! >>>>> >>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>> includes the window announcement I have been working on for few months >>>>> already. >>>>> >>>>> Here is an example of a unit test. >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>> >>>>> | t window newWindowCreated r | >>>>> t := 0. >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>> t := t + 1. newWindowCreated := ann window]. >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | t := >>>>> t + 10. newWindowCreated := ann window]. >> I don't particularly like the naming. >> >> - Why including Announcement at the end? >> - Why does one contain a verb, and the other a >> - When are they fired? Closing implies to me it's not been closed yet, >> but fired somewhere after the closing has started, while CreationWindow I >> have no idea what means. >> >> MorphicWindowOpen(ed/ing) >> MorphicWindowClos(ed/ing) >> >> are both easier to read for me, shorter, and more in line with the naming >> convention for Pragma announcements already in Pharo. >> >> Cheers, >> Henry >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project All new Yahoo! Mail - Get a sneak peak at messages with a handy reading pane. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Henrik Sperre Johansen
Another possibility is to leave off the tense. What we should avoid is WindowMoved while there is still an opportunity to veto it; WindowMove would be (mercifully) neutral. I hesitate to mention that Object Arts went through a high-profile change on this some time back, and had very good reasons for their choices.
Bill -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Henrik Sperre Johansen Sent: Friday, January 08, 2010 4:26 PM To: [hidden email] Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus On 08.01.2010 21:37, Gary Chambers wrote: > If "after the fact" I'd vote for the "ed" suffix too. Make it match > what is/has happening/happened. > As a side note, WindowClosing is common to give a potential veto > chance (i.e. deny close). Should also be a WindowClosed if it does get that far... > > Regards, Gary > I suggest having both ...ing/...ed versions of close, move and resize, and ...ed for the rest, at least for now. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
I have to go now and I still do not have internet at home. I will work
on this on Monday. Cheers, Alexandre On 8 Jan 2010, at 17:19, Stéphane Ducasse wrote: > Alexandre > > as soon as we will got the names right publish, add a bug tracker > item and this will be integrated > now about the names > > Closing or Closed? > Collapsed? > WindowMoved? > > what is the convention? > when the event happens at the end I would prefer ed > when it occurs over a long action ing > > any english-oriented/design remarks? > ? > > >> >> Alexandre >> >> >> <Picture 3.png> >> >> >> On 8 Jan 2010, at 08:57, Henrik Johansen wrote: >> >>> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >>> >>>> Looks ok to me. >>>> >>>> Regards, Gary >>>> >>>> ----- Original Message ----- >>>> From: "Stéphane Ducasse" <[hidden email]> >>>> To: <[hidden email]> >>>> Sent: Thursday, January 07, 2010 8:27 PM >>>> Subject: Re: [Pharo-project] Notifications of windows opening/ >>>> closing/focus >>>> >>>> >>>>> >>>>>> Hi! >>>>>> >>>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>>> includes the window announcement I have been working on for few >>>>>> months >>>>>> already. >>>>>> >>>>>> Here is an example of a unit test. >>>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>>> >>>>>> | t window newWindowCreated r | >>>>>> t := 0. >>>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>>> t := t + 1. newWindowCreated := ann window]. >>>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann >>>>>> | t := >>>>>> t + 10. newWindowCreated := ann window]. >>> I don't particularly like the naming. >>> >>> - Why including Announcement at the end? >>> - Why does one contain a verb, and the other a >>> - When are they fired? Closing implies to me it's not been closed >>> yet, but fired somewhere after the closing has started, while >>> CreationWindow I have no idea what means. >>> >>> MorphicWindowOpen(ed/ing) >>> MorphicWindowClos(ed/ing) >>> >>> are both easier to read for me, shorter, and more in line with the >>> naming convention for Pragma announcements already in Pharo. >>> >>> Cheers, >>> Henry >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
Stef,
Will do. What is the difference between PharoInBox and PharoTaskForces? I see many references to them, but nothing that clarifies what to use when. Is there a way to get MC to save "part of" a package? Suppose I have DolphinCompatibilty-Streams DolphinCompatibilty-ODBC DolphinCompatibilty-FFI DolphinCompatibilty-Network ... and want to save just the FFI package. Is there a way to do that? I might have been going about it incorrectly, but I found the results to be unpredictable. It matters because I sometimes work under non-disclosure agreements, and it would be really bad to put relevant code in a public respository :( Bill -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse Sent: Friday, January 08, 2010 3:49 PM To: [hidden email] Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus On Jan 8, 2010, at 9:38 PM, Schwab,Wilhelm K wrote: > Stef, > > I find it difficult to imagine your being dull on anything, but I guess we all have limits. :) > I have been pushing a little firmly on weak collections because Squeak/Pharo are _way_ behind where Dolphin was 12+ years ago, and it seems avoidable. Yes I imagine well. > So far I have created very simple thread safe (hopefully) wrappers around Dictionary (SharedLookupTable) and Set. The dictionary can be weak in keys or values. I subclass from Object to minimize problems with super classes filling gaps w/o my knowledge. this is why I suggest you publish some code in the PharoTaskForces and get some arguments with others and we all learn :) _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
On 09.01.2010 02:53, Schwab,Wilhelm K wrote:
> Stef, > > Will do. What is the difference between PharoInBox and PharoTaskForces? I see many references to them, but nothing that clarifies what to use when. > PharoInbox is for fixes to issues on the issue tracker. PharoTaskForces is for work in progress, which others may want to load and have a look at. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Benoit St-Jean
would be good too.
Stef On Jan 8, 2010, at 10:27 PM, Benoit St-Jean wrote: > Why not something like : > > #aboutToClose and #closed ? > > > ----------------- > Benoit St-Jean > Yahoo! Messenger: bstjean > Blog: lamneth.wordpress.com > A standpoint is an intellectual horizon of radius zero. > (Albert Einstein) > > > From: Gary Chambers <[hidden email]> > To: [hidden email] > Sent: Fri, January 8, 2010 3:37:39 PM > Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus > > If "after the fact" I'd vote for the "ed" suffix too. Make it match what > is/has happening/happened. > As a side note, WindowClosing is common to give a potential veto chance > (i.e. deny close). Should also be a WindowClosed if it does get that far... > > Regards, Gary > > ----- Original Message ----- > From: "Stéphane Ducasse" <[hidden email]> > To: <[hidden email]> > Sent: Friday, January 08, 2010 8:19 PM > Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus > > > Alexandre > > as soon as we will got the names right publish, add a bug tracker item and > this will be integrated > now about the names > > Closing or Closed? > Collapsed? > WindowMoved? > > what is the convention? > when the event happens at the end I would prefer ed > when it occurs over a long action ing > > any english-oriented/design remarks? > ? > > > > > > Alexandre > > > > > > <Picture 3.png> > > > > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > > > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: > >> > >>> Looks ok to me. > >>> > >>> Regards, Gary > >>> > >>> ----- Original Message ----- > >>> From: "Stéphane Ducasse" <[hidden email]> > >>> To: <[hidden email]> > >>> Sent: Thursday, January 07, 2010 8:27 PM > >>> Subject: Re: [Pharo-project] Notifications of windows > >>> opening/closing/focus > >>> > >>> > >>>> > >>>>> Hi! > >>>>> > >>>>> In the PharoTaskForces SqueakSource repository I committed a new > >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version > >>>>> includes the window announcement I have been working on for few months > >>>>> already. > >>>>> > >>>>> Here is an example of a unit test. > >>>>> -=-=-=-=-=-=-=-=-=-=-=-= > >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion > >>>>> > >>>>> | t window newWindowCreated r | > >>>>> t := 0. > >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | > >>>>> t := t + 1. newWindowCreated := ann window]. > >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | t := > >>>>> t + 10. newWindowCreated := ann window]. > >> I don't particularly like the naming. > >> > >> - Why including Announcement at the end? > >> - Why does one contain a verb, and the other a > >> - When are they fired? Closing implies to me it's not been closed yet, > >> but fired somewhere after the closing has started, while CreationWindow I > >> have no idea what means. > >> > >> MorphicWindowOpen(ed/ing) > >> MorphicWindowClos(ed/ing) > >> > >> are both easier to read for me, shorter, and more in line with the naming > >> convention for Pragma announcements already in Pharo. > >> > >> Cheers, > >> Henry > >> _______________________________________________ > >> Pharo-project mailing list > >> [hidden email] > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >> > > > > -- > > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > > Alexandre Bergel http://www.bergel.eu > > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > > > > _______________________________________________ > > Pharo-project mailing list > > [hidden email] > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > All new Yahoo! Mail - Get a sneak peak at messages with a handy reading pane._______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Schwab,Wilhelm K
what was the words they used?
Stef On Jan 8, 2010, at 11:37 PM, Schwab,Wilhelm K wrote: > Another possibility is to leave off the tense. What we should avoid is WindowMoved while there is still an opportunity to veto it; WindowMove would be (mercifully) neutral. I hesitate to mention that Object Arts went through a high-profile change on this some time back, and had very good reasons for their choices. > > Bill > > > -----Original Message----- > From: [hidden email] [mailto:[hidden email]] On Behalf Of Henrik Sperre Johansen > Sent: Friday, January 08, 2010 4:26 PM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus > > On 08.01.2010 21:37, Gary Chambers wrote: >> If "after the fact" I'd vote for the "ed" suffix too. Make it match >> what is/has happening/happened. >> As a side note, WindowClosing is common to give a potential veto >> chance (i.e. deny close). Should also be a WindowClosed if it does get that far... >> >> Regards, Gary >> > I suggest having both ...ing/...ed versions of close, move and resize, and ...ed for the rest, at least for now. > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Stef,
It will be challenging to find the relevant discussion, though it is probably captured in Ian Bartholomew's news archives. IIRC, the fine points were about tense, just like here. When does digging into that archive turn into reverse engineering? It is a public forum, and the archives of the group have long been on Ian's site in plain view to all. Bill -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse Sent: Saturday, January 09, 2010 7:08 AM To: [hidden email] Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus what was the words they used? Stef On Jan 8, 2010, at 11:37 PM, Schwab,Wilhelm K wrote: > Another possibility is to leave off the tense. What we should avoid is WindowMoved while there is still an opportunity to veto it; WindowMove would be (mercifully) neutral. I hesitate to mention that Object Arts went through a high-profile change on this some time back, and had very good reasons for their choices. > > Bill > > > -----Original Message----- > From: [hidden email] > [mailto:[hidden email]] On Behalf Of > Henrik Sperre Johansen > Sent: Friday, January 08, 2010 4:26 PM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows > opening/closing/focus > > On 08.01.2010 21:37, Gary Chambers wrote: >> If "after the fact" I'd vote for the "ed" suffix too. Make it match >> what is/has happening/happened. >> As a side note, WindowClosing is common to give a potential veto >> chance (i.e. deny close). Should also be a WindowClosed if it does get that far... >> >> Regards, Gary >> > I suggest having both ...ing/...ed versions of close, move and resize, and ...ed for the rest, at least for now. > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
AFAICT from searching a few of the files, the events all have names
ending in past tense... Last example I found regarding window events was in the 2008sm05 file, where there's a reference to closeRequested:. For those actions allowing a veto, the naming convention thus seems to send off an (action)Requested before the action itself. I was unable to find the discussion mentioned in a reasonable amount of time. Cheers, Henry On 09.01.2010 17:15, Schwab,Wilhelm K wrote: > Stef, > > It will be challenging to find the relevant discussion, though it is probably captured in Ian Bartholomew's news archives. IIRC, the fine points were about tense, just like here. > > When does digging into that archive turn into reverse engineering? It is a public forum, and the archives of the group have long been on Ian's site in plain view to all. > > Bill > > > > -----Original Message----- > From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse > Sent: Saturday, January 09, 2010 7:08 AM > To: [hidden email] > Subject: Re: [Pharo-project] Notifications of windows opening/closing/focus > > what was the words they used? > > Stef > > On Jan 8, 2010, at 11:37 PM, Schwab,Wilhelm K wrote: > > >> Another possibility is to leave off the tense. What we should avoid is WindowMoved while there is still an opportunity to veto it; WindowMove would be (mercifully) neutral. I hesitate to mention that Object Arts went through a high-profile change on this some time back, and had very good reasons for their choices. >> >> Bill >> >> >> -----Original Message----- >> From: [hidden email] >> [mailto:[hidden email]] On Behalf Of >> Henrik Sperre Johansen >> Sent: Friday, January 08, 2010 4:26 PM >> To: [hidden email] >> Subject: Re: [Pharo-project] Notifications of windows >> opening/closing/focus >> >> On 08.01.2010 21:37, Gary Chambers wrote: >> >>> If "after the fact" I'd vote for the "ed" suffix too. Make it match >>> what is/has happening/happened. >>> As a side note, WindowClosing is common to give a potential veto >>> chance (i.e. deny close). Should also be a WindowClosed if it does get that far... >>> >>> Regards, Gary >>> >>> >> I suggest having both ...ing/...ed versions of close, move and resize, and ...ed for the rest, at least for now. >> >> Cheers, >> Henry >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
In reply to this post by Stéphane Ducasse
I renamed the classes according to the suggestion.
Morphic-Alexandre_Bergel.396 is now in PharoTaskForces. http://code.google.com/p/pharo/issues/detail?id=1785 Alexandre On 8 Jan 2010, at 17:19, Stéphane Ducasse wrote: > Alexandre > > as soon as we will got the names right publish, add a bug tracker > item and this will be integrated > now about the names > > Closing or Closed? > Collapsed? > WindowMoved? > > what is the convention? > when the event happens at the end I would prefer ed > when it occurs over a long action ing > > any english-oriented/design remarks? > ? > > >> >> Alexandre >> >> >> <Picture 3.png> >> >> >> On 8 Jan 2010, at 08:57, Henrik Johansen wrote: >> >>> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >>> >>>> Looks ok to me. >>>> >>>> Regards, Gary >>>> >>>> ----- Original Message ----- >>>> From: "Stéphane Ducasse" <[hidden email]> >>>> To: <[hidden email]> >>>> Sent: Thursday, January 07, 2010 8:27 PM >>>> Subject: Re: [Pharo-project] Notifications of windows opening/ >>>> closing/focus >>>> >>>> >>>>> >>>>>> Hi! >>>>>> >>>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>>> includes the window announcement I have been working on for few >>>>>> months >>>>>> already. >>>>>> >>>>>> Here is an example of a unit test. >>>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>>> >>>>>> | t window newWindowCreated r | >>>>>> t := 0. >>>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>>> t := t + 1. newWindowCreated := ann window]. >>>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann >>>>>> | t := >>>>>> t + 10. newWindowCreated := ann window]. >>> I don't particularly like the naming. >>> >>> - Why including Announcement at the end? >>> - Why does one contain a verb, and the other a >>> - When are they fired? Closing implies to me it's not been closed >>> yet, but fired somewhere after the closing has started, while >>> CreationWindow I have no idea what means. >>> >>> MorphicWindowOpen(ed/ing) >>> MorphicWindowClos(ed/ing) >>> >>> are both easier to read for me, shorter, and more in line with the >>> naming convention for Pragma announcements already in Pharo. >>> >>> Cheers, >>> Henry >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project Picture 3.png (140K) Download Attachment |
Free forum by Nabble | Edit this page |