OB contextual menu item 'method containing' broken: is it useful?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

OB contextual menu item 'method containing' broken: is it useful?

Simon Denier-3
In 1.1 RC4 (and before), when opening the contextual menu in the source pane, there is an option for 'method containing' among the search actions.

It's not clear what is is supposed to do. Is it the OB implementation of the 'method strings with it' action, which is also available?

Anyway, it is broken as it raises a DNU #allMethodsNoDoitsSelect:

--
 Simon




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: OB contextual menu item 'method containing' broken: is it useful?

Mariano Martinez Peck
Hi Simon. Can you open a bug ticket please?

Lukas, it seems very easy to fix. If you want you can commit this change:

OBSelectorNode >> methods
    methods ifNil:
            [methods := SystemNavigation default allMethodsSelect:
                            [:m |
                            m hasLiteralSuchThat:
                                    [:lit |
                                    lit isString and:
                                            [lit isSymbol not
                                                and: [lit includesSubstring: selector string caseSensitive: false]]]]].
    ^ methods collect: [:m | OBMethodNode on: m]



I only changed allMethodsNoDoitsSelect:  by  allMethodsSelect:

Cheers

mariano


On Tue, Jul 6, 2010 at 11:50 AM, Simon Denier <[hidden email]> wrote:
In 1.1 RC4 (and before), when opening the contextual menu in the source pane, there is an option for 'method containing' among the search actions.

It's not clear what is is supposed to do. Is it the OB implementation of the 'method strings with it' action, which is also available?

Anyway, it is broken as it raises a DNU #allMethodsNoDoitsSelect:

--
 Simon




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: OB contextual menu item 'method containing' broken: is it useful?

Lukas Renggli
If i remember correctly this is fixed and the bug is closed already a
while ago. Or is this something new?

Lukas

On Saturday, July 10, 2010, Mariano Martinez Peck <[hidden email]> wrote:

> Hi Simon. Can you open a bug ticket please?
>
> Lukas, it seems very easy to fix. If you want you can commit this change:
>
> OBSelectorNode >> methods
>     methods ifNil:
>             [methods := SystemNavigation default allMethodsSelect:
>                             [:m |
>                             m hasLiteralSuchThat:
>                                     [:lit |
>                                     lit isString and:
>                                             [lit isSymbol not
>                                                 and: [lit includesSubstring: selector string caseSensitive: false]]]]].
>     ^ methods collect: [:m | OBMethodNode on: m]
>
>
>
> I only changed allMethodsNoDoitsSelect:  by  allMethodsSelect:
>
> Cheers
>
> mariano
>
>
> On Tue, Jul 6, 2010 at 11:50 AM, Simon Denier <[hidden email]> wrote:
>
> In 1.1 RC4 (and before), when opening the contextual menu in the source pane, there is an option for 'method containing' among the search actions.
>
> It's not clear what is is supposed to do. Is it the OB implementation of the 'method strings with it' action, which is also available?
>
> Anyway, it is broken as it raises a DNU #allMethodsNoDoitsSelect:
>
> --
>  Simon
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: OB contextual menu item 'method containing' broken: is it useful?

Mariano Martinez Peck


On Sat, Jul 10, 2010 at 7:38 PM, Lukas Renggli <[hidden email]> wrote:
If i remember correctly this is fixed and the bug is closed already a
while ago. Or is this something new?

Ups...yes. Sorry, I didn't see you have already commited a fix in the repo. Sorry for the mess. Yes, it is fixed.

Thanks

Mariano
 

Lukas

On Saturday, July 10, 2010, Mariano Martinez Peck <[hidden email]> wrote:
> Hi Simon. Can you open a bug ticket please?
>
> Lukas, it seems very easy to fix. If you want you can commit this change:
>
> OBSelectorNode >> methods
>     methods ifNil:
>             [methods := SystemNavigation default allMethodsSelect:
>                             [:m |
>                             m hasLiteralSuchThat:
>                                     [:lit |
>                                     lit isString and:
>                                             [lit isSymbol not
>                                                 and: [lit includesSubstring: selector string caseSensitive: false]]]]].
>     ^ methods collect: [:m | OBMethodNode on: m]
>
>
>
> I only changed allMethodsNoDoitsSelect:  by  allMethodsSelect:
>
> Cheers
>
> mariano
>
>
> On Tue, Jul 6, 2010 at 11:50 AM, Simon Denier <[hidden email]> wrote:
>
> In 1.1 RC4 (and before), when opening the contextual menu in the source pane, there is an option for 'method containing' among the search actions.
>
> It's not clear what is is supposed to do. Is it the OB implementation of the 'method strings with it' action, which is also available?
>
> Anyway, it is broken as it raises a DNU #allMethodsNoDoitsSelect:
>
> --
>  Simon
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project