OB failing tests in Pharo 1.2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

OB failing tests in Pharo 1.2

Mariano Martinez Peck
Hi Lukas. I was checking the 4 failing tests in Pharo 1.2: http://code.google.com/p/pharo/issues/detail?id=3470

The problem seems related to the changes with the SmalltalkEditor/ParagraphEditor and friends. The tests fails because the instVar "message" is nil, because nobody call OBKeyBindingsTest >> browseIt: aSelector
nor its friends. This was called in Pharo 1.1 from OBTextMorphEditor  because it was a subclass of ParagraphEditor.

Now, I have no idea how to make it work in Pharo 1.2

Cheers

mariano
Reply | Threaded
Open this post in threaded view
|

Re: OB failing tests in Pharo 1.2

Lukas Renggli
> Hi Lukas. I was checking the 4 failing tests in Pharo 1.2:
> http://code.google.com/p/pharo/issues/detail?id=3470
>
> The problem seems related to the changes with the
> SmalltalkEditor/ParagraphEditor and friends. The tests fails because the
> instVar "message" is nil, because nobody call OBKeyBindingsTest >> browseIt:
> aSelector
> nor its friends. This was called in Pharo 1.1 from OBTextMorphEditor
> because it was a subclass of ParagraphEditor.
>
> Now, I have no idea how to make it work in Pharo 1.2

Yeah, me neither. OB-Morphic is totally broken and it cannot be
quickly fixed. The editor support has to be completely rewritten on
top of the new infrastructure to get a browser that properly works.

Lukas

--
Lukas Renggli
www.lukas-renggli.ch

Reply | Threaded
Open this post in threaded view
|

Re: OB failing tests in Pharo 1.2

Tudor Girba
That is not very encouraging :)

Cheers,
Doru


On 21 Jan 2011, at 15:43, Lukas Renggli wrote:

>> Hi Lukas. I was checking the 4 failing tests in Pharo 1.2:
>> http://code.google.com/p/pharo/issues/detail?id=3470
>>
>> The problem seems related to the changes with the
>> SmalltalkEditor/ParagraphEditor and friends. The tests fails because the
>> instVar "message" is nil, because nobody call OBKeyBindingsTest >> browseIt:
>> aSelector
>> nor its friends. This was called in Pharo 1.1 from OBTextMorphEditor
>> because it was a subclass of ParagraphEditor.
>>
>> Now, I have no idea how to make it work in Pharo 1.2
>
> Yeah, me neither. OB-Morphic is totally broken and it cannot be
> quickly fixed. The editor support has to be completely rewritten on
> top of the new infrastructure to get a browser that properly works.
>
> Lukas
>
> --
> Lukas Renggli
> www.lukas-renggli.ch
>

--
www.tudorgirba.com

"Next time you see your life passing by, say 'hi' and get to know her."




Reply | Threaded
Open this post in threaded view
|

Re: OB failing tests in Pharo 1.2

Lukas Renggli
On Friday, 21 January 2011, Tudor Girba <[hidden email]> wrote:
> That is not very encouraging :)

Indeed. Probably somebody can figure out a patch that fixes some more
of the regressions. But this will never fix the problem that the code
builds on top of the old infrastructure delegating to the new
infrastructure.

Some time ago I started to reimplement the OB editor on top of the new
editor, but that is just the first day of work of the estimated week:
source.lukas-renggli.ch/pharo12.

Lukas

>
> Cheers,
> Doru
>
>
> On 21 Jan 2011, at 15:43, Lukas Renggli wrote:
>
>>> Hi Lukas. I was checking the 4 failing tests in Pharo 1.2:
>>> http://code.google.com/p/pharo/issues/detail?id=3470
>>>
>>> The problem seems related to the changes with the
>>> SmalltalkEditor/ParagraphEditor and friends. The tests fails because the
>>> instVar "message" is nil, because nobody call OBKeyBindingsTest >> browseIt:
>>> aSelector
>>> nor its friends. This was called in Pharo 1.1 from OBTextMorphEditor
>>> because it was a subclass of ParagraphEditor.
>>>
>>> Now, I have no idea how to make it work in Pharo 1.2
>>
>> Yeah, me neither. OB-Morphic is totally broken and it cannot be
>> quickly fixed. The editor support has to be completely rewritten on
>> top of the new infrastructure to get a browser that properly works.
>>
>> Lukas
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>
> --
> www.tudorgirba.com
>
> "Next time you see your life passing by, say 'hi' and get to know her."
>
>
>
>
>

--
Lukas Renggli
www.lukas-renggli.ch