OCompletion in the rc1 dev image

> Hi list,
>
> in the most recent dev image (9.10.5), OCompletion is broken for me.
>
> I lost my reproducible test case, but the gist was that sometimes when
> OCompletion had no idea which type a temporal variable would be, you
> were unable to insert code behind that variable, because if you tried,
> a debugger would show up.
>
> The problem appears to be Debugger>guessTypeForName:. debuggerMap can
> be nil and if it is, the method fails. I changed the method to the
> following, and then the strange errors that occur on my image
> disappear:
>
> guessTypeForName: aString
> | index object |
> index := debuggerMap ifNotNil: [(debuggerMap tempNamesForContext:
> self selectedContext)
> indexOf: aString
> ifAbsent: []].
> object := index
> ifNil: [index := self receiver class allInstVarNames
> indexOf: aString
> ifAbsent: [].
> index ifNil: [^ nil].
> self receiver instVarAt: index]
> ifNotNil: [self selectedContext tempAt: index].
> ^ object class
>
> Essentially, I leave index at nil, if debugerMap is nil.
>
> I don't know enough about OCompletion to tell whether this is a fix,
> or makes things worse somehow.
>
> Cheers,
>
> Niko
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

> Niko,
>
> What is the version of OCompletion in the image?
>
> I thought the fix in Ocompletion-RomainRobbes.36.mcz solved that issue.
> If you are indeed using that version, I'll have a look at your fix.
> Otherwise, it is just a matter of time before the
> latest version of OCompletion is used instead of the older one.
>
> Cheers,
>        Romain
>
> On Oct 27, 2009, at 3:07 PM, Niko Schwarz wrote:
>
>> Hi list,
>>
>> in the most recent dev image (9.10.5), OCompletion is broken for me.
>>
>> I lost my reproducible test case, but the gist was that sometimes when
>> OCompletion had no idea which type a temporal variable would be, you
>> were unable to insert code behind that variable, because if you tried,
>> a debugger would show up.
>>
>> The problem appears to be Debugger>guessTypeForName:. debuggerMap can
>> be nil and if it is, the method fails. I changed the method to the
>> following, and then the strange errors that occur on my image
>> disappear:
>>
>> guessTypeForName: aString
>>       | index object |
>>       index := debuggerMap ifNotNil: [(debuggerMap tempNamesForContext:
>> self selectedContext)
>>                               indexOf: aString
>>                               ifAbsent: []].
>>       object := index
>>                               ifNil: [index := self receiver class allInstVarNames
>>                                                               indexOf: aString
>>                                                               ifAbsent: [].
>>                                               index ifNil: [^ nil].
>>                                       self receiver instVarAt: index]
>>                               ifNotNil: [self selectedContext tempAt: index].
>>       ^ object class
>>
>> Essentially, I leave index at nil, if debugerMap is nil.
>>
>> I don't know enough about OCompletion to tell whether this is a fix,
>> or makes things worse somehow.
>>
>> Cheers,
>>
>> Niko
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> --
> Romain Robbes
> http://www.inf.unisi.ch/phd/robbes
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

> My image is indeed still on version damiencassou.33. I marked the bug
> as 1.0 in the bugtracker
> (http://code.google.com/p/pharo/issues/detail?id=1351) hoping that it
> will be integrated in the next 1.0 dev image, as the image is hardly
> usable without the fix.
>
> Cheers,
>
> Niko
>
> On Tue, Oct 27, 2009 at 3:18 PM, Romain Robbes
> <[hidden email]> wrote:
>> Niko,
>>
>> What is the version of OCompletion in the image?
>>
>> I thought the fix in Ocompletion-RomainRobbes.36.mcz solved that issue.
>> If you are indeed using that version, I'll have a look at your fix.
>> Otherwise, it is just a matter of time before the
>> latest version of OCompletion is used instead of the older one.
>>
>> Cheers,
>>        Romain
>>
>> On Oct 27, 2009, at 3:07 PM, Niko Schwarz wrote:
>>
>>> Hi list,
>>>
>>> in the most recent dev image (9.10.5), OCompletion is broken for me.
>>>
>>> I lost my reproducible test case, but the gist was that sometimes when
>>> OCompletion had no idea which type a temporal variable would be, you
>>> were unable to insert code behind that variable, because if you tried,
>>> a debugger would show up.
>>>
>>> The problem appears to be Debugger>guessTypeForName:. debuggerMap can
>>> be nil and if it is, the method fails. I changed the method to the
>>> following, and then the strange errors that occur on my image
>>> disappear:
>>>
>>> guessTypeForName: aString
>>>       | index object |
>>>       index := debuggerMap ifNotNil: [(debuggerMap tempNamesForContext:
>>> self selectedContext)
>>>                               indexOf: aString
>>>                               ifAbsent: []].
>>>       object := index
>>>                               ifNil: [index := self receiver class allInstVarNames
>>>                                                               indexOf: aString
>>>                                                               ifAbsent: [].
>>>                                               index ifNil: [^ nil].
>>>                                       self receiver instVarAt: index]
>>>                               ifNotNil: [self selectedContext tempAt: index].
>>>       ^ object class
>>>
>>> Essentially, I leave index at nil, if debugerMap is nil.
>>>
>>> I don't know enough about OCompletion to tell whether this is a fix,
>>> or makes things worse somehow.
>>>
>>> Cheers,
>>>
>>> Niko
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> --
>> Romain Robbes
>> http://www.inf.unisi.ch/phd/robbes
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>

> By the way, what is the proper way to propose changes to the dev  
> image script?
>
> On Tue, Oct 27, 2009 at 3:57 PM, Niko Schwarz
> <[hidden email]> wrote:
>> My image is indeed still on version damiencassou.33. I marked the bug
>> as 1.0 in the bugtracker
>> (http://code.google.com/p/pharo/issues/detail?id=1351) hoping that it
>> will be integrated in the next 1.0 dev image, as the image is hardly
>> usable without the fix.
>>
>> Cheers,
>>
>> Niko
>>
>> On Tue, Oct 27, 2009 at 3:18 PM, Romain Robbes
>> <[hidden email]> wrote:
>>> Niko,
>>>
>>> What is the version of OCompletion in the image?
>>>
>>> I thought the fix in Ocompletion-RomainRobbes.36.mcz solved that  
>>> issue.
>>> If you are indeed using that version, I'll have a look at your fix.
>>> Otherwise, it is just a matter of time before the
>>> latest version of OCompletion is used instead of the older one.
>>>
>>> Cheers,
>>>        Romain
>>>
>>> On Oct 27, 2009, at 3:07 PM, Niko Schwarz wrote:
>>>
>>>> Hi list,
>>>>
>>>> in the most recent dev image (9.10.5), OCompletion is broken for  
>>>> me.
>>>>
>>>> I lost my reproducible test case, but the gist was that sometimes  
>>>> when
>>>> OCompletion had no idea which type a temporal variable would be,  
>>>> you
>>>> were unable to insert code behind that variable, because if you  
>>>> tried,
>>>> a debugger would show up.
>>>>
>>>> The problem appears to be Debugger>guessTypeForName:. debuggerMap  
>>>> can
>>>> be nil and if it is, the method fails. I changed the method to the
>>>> following, and then the strange errors that occur on my image
>>>> disappear:
>>>>
>>>> guessTypeForName: aString
>>>>       | index object |
>>>>       index := debuggerMap ifNotNil: [(debuggerMap  
>>>> tempNamesForContext:
>>>> self selectedContext)
>>>>                               indexOf: aString
>>>>                               ifAbsent: []].
>>>>       object := index
>>>>                               ifNil: [index := self receiver  
>>>> class allInstVarNames
>>>>                                                                
>>>> indexOf: aString
>>>>                                                                
>>>> ifAbsent: [].
>>>>                                               index ifNil: [^ nil].
>>>>                                       self receiver instVarAt:  
>>>> index]
>>>>                               ifNotNil: [self selectedContext  
>>>> tempAt: index].
>>>>       ^ object class
>>>>
>>>> Essentially, I leave index at nil, if debugerMap is nil.
>>>>
>>>> I don't know enough about OCompletion to tell whether this is a  
>>>> fix,
>>>> or makes things worse somehow.
>>>>
>>>> Cheers,
>>>>
>>>> Niko
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>> --
>>> Romain Robbes
>>> http://www.inf.unisi.ch/phd/robbes
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project