Oh, patches!

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Oh, patches!

Eli Green-3
I totally forgot that the HEAD won't compile on OS X without a few changes:

I haven't run the test suite but autoconf on OS X is 2.61 so I punted on the prerequisites and just changed the number. I'm surprised anybody can compile without multiple defined symbols right now without adding extern to the _gst_sem_int_vec declaration...

diff --git a/configure.ac b/configure.ac
index 056e1cc..0fa210d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,8 +6,8 @@ dnl Please see COPYING for a description your rights and respons
 dnl with this software.
 dnl Process this file with autoconf to produce a configure script.
 
-dnl 2.63 needed by testsuite, actually
-AC_PREREQ(2.63)
+dnl 2.61 needed by testsuite, actually
+AC_PREREQ(2.61)
 AC_INIT([GNU Smalltalk], 3.1, [hidden email], smalltalk)
 MAINTAINER="[hidden email]"
 
diff --git a/libgst/events.h b/libgst/events.h
index d6835fa..5772938 100644
--- a/libgst/events.h
+++ b/libgst/events.h
@@ -54,7 +54,7 @@
 #define GST_EVENTS_H
 
 /* Array of semaphores associated to the C signals.  */
-volatile OOP _gst_sem_int_vec[NSIG];
+extern volatile OOP _gst_sem_int_vec[NSIG];
 
 /* Initialize the data structures used to hold information about
    asynchronous events requested by Smalltalk programs.  */


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Oh, patches!

Paolo Bonzini-2

> I'm surprised anybody can compile without multiple defined symbols right now without adding extern to the _gst_sem_int_vec declaration...

I applied your patch.  The reason everybody can compile is that multiply
defined symbols are only fatal under OS X.

I don't recall the reason why I bumped the prerequisite to 2.63, it's
probably in the archives.  I'll leave it as is since it's not a big
problem for releases or if you install Autoconf on your own.

Thanks.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk