Smalltalk › Squeak › Squeak - Dev

Old morphs failing to load in 5.2

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Edgar De Cleene

Old morphs failing to load in 5.2

http://squeakros.org/5dot2Crashes/Screen%20Shot%202018-05-27%20at%2007.56.47.png

Here you could see side by side n 3.10 and in Squeak5.2alpha-18019-64bit-All-in-One.app.

I wish have some like this in 5.2 so all could see what is new , fixed, etc Squeak style

my SystemWindow.morph (204K) Download Attachment

Karl Ramberg

Re: Old morphs failing to load in 5.2

Hi,

Here is a small changeset that stubs out the two sends to IconicButton

Best,

Karl

On Sun, May 27, 2018 at 1:01 PM, Edgar De Cleene <[hidden email]> wrote:

http://squeakros.org/5dot2Crashes/Screen%20Shot%202018-05-27%20at%2007.56.47.png

Here you could see side by side n 3.10 and in Squeak5.2alpha-18019-64bit-All-in-One.app.
I wish have some like this in 5.2 so all could see what is new , fixed, etc Squeak style

iconicButtonCompability.1.cs (1K) Download Attachment

Hannes Hirzel

Re: Old morphs failing to load in 5.2

Hi Karl

Yes, this makes it work if you drop aSystemWindow.morph (from Squeak 3.10.2).

But the SystemWindow is old style. And it also has other issues (see
screen shot).

I rather would prefer to see that a new SystemWindow instance is created
with the text content of the loaded one inserted.

--Hannes

On 5/28/18, karl ramberg <[hidden email]> wrote:

> Hi,
> Here is a small changeset that stubs out the two sends to IconicButton
>
> Best,
> Karl
>
>
> On Sun, May 27, 2018 at 1:01 PM, Edgar De Cleene <[hidden email]>
> wrote:
>
>> <a href="http://squeakros.org/5dot2Crashes/Screen%20Shot%">http://squeakros.org/5dot2Crashes/Screen%20Shot%
>> 202018-05-27%20at%2007.56.47.png
>>
>> Here you could see side by side n 3.10 and in Squeak5.2alpha-18019-64bit-
>> All-in-One.app.
>> I wish have some like this in 5.2 so all could see what is new , fixed,
>> etc Squeak style
>>
>

mySystemWindowFrom3dot10dot2.morph (28K) Download Attachment

Loading_a_SystemWindow_morph_from_Squeak3.10.2_into_Squeak5.2a_2018-05-28.png (38K) Download Attachment

Edgar De Cleene

Re: Old morphs failing to load in 5.2

In reply to this post by Karl Ramberg

Re: Old morphs failing to load in 5.2 You read my mind, is what I think.
If nobody is against or have some better, could bo to 5.2

On 28/05/2018, 15:07, "karl ramberg" <[hidden email]> wrote:

Hi,
Here is a small changeset that stubs out the two sends to IconicButton

Best,
Karl

marcel.taeumel

Re: Old morphs failing to load in 5.2

The window updates to the current UI theme via "UserInterfaceTheme current apply."

Best,

Marcel

Am 28.05.2018 21:40:25 schrieb Edgar J. De Cleene <[hidden email]>:
You read my mind, is what I think.
If nobody is against or have some better, could bo to 5.2

On 28/05/2018, 15:07, "karl ramberg" <[hidden email]> wrote:

Hi,
Here is a small changeset that stubs out the two sends to IconicButton

Best,
Karl

Hannes Hirzel

Re: Old morphs failing to load in 5.2

I just re-did the test

No success for

UserInterfaceTheme current apply.

But changing the theme to a different one had a _partial success_. The
colors were changed but the buttons remained the same.

RESULT: see screen shot

Have a nice day!

Hannes

On 5/29/18, Marcel Taeumel <[hidden email]> wrote:

> The window updates to the current UI theme via "UserInterfaceTheme current
> apply."
>
> Best,
> Marcel
> Am 28.05.2018 21:40:25 schrieb Edgar J. De Cleene <[hidden email]>:
> You read my mind, is what I think.
> If nobody is against or have some better, could bo to 5.2
>
>
> On 28/05/2018, 15:07, "karl ramberg" <[hidden email]> wrote:
>
>
> Hi,
> Here is a small changeset that stubs out the two sends to IconicButton
>
> Best,
> Karl
>

Test_result_Loading_a_SystemWindow.morph_from_Sq3.10.2_into_Sq5.2a_Screenshot_2018-05-29.png (133K) Download Attachment

Hannes Hirzel

Re: Old morphs failing to load in 5.2

For practical work, that load a Workspace window with formatted text
from an earlier version of Squeak into Sq5.2 this solution is good
enough.

The question though is how to handle the change set done by Karl ....

On 5/29/18, H. Hirzel <[hidden email]> wrote:

> I just re-did the test
>
> No success for
>
> UserInterfaceTheme current apply.
>
> But changing the theme to a different one had a _partial success_. The
> colors were changed but the buttons remained the same.
>
> RESULT: see screen shot
>
> Have a nice day!
>
> Hannes
>
> On 5/29/18, Marcel Taeumel <[hidden email]> wrote:
>> The window updates to the current UI theme via "UserInterfaceTheme
>> current
>> apply."
>>
>> Best,
>> Marcel
>> Am 28.05.2018 21:40:25 schrieb Edgar J. De Cleene
>> <[hidden email]>:
>> You read my mind, is what I think.
>> If nobody is against or have some better, could bo to 5.2
>>
>>
>> On 28/05/2018, 15:07, "karl ramberg" <[hidden email]> wrote:
>>
>>
>> Hi,
>> Here is a small changeset that stubs out the two sends to IconicButton
>>
>> Best,
>> Karl
>>
>

marcel.taeumel

Re: Old morphs failing to load in 5.2

I just added those to Trunk. Maybe we need dim/undim for buttons in general? Not sure...

Best,

Marcel

Am 31.05.2018 11:02:23 schrieb H. Hirzel <[hidden email]>:
For practical work, that load a Workspace window with formatted text
from an earlier version of Squeak into Sq5.2 this solution is good
enough.

The question though is how to handle the change set done by Karl ....

On 5/29/18, H. Hirzel wrote:
> I just re-did the test
>
> No success for
>
> UserInterfaceTheme current apply.
>
> But changing the theme to a different one had a _partial success_. The
> colors were changed but the buttons remained the same.
>
> RESULT: see screen shot
>
> Have a nice day!
>
> Hannes
>
> On 5/29/18, Marcel Taeumel wrote:
>> The window updates to the current UI theme via "UserInterfaceTheme
>> current
>> apply."
>>
>> Best,
>> Marcel
>> Am 28.05.2018 21:40:25 schrieb Edgar J. De Cleene
>> :
>> You read my mind, is what I think.
>> If nobody is against or have some better, could bo to 5.2
>>
>>
>> On 28/05/2018, 15:07, "karl ramberg" wrote:
>>
>>
>> Hi,
>> Here is a small changeset that stubs out the two sends to IconicButton
>>
>> Best,
>> Karl
>>
>

Edgar De Cleene

Re: Old morphs failing to load in 5.2

Re: [squeak-dev] Old morphs failing to load in 5.2 Maybe not, as in past we don’t have.
But is better have one partial solution.
So thanks to Karl to made it .

Edgar
@morplenauta

On 31/05/2018, 06:06, "Marcel Taeumel" <[hidden email]> wrote:

I just added those to Trunk. Maybe we need dim/undim for buttons in general? Not sure...

Best,
Marcel

Hannes Hirzel

Re: Old morphs failing to load in 5.2

Yes, the workspace as it is now allows to get the _text content_ from
an earlier image.

But it is not formatted nicely.

There is probably a need for a script which runs after the import
which fixes issues such as replacing the IconicButton with a
SystemWindowButton.

Not sure how to handle the text. The workspace from an earlier version
has PluggableText whereas a new workspace in 5.2 has
PluggableTextMorphPlus.

--Hannes

On 5/31/18, Edgar J. De Cleene <[hidden email]> wrote:

> Maybe not, as in past we don¹t have.
> But is better have one partial solution.
> So thanks to Karl to made it .
>
>
> Edgar
> @morplenauta
>
>
>
> On 31/05/2018, 06:06, "Marcel Taeumel" <[hidden email]> wrote:
>
>> I just added those to Trunk. Maybe we need dim/undim for buttons in
>> general?
>> Not sure...
>>
>> Best,
>> Marcel
>
>

Workspace_Imported_Screenshot_2018-06-13.png (33K) Download Attachment

PluggableText_in_old_imported_workspace_Screenshot_2018-06-13.png (50K) Download Attachment

PluggableTextMorphPlus_in_Sq5.2_workspace_2018-06-13.png (58K) Download Attachment