[OpenSmalltalk/opensmalltalk-vm] 005088: sqFileAtEnd() revert to previous error checking

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 005088: sqFileAtEnd() revert to previous error checking

GitHub
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 005088c20880b62d6c0c8d033b0c993f56ddb02b
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/005088c20880b62d6c0c8d033b0c993f56ddb02b
  Author: AlistairGrant <[hidden email]>
  Date:   2018-04-09 (Mon, 09 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  sqFileAtEnd() revert to previous error checking

sqFileAtEnd() hasn't done any error checking.  However adding it has
caused a report of primitive failures where previously none occurred.
No information is given about what the error is (errno isn't set), and
because no other functions are doing error checking we can't know how
far back the error occurred.
We can't limit error checking to this call because clearerr() clears not
only the error flag, but also the end-of-file flag.


  Commit: 1c160137b712cd36d26dbe5ef043989a4545dd5d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c160137b712cd36d26dbe5ef043989a4545dd5d
  Author: akgrant43 <[hidden email]>
  Date:   2018-04-10 (Tue, 10 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  Merge pull request #245 from akgrant43/AtEndMkIII

sqFileAtEnd() revert to previous error checking


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/6bee4d2946da...1c160137b712
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 005088: sqFileAtEnd() revert to previous error checking

Eliot Miranda-2
 
Hi Alistair,

   thank you!  The REPL works perfectly again (on Mac OS X).

On Mon, Apr 9, 2018 at 10:27 PM, GitHub <[hidden email]> wrote:
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 005088c20880b62d6c0c8d033b0c993f56ddb02b
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/005088c20880b62d6c0c8d033b0c993f56ddb02b
  Author: AlistairGrant <[hidden email]>
  Date:   2018-04-09 (Mon, 09 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  sqFileAtEnd() revert to previous error checking

sqFileAtEnd() hasn't done any error checking.  However adding it has
caused a report of primitive failures where previously none occurred.
No information is given about what the error is (errno isn't set), and
because no other functions are doing error checking we can't know how
far back the error occurred.
We can't limit error checking to this call because clearerr() clears not
only the error flag, but also the end-of-file flag.


  Commit: 1c160137b712cd36d26dbe5ef043989a4545dd5d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c160137b712cd36d26dbe5ef043989a4545dd5d
  Author: akgrant43 <[hidden email]>
  Date:   2018-04-10 (Tue, 10 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  Merge pull request #245 from akgrant43/AtEndMkIII

sqFileAtEnd() revert to previous error checking


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/6bee4d2946da...1c160137b712



--
_,,,^..^,,,_
best, Eliot