[OpenSmalltalk/opensmalltalk-vm] 0409c3: GetFileAttributesExW() workaround

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 0409c3: GetFileAttributesExW() workaround

Tobias Pape-4
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 0409c34c26b31f1b7ff6b9c6cf8fcfad114cbf41
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0409c34c26b31f1b7ff6b9c6cf8fcfad114cbf41
  Author: Alistair Grant <[hidden email]>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M platforms/win32/plugins/FileAttributesPlugin/faSupport.c
    M platforms/win32/plugins/FileAttributesPlugin/faSupport.h

  Log Message:
  -----------
  GetFileAttributesExW() workaround

If GetFileAttributesExW() fails with a sharing violation, try again
using FindFirstFileW().

GetFileAttributesExW() is known to fail for junction files and others
such as pagefile.sys, see e.g.:

https://github.com/golang/go/commit/d13fa4d2256d6dfd030c03a82db258872e3e646c
https://bugs.ruby-lang.org/issues/6845

Addresses: https://github.com/pharo-project/pharo/issues/3571


  Commit: 021fc79c1bc5ff70bc03f49318690772ba9f44cf
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/021fc79c1bc5ff70bc03f49318690772ba9f44cf
  Author: Alistair Grant <[hidden email]>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c

  Log Message:
  -----------
  FileAttributesPlugin 2.0.9

GetFileAttributesExW() workaround

If GetFileAttributesExW() fails with a sharing violation, try again using FindFirstFileW().

GetFileAttributesExW() is known to fail for junction files and others such as pagefile.sys, see e.g.:

https://github.com/golang/go/commit/d13fa4d2256d6dfd030c03a82db258872e3e646c
https://bugs.ruby-lang.org/issues/6845

See commit: 0409c34c26b31f1b7ff6b9c6cf8fcfad114cbf41

Addresses: https://github.com/pharo-project/pharo/issues/3571


  Commit: 4868d1e8e452ed6b461987182b4418a88712e32f
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4868d1e8e452ed6b461987182b4418a88712e32f
  Author: Alistair Grant <[hidden email]>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M build.macos64x64/gdbarm64/conf.COG
    M platforms/Cross/plugins/SqueakFFIPrims/sqFFITestFuncs.c
    M platforms/Cross/vm/sq.h
    M platforms/Cross/vm/sqCogStackAlignment.h
    M platforms/Mac OS/vm/sqMacMemory.c
    M platforms/iOS/vm/Common/sqMacV2Memory.c
    M platforms/minheadless/unix/sqPlatformSpecific-Unix.h
    M platforms/minheadless/unix/sqUnixMemory.c
    M platforms/minheadless/unix/sqUnixSpurMemory.c
    M platforms/minheadless/windows/sqPlatformSpecific-Win32.h
    M platforms/minheadless/windows/sqWin32Alloc.c
    M platforms/minheadless/windows/sqWin32SpurAlloc.c
    M platforms/unix/vm/sqUnixMain.c
    M platforms/unix/vm/sqUnixMemory.c
    M platforms/unix/vm/sqUnixSpurMemory.c
    M platforms/win32/vm/sqPlatformSpecific.h
    M platforms/win32/vm/sqWin32Alloc.c
    M platforms/win32/vm/sqWin32SpurAlloc.c
    M platforms/win32/vm/sqWin32Window.c
    M processors/ARM/gdb-8.3.1/sim/aarch64/cpustate.c
    M processors/ARM/gdb-8.3.1/sim/aarch64/cpustate.h
    M processors/ARM/gdb-8.3.1/sim/aarch64/simulator.c
    M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c
    M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c
    M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c
    M src/plugins/SqueakFFIPrims/SqueakFFIPrims.c
    M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c
    M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c

  Log Message:
  -----------
  Merge remote-tracking branch 'osvm/Cog' into Issue3571


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/bd898a75d5b0...4868d1e8e452