[OpenSmalltalk/opensmalltalk-vm] 128b46: MacOS X does support the tcsetattr serial port sup...

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[OpenSmalltalk/opensmalltalk-vm] 128b46: MacOS X does support the tcsetattr serial port sup...

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 128b467faf11cc491671e92b578edd0453827aab
  Author: Eliot Miranda <[hidden email]>
  Date:   2018-12-02 (Sun, 02 Dec 2018)

  Changed paths:
    A platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c
    M platforms/iOS/plugins/SerialPlugin/Makefile
    R platforms/iOS/plugins/SerialPlugin/sqMacSerialPort.c
    M platforms/unix/plugins/SerialPlugin/sqUnixSerial.c

  Log Message:
  MacOS X does support the tcsetattr serial port support supposed by
sqUnixSerial.c.  So instead of using the null support that was in
sqMacSerialPort.c, update the Mac builds to use sqUnixSerial.c, and
rename the mac's file to platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c

THIS IS UNTESTED!  In  particular the code in sqUnixSerial.c (dubiously IMO)
does not use serialPortBaseName, and instead makes an assumption that
serial ports are as defined by serialPortBaseNameDefault, i.e. are in the range
/dev/tty50 to /dev/tty59.  It would be great if
a) someone tested the code on MacOS X
b) the naming convention were better.
On Mac OS X (see e.g. https://software.intel.com/en-us/setting-up-serial-terminal-on-system-with-mac-os-x),
the serial ports are /dev/tty.NAME., e.g. /dev/cu.Bluetooth-Incoming-Port,
/dev/cu.BoseQuietControl30-SPPD, etc.

      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.