[OpenSmalltalk/opensmalltalk-vm] 24bea9: Fix compilation of SoundPlugin on Windows

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 24bea9: Fix compilation of SoundPlugin on Windows

Eliot Miranda-3
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 24bea92739c825b642bf8dc60690ef48df23503d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/24bea92739c825b642bf8dc60690ef48df23503d
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c

  Log Message:
  -----------
  Fix compilation of SoundPlugin on Windows

interpreterProxy must be defined before used!


  Commit: 235b21415025322f336f2df59addc4fb9c804869
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/235b21415025322f336f2df59addc4fb9c804869
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c

  Log Message:
  -----------
  Fix compilation warning void function returning a value


  Commit: 9c10bf5278167f890d04a06bcfe49981ef17d7db
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c10bf5278167f890d04a06bcfe49981ef17d7db
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c

  Log Message:
  -----------
  Fix getsockopt for MSVC

the len parameter must be a socket_len because it is a size_t on linux/cygwin (thus 64 bits) and int on MSVC (thus 32 bits)


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fb29a2325113...9c10bf527816
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 24bea9: Fix compilation of SoundPlugin on Windows

Nicolas Cellier
 
Green again, at least on windows/appveyor. I like green :)
Not yet the case on travis, for several reasons ...

Having red builds for long period is like not having continuous integration.
I'd say it's more like continuous desintegration with slowly but surely rotting artefacts.
In more strict organizations, you could not even pull a red build...

2017-05-23 21:46 GMT+02:00 GitHub <[hidden email]>:
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 24bea92739c825b642bf8dc60690ef48df23503d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/24bea92739c825b642bf8dc60690ef48df23503d
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c

  Log Message:
  -----------
  Fix compilation of SoundPlugin on Windows

interpreterProxy must be defined before used!


  Commit: 235b21415025322f336f2df59addc4fb9c804869
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/235b21415025322f336f2df59addc4fb9c804869
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c

  Log Message:
  -----------
  Fix compilation warning void function returning a value


  Commit: 9c10bf5278167f890d04a06bcfe49981ef17d7db
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c10bf5278167f890d04a06bcfe49981ef17d7db
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-05-23 (Tue, 23 May 2017)

  Changed paths:
    M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c

  Log Message:
  -----------
  Fix getsockopt for MSVC

the len parameter must be a socket_len because it is a size_t on linux/cygwin (thus 64 bits) and int on MSVC (thus 32 bits)


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fb29a2325113...9c10bf527816