[OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

GitHub
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 3e4db144896baceb78e276986cf85a0a53da542a
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78e276986cf85a0a53da542a
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-12-10 (Sun, 10 Dec 2017)

  Changed paths:
    M platforms/unix/vm/sqUnixMain.c

  Log Message:
  -----------
  include sys/ucontext.h unconditionally in sqUnixMain.c

Also give a prototype to isdigit and toupper (thru ctype.h).


Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Christian Kellermann
 
* GitHub <[hidden email]> [171210 15:45]:
>  

>   Branch: refs/heads/Cog
>   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>   Commit: 3e4db144896baceb78e276986cf85a0a53da542a
>       https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78e276986cf85a0a53da542a
>   Author: Nicolas Cellier <[hidden email]>
>   Date:   2017-12-10 (Sun, 10 Dec 2017)
>
>   Changed paths:
>     M platforms/unix/vm/sqUnixMain.c
>
>   Log Message:
>   -----------
>   include sys/ucontext.h unconditionally in sqUnixMain.c
>
> Also give a prototype to isdigit and toupper (thru ctype.h).

Sorry for catching this too late. There is no sys/ucontext.h on
OpenBSD. Can we at least wrap this in a ifndef __OpenBSD__ please?

Thanks,

Christian

--
May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Tobias Pape
 

> On 10.12.2017, at 22:03, Christian Kellermann <[hidden email]> wrote:
>
>
> * GitHub <[hidden email]> [171210 15:45]:
>>
>
>>  Branch: refs/heads/Cog
>>  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>>  Commit: 3e4db144896baceb78e276986cf85a0a53da542a
>>      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78e276986cf85a0a53da542a
>>  Author: Nicolas Cellier <[hidden email]>
>>  Date:   2017-12-10 (Sun, 10 Dec 2017)
>>
>>  Changed paths:
>>    M platforms/unix/vm/sqUnixMain.c
>>
>>  Log Message:
>>  -----------
>>  include sys/ucontext.h unconditionally in sqUnixMain.c
>>
>> Also give a prototype to isdigit and toupper (thru ctype.h).
>
> Sorry for catching this too late. There is no sys/ucontext.h on
> OpenBSD. Can we at least wrap this in a ifndef __OpenBSD__ please?

what about ucontext.h?
>
> Thanks,
>
> Christian
>
> --
> May you be peaceful, may you live in safety, may you be free from
> suffering, and may you live with ease.

Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Christian Kellermann
 
* Tobias Pape <[hidden email]> [171210 22:30]:

>  
>
> > On 10.12.2017, at 22:03, Christian Kellermann <[hidden email]> wrote:
> >
> >
> > * GitHub <[hidden email]> [171210 15:45]:
> >>
> >
> >>  Branch: refs/heads/Cog
> >>  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
> >>  Commit: 3e4db144896baceb78e276986cf85a0a53da542a
> >>      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78e276986cf85a0a53da542a
> >>  Author: Nicolas Cellier <[hidden email]>
> >>  Date:   2017-12-10 (Sun, 10 Dec 2017)
> >>
> >>  Changed paths:
> >>    M platforms/unix/vm/sqUnixMain.c
> >>
> >>  Log Message:
> >>  -----------
> >>  include sys/ucontext.h unconditionally in sqUnixMain.c
> >>
> >> Also give a prototype to isdigit and toupper (thru ctype.h).
> >
> > Sorry for catching this too late. There is no sys/ucontext.h on
> > OpenBSD. Can we at least wrap this in a ifndef __OpenBSD__ please?
>
> what about ucontext.h?

There is no uc_mcontext, ucontext_t lives in <signal.h> and is a
typedef for struct sigcontext. Why is this needed exactly? I could
compile the VM before without issues

Cheers,

Christian

--
May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Eliot Miranda-2
 
Hi Christian,



> On Dec 10, 2017, at 1:32 PM, Christian Kellermann <[hidden email]> wrote:
>
>
> * Tobias Pape <[hidden email]> [171210 22:30]:
>>
>>
>>> On 10.12.2017, at 22:03, Christian Kellermann <[hidden email]> wrote:
>>>
>>>
>>> * GitHub <[hidden email]> [171210 15:45]:
>>>>
>>>
>>>> Branch: refs/heads/Cog
>>>> Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>>>> Commit: 3e4db144896baceb78e276986cf85a0a53da542a
>>>>     https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78e276986cf85a0a53da542a
>>>> Author: Nicolas Cellier <[hidden email]>
>>>> Date:   2017-12-10 (Sun, 10 Dec 2017)
>>>>
>>>> Changed paths:
>>>>   M platforms/unix/vm/sqUnixMain.c
>>>>
>>>> Log Message:
>>>> -----------
>>>> include sys/ucontext.h unconditionally in sqUnixMain.c
>>>>
>>>> Also give a prototype to isdigit and toupper (thru ctype.h).
>>>
>>> Sorry for catching this too late. There is no sys/ucontext.h on
>>> OpenBSD. Can we at least wrap this in a ifndef __OpenBSD__ please?

+1

>>
>> what about ucontext.h?
>
> There is no uc_mcontext, ucontext_t lives in <signal.h> and is a
> typedef for struct sigcontext. Why is this needed exactly?

The VM profiler samples the of periodically, storing it in a circular buffer.  On unix this is fine by delivering a signal and having the signal handler access the interrupted pc through the supplied uc_mcontext

> I could
> compile the VM before without issues
>
> Cheers,
>
> Christian
>
> --
> May you be peaceful, may you live in safety, may you be free from
> suffering, and may you live with ease.
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Christian Kellermann
 
Hi Eliot,

* Eliot Miranda <[hidden email]> [171211 05:30]:
> > There is no uc_mcontext, ucontext_t lives in <signal.h> and is a
> > typedef for struct sigcontext. Why is this needed exactly?

> The VM profiler samples the of periodically, storing it in a
> circular buffer.  On unix this is fine by delivering a signal and
> having the signal handler access the interrupted pc through the
> supplied uc_mcontext

How can I test this? So that we don't hide another incompatibility
here...

Kind regards,

Christian

--
May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Nicolas Cellier
 
Hi,
sorry for the mistake.
ucontext is defined in sys/signal.h on OpenBSD
http://openbsd-archive.7691.n7.nabble.com/sys-ucontext-h-dead-code-walking-td269477.html

2017-12-11 10:18 GMT+01:00 Christian Kellermann <[hidden email]>:

Hi Eliot,

* Eliot Miranda <[hidden email]> [171211 05:30]:
> > There is no uc_mcontext, ucontext_t lives in <signal.h> and is a
> > typedef for struct sigcontext. Why is this needed exactly?

> The VM profiler samples the of periodically, storing it in a
> circular buffer.  On unix this is fine by delivering a signal and
> having the signal handler access the interrupted pc through the
> supplied uc_mcontext

How can I test this? So that we don't hide another incompatibility
here...

Kind regards,

Christian

--
May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.

Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...

Christian Kellermann
 
* Nicolas Cellier <[hidden email]> [171211 10:25]:
>  

> Hi,
> sorry for the mistake.
> ucontext is defined in sys/signal.h on OpenBSD
> http://openbsd-archive.7691.n7.nabble.com/sys-ucontext-h-dead-code-walking-td269477.html

Thanks!