[OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
 

DESPlugin, MD5Plugin and SHA2Plugin as external plugins


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513

Commit Summary

  • Add missing Cryptography plugins to squeak builds

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
 

@fniephaus requested changes on this pull request.


In build.linux32ARMv6/squeak.cog.spur/plugins.ext:

> @@ -16,3 +16,6 @@ XDisplayControlPlugin \
 #BochsIA32Plugin \
 #BochsX64Plugin \
 #GdbARMPlugin
+DESPlugin \
+MD5Plugin \
+SHA2Plugin \

Not sure these files are allowed to end with an \. More importantly, these three new items must be listed before the first #. Currently, they are unfortunately all commented out. Yes, the syntax of this file is terrible!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#pullrequestreview-448298510", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#pullrequestreview-448298510", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
In reply to this post by smalltalking
 

@smalltalking commented on this pull request.


In build.linux32ARMv6/squeak.cog.spur/plugins.ext:

> @@ -16,3 +16,6 @@ XDisplayControlPlugin \
 #BochsIA32Plugin \
 #BochsX64Plugin \
 #GdbARMPlugin
+DESPlugin \
+MD5Plugin \
+SHA2Plugin \

I wrote a script to rewrite this files en massse because there are so many of them. The script intentionally adds a backslash to the end of all non-comment lines because on linux it just works, and having the \ there has the benefit of easier addition of more lines in the future.
The interesting thing here is that only the 64-bit mac version had problem with the backslash. Neither linux, windows or the 32-bit mac had errors.

On linux, the commented out lines did not cause any problems either. I don't know which program processes these files (and raised the error), but the 64-bit mac version is clearly different that the ones on linux and windows which both seem to accept comments in between lines and the last line ending with .


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#discussion_r454543270", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#discussion_r454543270", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
In reply to this post by smalltalking
 

@smalltalking pushed 1 commit.

  • b543daf Add missing Cryptography plugins to squeak builds part 2


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513/files/4540d7e3e5233a0921445783089f5b0f76519b49..b543daf0722049a61fbffd3780d02443fff14e12", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513/files/4540d7e3e5233a0921445783089f5b0f76519b49..b543daf0722049a61fbffd3780d02443fff14e12", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
In reply to this post by smalltalking
 

@smalltalking commented on this pull request.


In build.linux32ARMv6/squeak.cog.spur/plugins.ext:

> @@ -16,3 +16,6 @@ XDisplayControlPlugin \
 #BochsIA32Plugin \
 #BochsX64Plugin \
 #GdbARMPlugin
+DESPlugin \
+MD5Plugin \
+SHA2Plugin \

Moving the comments to the end turned out to be enough to fix the errors on 64-bit mac.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#discussion_r454981175", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#discussion_r454981175", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add missing Cryptography plugins to squeak builds (#513)

smalltalking
In reply to this post by smalltalking
 

Merged #513 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#event-3562177757", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/513#event-3562177757", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>