[OpenSmalltalk/opensmalltalk-vm] Add missing code signing command for MacOS Travis (#398)

 

I am adding a missing command that is now required for code signing in Travis. Otherwise, it seem that the build is hanging because it is expecting manual password input.

See https://docs.travis-ci.com/user/common-build-problems/#mac-macos-sierra-1012-code-signing-errors

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398

Commit Summary

• I am adding a missing command that is now required for code signing in travis.

File Changes

• M deploy/pack-vm.sh (1)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW4PZV54XYETNGDBPBTPZLTGFA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYLI7UA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW4PZV54XYETNGDBPBTPZLTGFA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYLI7UA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Hi,

It seems that the PR Travis test is useless for this commit, because of this in the .travis.yml:

yml after_success: (cd deploy && ./filter-exec.sh pack-vm.sh)

Does it make sense to filter the packing vm step?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW7SJ3LJE3JK5EH5GXTPZLUBNA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHG35Y#issuecomment-500067831", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW7SJ3LJE3JK5EH5GXTPZLUBNA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHG35Y#issuecomment-500067831", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@fniephaus approved this pull request.

LGTM, thanks!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW52K5RHH7K3TQANY33PZNSR5A5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB27GRLI#pullrequestreview-247359661", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW52K5RHH7K3TQANY33PZNSR5A5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB27GRLI#pullrequestreview-247359661", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #398 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW4KCXRXXCD4BXFWAGTPZNSWNA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR35USKQ#event-2398832938", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEW4KCXRXXCD4BXFWAGTPZNSWNA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR35USKQ#event-2398832938", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@ronsaldo for security reasons, PR builds are not deployed. Let me know if you like permissions to directly push to this repository.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEWYZYT7PR5FNBWQAWKDPZNS4FA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHQGPY#issuecomment-500106047", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/398?email_source=notifications\u0026email_token=AIJPEWYZYT7PR5FNBWQAWKDPZNS4FA5CNFSM4HV6BAP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHQGPY#issuecomment-500106047", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>