[OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
 

Two commits
part 1 - copied build.win64x64/pharo.cog.spur to build.win32x86/pharo.cog.spur
part 2 - tuned latter to build a stack vm


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317

Commit Summary

  • Add pharo.stack.sput, part 1 - direct copy of pharo.cog.spur
  • Add pharo.stack.spur, part 2 - modify cog build into stack uild

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add stack win32 build (#317)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "81c7dec", "value": "Add pharo.stack.sput, part 1 - direct copy of pharo.cog.spur" }, { "name": "baf88a9", "value": "Add pharo.stack.spur, part 2 - modify cog build into stack uild" } ] }, { "title": "File Changes", "facts": [ { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-0) (38 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/Pharo.def.in](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-1) (3 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/Pharo.exe.manifest](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-2) (30 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/Pharo.ico](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-3) (0 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/Pharo.rc](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-4) (32 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-5) (34 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/plugins.ext](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-6) (9 changes)" }, { "name": "Added", "value": "[build.win32x86/pharo.stack.spur/plugins.int](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317/files#diff-7) (40 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
 

I've rebased this away from my serial-fix-attempt onto the latest HEAD with Eliot's fix.
build.win32x86/pharo.stack.spur/mvm -d succeeded on my machine.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #317: I've rebased this away from my serial-fix-attempt onto the latest HEAD with Eliot's fix.\r\n```build.win32x86/pharo.stack.spur/mvm -d``` succeeded on my machine."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445117938"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445117938", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445117938", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445117938" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

This is the same error I initially got on my local machine with last week's HEAD. Then I went back a few dozen commits and that Freetype build worked okay, then when I returned to the HEAD commit, it now worked. Huh!?
No clue here. see... http://forum.world.st/Freetype-ftconfig-h-missing-td5089946.html

-- Build files have been written to: /cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build
make[3]: Entering directory '/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build'
[100%] Linking C shared library libfreetype.dll
[100%] Built target freetype
[100%] Built target freetype
Install the project...
-- Installing: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/config/ftheader.h
...etc...
-- Installing: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h
CMake Error at cmake_install.cmake:35 (file):
  file INSTALL cannot find
  "/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h".
make[1]: *** [Makefile:62: install] Error 1
make[1]: Leaving directory '/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build'
make: *** [../third-party/Makefile.freetype2:25: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/bin/libfreetype.dll] Error 2
Command exited with code 1


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #317: This is the same error I initially got on my local machine with last week's HEAD. Then I went back a few dozen commits and that Freetype build worked okay, then when I returned to the HEAD commit, it now worked. Huh!?\r\nNo clue here. see... http://forum.world.st/Freetype-ftconfig-h-missing-td5089946.html\r\n```\r\n-- Build files have been written to: /cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build\r\nmake[3]: Entering directory '/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build'\r\n[100%] Linking C shared library libfreetype.dll\r\n[100%] Built target freetype\r\n[100%] Built target freetype\r\nInstall the project...\r\n-- Installing: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/config/ftheader.h\r\n...etc...\r\n-- Installing: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h\r\nCMake Error at cmake_install.cmake:35 (file):\r\n file INSTALL cannot find\r\n \"/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h\".\r\nmake[1]: *** [Makefile:62: install] Error 1\r\nmake[1]: Leaving directory '/cygdrive/c/projects/vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build'\r\nmake: *** [../third-party/Makefile.freetype2:25: /cygdrive/c/projects/vm/.thirdparty-cache/windows/i386/bin/libfreetype.dll] Error 2\r\nCommand exited with code 1\r\n```"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445128164"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445128164", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445128164", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445128164" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

Hi Ben,

Are you sure you didn't just go back to using the previous version of freetype (pre 2.9.1)?

If you do have 2.9.1, do you know which commit you went back to?

I'm still not able to build on windows :-(

Thanks,
Alistair


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #317: Hi Ben,\r\n\r\nAre you sure you didn't just go back to using the previous version of freetype (pre 2.9.1)?\r\n\r\nIf you do have 2.9.1, do you know which commit you went back to?\r\n\r\nI'm still not able to build on windows :-(\r\n\r\nThanks,\r\nAlistair"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445141116"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445141116", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445141116", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445141116" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

nope. freetype-2.9.1 also fails...
$ git clone --depth 10 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
$ git checkout HEAD~9
$ cd build.win32x86/pharo.cog.spur
To fail faster...
$ vi Makefile # to ignore the other libraries...

THIRDPARTYLIBS:=freetype2

$ ./mvm -d

file INSTALL cannot find
  "/home/Ben/Repos/depth10/opensmalltalk-vm/build.win32x86/pharo.cog.spur/builddbg/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h".
make[2]: *** [Makefile:62: install] Error 1
make[2]: Leaving directory '/home/Ben/Repos/depth10/opensmalltalk-vm/build.win32x86/pharo.cog.spur/builddbg/third-party/freetype-2.9.1/build'
make[1]: *** [../third-party/Makefile.freetype2:25: /home/Ben/Repos/depth10/opensmalltalk-vm/.thirdparty-cache/windows/i386/bin/libfreetype.dll] Error 2


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #317: nope. freetype-2.9.1 also fails...\r\n$ git clone --depth 10 https://github.com/OpenSmalltalk/opensmalltalk-vm.git\r\n$ git checkout HEAD~9\r\n$ cd build.win32x86/pharo.cog.spur\r\nTo fail faster...\r\n$ vi Makefile # to ignore the other libraries...\r\n```\r\nTHIRDPARTYLIBS:=freetype2\r\n```\r\n$ ./mvm -d\r\n\r\n```\r\nfile INSTALL cannot find\r\n \"/home/Ben/Repos/depth10/opensmalltalk-vm/build.win32x86/pharo.cog.spur/builddbg/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h\".\r\nmake[2]: *** [Makefile:62: install] Error 1\r\nmake[2]: Leaving directory '/home/Ben/Repos/depth10/opensmalltalk-vm/build.win32x86/pharo.cog.spur/builddbg/third-party/freetype-2.9.1/build'\r\nmake[1]: *** [../third-party/Makefile.freetype2:25: /home/Ben/Repos/depth10/opensmalltalk-vm/.thirdparty-cache/windows/i386/bin/libfreetype.dll] Error 2\r\n```"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445160437"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445160437", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445160437", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445160437" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

I opened a new issue #319 for the freetype error introduced two weeks ago.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #317: I opened a new issue #319 for the freetype error introduced two weeks ago.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445248739"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445248739", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445248739", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-445248739" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@nicolas-cellier-aka-nice commented on this pull request.


In build.win32x86/pharo.stack.spur/Makefile:

> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

These comments are troubling...
Either these flags are necessary as the comment tells... but then why don't we find them in code?
... or they are not anymore to date and should be removed.
I know you did not add these lines by yourself, only copied them, but someone forgot to clean up, so while at it...
(All these changes are marked as authored by Esteban, but I'm pretty sure that it was me who did perform the cleanup; at the time when wanting to work in a parallel pharo repository, git was somehow missused!)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@nicolas-cellier-aka-nice commented on 317", "sections": [ { "text": "", "activityTitle": "**Nicolas Cellier**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@nicolas-cellier-aka-nice", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@nicolas-cellier-aka-nice commented on this pull request.


In build.win32x86/pharo.stack.spur/Makefile:

> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

Or maybe I just gave instructions in commit message e9ff2f2 ?
Failure to cleanup is not only mine, it's collective then ;)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r240416551"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r240416551", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r240416551", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@nicolas-cellier-aka-nice commented on 317", "sections": [ { "text": "", "activityTitle": "**Nicolas Cellier**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@nicolas-cellier-aka-nice", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r240416551" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

Hi Nicolas, the flags are necessary (but one is misnamed). See platforms/Cross/vm/sqCogStackAlignment.h for use and default definition of STACK_ALIGN_BYTES. See src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c for use of ALLOCA_LIES_SO_SETSP_BEFORE_CALL. But ALLOCA_LIES_SO_SETSP_BEFORE_CALL is set up by X64Win64FFIPlugin.c so we don't need it on the command line.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #317: Hi Nicolas, the flags are necessary (but one is misnamed). See platforms/Cross/vm/sqCogStackAlignment.h for use and default definition of STACK_ALIGN_BYTES. See src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c for use of ALLOCA_LIES_SO_SETSP_BEFORE_CALL. But ALLOCA_LIES_SO_SETSP_BEFORE_CALL is set up by X64Win64FFIPlugin.c so we don't need it on the command line."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-446067613"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-446067613", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-446067613", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)", "sections": [ { "text": "", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 317,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 317\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-446067613" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@bencoman commented on this pull request.


In build.win32x86/pharo.stack.spur/Makefile:

> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

you are right, I just copied those lines from pharo.cog.spur.
But is this PR the place to fix these? This PR is focused on build.win64x64/pharo.cog.spur and your concern seems a broader issue...

$ find opensmaltalk-vm   -name Makefile  -print  -exec grep STACK_ALIGN_BYTES {} \;

./build.win32x86/pharo.cog.spur/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/pharo.cog.spur.lowcode/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/pharo.sista.spur/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/squeak.cog.spur.lowcode/Makefile
COGDEFS:= -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@nicolas-cellier-aka-nice commented on this pull request.


In build.win32x86/pharo.stack.spur/Makefile:

> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

Of course, changes can be post-poned after this PR. i just said "while at it"


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241118972"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241118972", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241118972", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

Ben Coman-4
In reply to this post by Ben Coman-4
 

I solved the freetype-2.9.1 build error in issue #319. It was an upstream problem unrelated to this PR.
Is there anything remaining to prevent this PR being merged?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #317: I solved the freetype-2.9.1 build error in issue #319. It was an upstream problem unrelated to this PR.\r\nIs there anything remaining to prevent this PR being merged? "}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-447656726"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-447656726", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#issuecomment-447656726", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>