[OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
 

The first step says to run

./scripts/updateSCCSVersions

The script fails because platforms/Cross/vm/sqSCCSVersion.h: doesn't exist


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Build instructions fail (#209)"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
 

Is that the only output?
can you give the detailed output of the script?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krono in #209: Is that the only output?\r\ncan you give the detailed output of the script?"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362653358"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

that's all the output:

/CogNOS/opensmalltalk-vm (Cog)$ ./scripts/updateSCCSVersions
./scripts/updateSCCSVersions: line 29: platforms/Cross/vm/sqSCCSVersion.h: No such file or directory

btw the file seems to exist


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: that's all the output:\r\n\r\n/CogNOS/opensmalltalk-vm (Cog)$ ./scripts/updateSCCSVersions \r\n./scripts/updateSCCSVersions: line 29: platforms/Cross/vm/sqSCCSVersion.h: No such file or directory\r\n\r\nbtw the file seems to exist"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362667745"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

what kind of shell do you use? because

echo "//" >> platforms/Cross/vm/sqSCCSVersion.h

should sure work


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krono in #209: what kind of shell do you use? because \r\n```shell\r\necho \"//\" \u003e\u003e platforms/Cross/vm/sqSCCSVersion.h\r\n```\r\nshould sure work"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362670765"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

plain bash, and that line works ok. Running it with bash -x shows more info. Removing the extra /.. at line 14, seems to fix it.

./scripts/updateSCCSVersions
++ dirname ./scripts/updateSCCSVersions

  • '[' -d ./scripts/../.git ']'
    ++ dirname ./scripts/updateSCCSVersions
  • cd ./scripts/../..
    ++ basename ./scripts/updateSCCSVersions
  • [[ updateSCCSVersions == \p\o\s\t-\c\h\e\c\k\o\u\t ]]
  • git config --local include.path ../.gitconfig
  • git stash -q
  • echo //
    ./scripts/updateSCCSVersions: line 29: platforms/Cross/vm/sqSCCSVersion.h: No such file or directory


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: plain bash, and that line works ok. Running it with bash -x shows more info. Removing the extra `/..` at line 14, seems to fix it.\r\n\r\n./scripts/updateSCCSVersions \r\n++ dirname ./scripts/updateSCCSVersions\r\n+ '[' -d ./scripts/../.git ']'\r\n++ dirname ./scripts/updateSCCSVersions\r\n+ cd ./scripts/../..\r\n++ basename ./scripts/updateSCCSVersions\r\n+ [[ updateSCCSVersions == \\p\\o\\s\\t\\-\\c\\h\\e\\c\\k\\o\\u\\t ]]\r\n+ git config --local include.path ../.gitconfig\r\n+ git stash -q\r\n+ echo //\r\n./scripts/updateSCCSVersions: line 29: platforms/Cross/vm/sqSCCSVersion.h: No such file or directory\r\n"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362674038"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

ah, did you do a git checkout or do you use a zip?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krono in #209: ah, did you do a git checkout or do you use a zip?"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362675938"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

a checkout


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: a checkout"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362676409"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

thats very strange, because then '[' -d ./scripts/../.git ']' must be true...
From which directory do you run that?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krono in #209: thats very strange, because then `'[' -d ./scripts/../.git ']'` must be true...\r\nFrom which directory do you run that?"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362678444"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

As this is a submodule, .git is not a directory but a file. Changing the line

if [ -d `dirname $0`/../.git ]; then

to

if [ -e `dirname $0`/../.git ]; then

makes the script work, but as I have no idea what this script does, I'm not sure if the change is correct


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: As this is a submodule, .git is not a directory but a file. Changing the line\r\n\r\n if [ -d `dirname $0`/../.git ]; then\r\n\r\nto \r\n\r\n if [ -e `dirname $0`/../.git ]; then\r\n\r\nmakes the script work, but as I have no idea what this script does, I'm not sure if the change is correct"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362688331"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

Eliot Miranda-2
 
Hi Javier,

On Feb 2, 2018, at 11:50 AM, Javier Pimas <[hidden email]> wrote:

As this is a submodule, .git is not a directory but a file. Changing the line

if [ -d `dirname $0`/../.git ]; then

to

if [ -e `dirname $0`/../.git ]; then

makes the script work, but as I have no idea what this script does, I'm not sure if the change is correct

<script type="application/json" data-scope="inboxmarkup"><div x-apple-mail="AppleTemporaryPresentationElement" style="display: none;">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: As this is a submodule, .git is not a directory but a file. Changing the line\r\n\r\n if [ -d `dirname $0`/../.git ]; then\r\n\r\nto \r\n\r\n if [ -e `dirname $0`/../.git ]; then\r\n\r\nmakes the script work, but as I have no idea what this script does, I'm not sure if the change is correct"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362688331"}}}</div></script>

The platforms/Cross/vm/sqSCCSVersion.h file is supposed to contain the information that identifies a particular commit.  It stands for Source Code Control System Version.  With many SCCS systems, including Subversion, which was used to manage the source before git, one can use a metalanguage in the source file that is recognized and replaced by commit information on each commit.  Git doesn't support this (?!?!?!).  So we have to do it manually with this script.  The script gets run automatically by the commit script scripts/gitci, but if you do a fresh check out you'll need to run the script to get the VM's --version command to print meaningful commit information.

Ideally we would have rewritten the makefiles to do this automatically but not yet :-)

Anyway, your fix looks correct.  Please feel free to commit.  Also you might copy my opening paragraph above ("The platforms ... meaningful commit information.") as a comment at the start of the script.

Sorry for the mess.  But most importantly, welcome!!!  It's great to see you and Guido involved.  I'm very excited.  Thank you!


Eliot _,,,^..^,,,_ (phone)
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

Jakob Reschke-2
 
Hi Eliot,

2018-02-03 16:52 GMT+01:00 Eliot Miranda <[hidden email]>:
> With many SCCS systems, including Subversion, which was used to manage the source before git, one can use a metalanguage in the source file that is recognized and replaced by commit information on each commit.  Git doesn't support this (?!?!?!).

Somehow I often feel the urge to defend git, please bear with me. ;-)
Git does support it just the way it is done for opensmalltalk-vm:
through smudge and clean filters. Actually this is much more flexible
than in Svn. The "problem" is that git will not touch your files
unless you tell it to: if the sqSCCSVersion.h was not modified, git
will not update it just because you committed something else. Hence,
you need to run additional scripts (as post-commit, post-checkout
hook, or manually) to get that effect.

> So we have to do it manually with this script.

At least for the first time after a clone (not checkout), after which
the script will have installed itself as hooks. Also you need to run
the script manually again if it was changed, so the hooks are
accordingly overwritten as well.

Since GitHub will not run our scripts or install the filters, their
effects are neither visible on the web nor in the tarballs, but see
below.

> Ideally we would have rewritten the makefiles to do this automatically but not yet :-)

+1, usually this should happen in a configure step. But it should
check that git is actually available on the build machine. (And perl,
as the filters are currently implemented in perl.)

For release tar and zip downloads (which would not have a git
repository available to extract version info), have a look at
https://git-scm.com/docs/gitattributes#_code_export_subst_code Maybe
the placeholders and the filters could be updated to converge with
this.

For example:

    "Rev: $Format:%h$"
    "Date: $Format:%ad$"
    "Url: (hard-code official URL or "tarball" here. If the filter
and, thus, git are available, it is overwritten)".

.gitconfig

    [filter "rev"]
        smudge = set -x && perl -pe 's/\"Rev:
\\$Format:[^\\$]*\\$/\"Rev: '\"$(git log -1 --format=%h)\"'/'
        clean = set -x && perl -pe 's/\"Rev: [0-9a-f]*/\"Rev: \\$Format:%h\\$/'

.gitattributes

    sq*SCCSVersion.h filter=rev export-subst

testing the tarball results

    $ git archive HEAD platforms/Cross/vm/sqSCCSVersions.h | tar xO |
grep GitRawRevisionString[]

The username+machine-inserting stuff in the smudge script could be
moved out of the filter into the make-invoked code, so that tarball
users can also benefit from it. But I guess none of this is urgent, I
just wanted to dump this info for now. ;-)

Best regards,
Jakob
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

Closed #209.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #209."}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#event-1461093509"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 

#213 should fix this issue. Please re-open if it doesn't.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #209: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/213 should fix this issue. Please re-open if it doesn't."}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-363571570"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Build instructions fail (#209)

hjht
In reply to this post by hjht
 
Hi Eliot! sorry for the late answer. It seems it was overtaken by a
slightly bigger issue now, but thanks for the explanation anyway.

Cheers,
Pocho

On Sat, Feb 3, 2018 at 12:52 PM, OpenSmalltalk-Bot <[hidden email]
> wrote:

> Hi Javier,
>
> > On Feb 2, 2018, at 11:50 AM, Javier Pimas <[hidden email]>
> wrote:
> >
> > As this is a submodule, .git is not a directory but a file. Changing the
> line
> >
> > if [ -d `dirname $0`/../.git ]; then
> > to
> >
> > if [ -e `dirname $0`/../.git ]; then
> > makes the script work, but as I have no idea what this script does, I'm
> not sure if the change is correct
> >
>
> The platforms/Cross/vm/sqSCCSVersion.h file is supposed to contain the
> information that identifies a particular commit. It stands for Source Code
> Control System Version. With many SCCS systems, including Subversion, which
> was used to manage the source before git, one can use a metalanguage in the
> source file that is recognized and replaced by commit information on each
> commit. Git doesn't support this (?!?!?!). So we have to do it manually
> with this script. The script gets run automatically by the commit script
> scripts/gitci, but if you do a fresh check out you'll need to run the
> script to get the VM's --version command to print meaningful commit
> information.
>
> Ideally we would have rewritten the makefiles to do this automatically but
> not yet :-)
>
> Anyway, your fix looks correct. Please feel free to commit. Also you might
> copy my opening paragraph above ("The platforms ... meaningful commit
> information.") as a comment at the start of the script.
>
> Sorry for the mess. But most importantly, welcome!!! It's great to see you
> and Guido involved. I'm very excited. Thank you!
>
>
> Eliot _,,,^..^,,,_ (phone)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362825127>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AATPaVcijxg2VuLMQvIJyCQAPPxhJMioks5tRIDUgaJpZM4R3brI>
> .
>



--
Javier Pimás
Ciudad de Buenos Aires


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: Hi Eliot! sorry for the late answer. It seems it was overtaken by a\nslightly bigger issue now, but thanks for the explanation anyway.\n\nCheers,\nPocho\n\nOn Sat, Feb 3, 2018 at 12:52 PM, OpenSmalltalk-Bot \u003cnotifications@github.com\n\u003e wrote:\n\n\u003e Hi Javier,\n\u003e\n\u003e \u003e On Feb 2, 2018, at 11:50 AM, Javier Pimas \u003cnotifications@github.com\u003e\n\u003e wrote:\n\u003e \u003e\n\u003e \u003e As this is a submodule, .git is not a directory but a file. Changing the\n\u003e line\n\u003e \u003e\n\u003e \u003e if [ -d `dirname $0`/../.git ]; then\n\u003e \u003e to\n\u003e \u003e\n\u003e \u003e if [ -e `dirname $0`/../.git ]; then\n\u003e \u003e makes the script work, but as I have no idea what this script does, I'm\n\u003e not sure if the change is correct\n\u003e \u003e\n\u003e\n\u003e The platforms/Cross/vm/sqSCCSVersion.h file is supposed to contain the\n\u003e information that identifies a particular commit. It stands for Source Code\n\u003e Control System Version. With many SCCS systems, including Subversion, which\n\u003e was used to manage the source before git, one can use a metalanguage in the\n\u003e source file that is recognized and replaced by commit information on each\n\u003e commit. Git doesn't support this (?!?!?!). So we have to do it manually\n\u003e with this script. The script gets run automatically by the commit script\n\u003e scripts/gitci, but if you do a fresh check out you'll need to run the\n\u003e script to get the VM's --version command to print meaningful commit\n\u003e information.\n\u003e\n\u003e Ideally we would have rewritten the makefiles to do this automatically but\n\u003e not yet :-)\n\u003e\n\u003e Anyway, your fix looks correct. Please feel free to commit. Also you might\n\u003e copy my opening paragraph above (\"The platforms ... meaningful commit\n\u003e information.\") as a comment at the start of the script.\n\u003e\n\u003e Sorry for the mess. But most importantly, welcome!!! It's great to see you\n\u003e and Guido involved. I'm very excited. Thank you!\n\u003e\n\u003e\n\u003e Eliot _,,,^..^,,,_ (phone)\n\u003e\n\u003e —\n\u003e You are receiving this because you authored the thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362825127\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/AATPaVcijxg2VuLMQvIJyCQAPPxhJMioks5tRIDUgaJpZM4R3brI\u003e\n\u003e .\n\u003e\n\n\n\n-- \nJavier Pimás\nCiudad de Buenos Aires\n"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-365622436"}}}</script>