[OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
 
  • We added customization for Pharo to allow a different menu to be used.

  • We modified the default action of help menu to open an URL (only for Pharo)

  • We added a Info.plist property with the string value of the URL (only for Pharo)

  • And also the about dialog was not receiving the close event, we have fixed that. It was related with the filtering of events for SDL.

@demarey


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388

Commit Summary

  • Adding a custom Menu for Pharo VMs
  • Adding a optional URL for the help, only fr Pharo
  • Handling correctly the events of the about window
  • Making the about window property as weak.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Customization for Pharo \u0026 About Dialog (#388)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
 

fixes pharo-project/pharo#3036
fixes pharo-project/pharo-launcher#318


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@demarey in #388: fixes pharo-project/pharo#3036\r\nfixes pharo-project/pharo-launcher#318"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478030721"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478030721", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478030721", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

Query though... why disable B3DAcceleratorPlugin ?
This is not mentioned anywhere in this PR.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #388: Query though... why disable B3DAcceleratorPlugin ?\r\nThis is not mentioned anywhere in this PR."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478197112"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478197112", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478197112", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

@tesonep pushed 1 commit.

  • 49e997f Reverting a change I needed to compile in my machine


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tesonep pushed 1 commit in #388"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388/files/b1c5be068429dd6840602464afe7b71537f4fcea..49e997fb57866b046fffe699aef236df77385480"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388/files/b1c5be068429dd6840602464afe7b71537f4fcea..49e997fb57866b046fffe699aef236df77385480", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388/files/b1c5be068429dd6840602464afe7b71537f4fcea..49e997fb57866b046fffe699aef236df77385480", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

It is true, I have reverted that change. Sorry!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tesonep in #388: It is true, I have reverted that change. Sorry! "}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478572395"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478572395", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478572395", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

No worries. A fresh set of eyes is always useful.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #388: No worries. A fresh set of eyes is always useful."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478629915"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478629915", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-478629915", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

Hi Pablo,

why not rewrite the Makefiles to use platforms/iOS/vm/English.lproj/$(SYSTEM)-MainMenu.xib?  This would match $(OSXDIR)/$(SYSTEM)-Info.plist and mean less files had to change.  We'd have to duplicate the MainMenu.xib files, one for Newspeak, Pharo and Squeak, but that's not much, and is in the pattern we already have.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEWYCA6E66W2GOQMBSGTP4O3BZA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUPLFQ#issuecomment-506000790", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEWYCA6E66W2GOQMBSGTP4O3BZA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUPLFQ#issuecomment-506000790", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

@tesonep ping


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEW3SKKVZ45UVFCSJHETP7SLIRA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6DF5Q#issuecomment-511455990", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEW3SKKVZ45UVFCSJHETP7SLIRA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6DF5Q#issuecomment-511455990", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

Agree with Eliot, the changes are good, but would be better factored and generalized if we would

  1. change the common/Makefile.app to include the flavour specific menu platforms/iOS/vm/English.lproj/$(SYSTEM)-MainMenu.xib
  2. and mv platforms/iOS/vm/English.lproj/MainMenu.xib platforms/iOS/vm/English.lproj/Squeak-MainMenu.xib
  3. then cp platforms/iOS/vm/English.lproj/Squeak-MainMenu.xib platforms/iOS/vm/English.lproj/Newspeak-MainMenu.xib


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEW2ZP467AG5JNQFQEHDQTRDWJA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7G7XA#issuecomment-553545692", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388?email_source=notifications\u0026email_token=AIJPEW2ZP467AG5JNQFQEHDQTRDWJA5CNFSM4HCKFPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7G7XA#issuecomment-553545692", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

I'm inclined to close. Any takers otherwise?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-690600253", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-690600253", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

Still not solved - and customization should be allowed/possible.

Otherwise people will not be able to build labeled products based on the VM.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-692525699", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-692525699", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#388)

dcstes
In reply to this post by dcstes
 

I did a PR to update this one some days ago: tesonep#1
Waiting for merge


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-692535503", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388#issuecomment-692535503", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>