[OpenSmalltalk/opensmalltalk-vm] Do not convert keyboard event charCode to mac-roman encoding (#403)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Do not convert keyboard event charCode to mac-roman encoding (#403)

Nicolas Cellier-2
 

Fix issue 401

Image do not use such mac-roman encoding for ages.
On the contrary, images have to undo this translation by sending macToSqueak here and there which makes no sense.
We do not need this opensmalltalk VM to be compatible with 15-years old images. Let's clean-up.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403

Commit Summary

  • Do not convert keyboard event charCode to mac-roman encoding

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403?email_source=notifications\u0026email_token=AIJPEW7QTAXO3WP3V4Q4DDTP2FUJJA5CNFSM4HXSUER2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZFNECQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403?email_source=notifications\u0026email_token=AIJPEW7QTAXO3WP3V4Q4DDTP2FUJJA5CNFSM4HXSUER2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZFNECQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Do not convert keyboard event charCode to mac-roman encoding (#403)

Nicolas Cellier-2
 

@nicolas-cellier-aka-nice pushed 1 commit.

  • 557c3bb Fixup: SetupKeymap was removed, don't forget to remove the calls to it!


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403/files/4e34e8a9298241fddc36ff7780189b94597e73ea..557c3bbb50e89e908d845a0b3bc272a3fef2b5fb?email_source=notifications\u0026email_token=AIJPEW6NIKIUBYLU4P2MCYDP2FXKJA5CNFSM4HXSUER2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGI4DONRYGYYDQNKQOVZWQIZTG4YDQNBZG4ZDMMA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403/files/4e34e8a9298241fddc36ff7780189b94597e73ea..557c3bbb50e89e908d845a0b3bc272a3fef2b5fb?email_source=notifications\u0026email_token=AIJPEW6NIKIUBYLU4P2MCYDP2FXKJA5CNFSM4HXSUER2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGI4DONRYGYYDQNKQOVZWQIZTG4YDQNBZG4ZDMMA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>