[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
 

1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268

Commit Summary

  • FileAttributesPlugin v1.3.0
  • FileAttributesPlugin: Interpreter proxy is responsible for conversion

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"FileAttributesPlugin 1.3.0 (#268)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "FileAttributesPlugin 1.3.0 (#268)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "cfbd87c", "value": "FileAttributesPlugin v1.3.0" }, { "name": "02d593f", "value": "FileAttributesPlugin: Interpreter proxy is responsible for conversion" } ] }, { "title": "File Changes", "facts": [ { "name": "Modified", "value": "[platforms/unix/vm/sqUnixMain.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files#diff-0) (44 changes)" }, { "name": "Modified", "value": "[src/plugins/FileAttributesPlugin/FileAttributesPlugin.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files#diff-1) (523 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 268,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 268\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Stuart Cassoff-2
 
+ * WARNING: On 32 bit platforms time_t is only 32 bits long.

FWIW, not everywhere.
I didn't look over your patch in detail so I don't know if this makes a difference.


$ uname -msr && cat ct.c && cc ct.c && ./a.out
OpenBSD 6.3 i386
#include <stdio.h>
int main (int argc, char *argv[]) {
        printf("%lu\n", sizeof (void *));
        printf("%lu\n", sizeof (time_t));
        return 0;
}
4
8


$  uname -msr && cc ct.c && ./a.out              
OpenBSD 6.3 amd64
8
8


Stu


> ---------- Original Message ----------
> From: akgrant43 <[hidden email]>
> Date: June 16, 2018 at 9:27 AM
>
>
>  1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes.
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268
>
> -- Commit Summary --
>
>   * FileAttributesPlugin v1.3.0
>   * FileAttributesPlugin: Interpreter proxy is responsible for conversion
>
> -- File Changes --
>
>     M platforms/unix/vm/sqUnixMain.c (44)
>     M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (523)
>
> -- Patch Links --
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.patch
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.diff
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Alistair Grant
 
Hi Stu,

On Sat, 16 Jun 2018 at 16:43, Stuart Cassoff <[hidden email]> wrote:

>
>
> + * WARNING: On 32 bit platforms time_t is only 32 bits long.
>
> FWIW, not everywhere.
> I didn't look over your patch in detail so I don't know if this makes a difference.
>
>
> $ uname -msr && cat ct.c && cc ct.c && ./a.out
> OpenBSD 6.3 i386
> #include <stdio.h>
> int main (int argc, char *argv[]) {
>         printf("%lu\n", sizeof (void *));
>         printf("%lu\n", sizeof (time_t));
>         return 0;
> }
> 4
> 8
>
>
> $  uname -msr && cc ct.c && ./a.out
> OpenBSD 6.3 amd64
> 8
> 8
>
>
> Stu

Thanks for letting me know, I'll update the comment to say "On some 32
bit platforms...".

Cheers,
Alistair
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@akgrant43 pushed 2 commits.

  • bd4ebc8 FileAttributesPlugin 1.3.1: clean-up type declarations
  • d583976 Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/02d593f8a87170583976cd6b75f1df07f14e02aa..d583976248e7a65a03712edabd62fd91da628dc1","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/02d593f8a87170583976cd6b75f1df07f14e02aa..d583976248e7a65a03712edabd62fd91da628dc1","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 pushed 2 commits in #268"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/02d593f8a87170583976cd6b75f1df07f14e02aa..d583976248e7a65a03712edabd62fd91da628dc1"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@akgrant43 pushed 2 commits in #268", "sections": [ { "text": "2 new commits pushed to OpenSmalltalk/opensmalltalk-vm #268:", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ { "name": "bd4ebc8", "value": "FileAttributesPlugin 1.3.1: clean-up type declarations" }, { "name": "d583976", "value": "Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/02d593f8a87170583976cd6b75f1df07f14e02aa..d583976248e7a65a03712edabd62fd91da628dc1" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@akgrant43 pushed 1 commit.

  • 7aedb43 Mac add convertToLongSqueakTime()


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/d583976248e7a65a03712edabd62fd91da628dc1..7aedb43079415666065532703299fccc8a6c743c","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/d583976248e7a65a03712edabd62fd91da628dc1..7aedb43079415666065532703299fccc8a6c743c","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 pushed 1 commit in #268"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/d583976248e7a65a03712edabd62fd91da628dc1..7aedb43079415666065532703299fccc8a6c743c"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@akgrant43 pushed 1 commit in #268", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #268:", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ { "name": "7aedb43", "value": "Mac add convertToLongSqueakTime()" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/d583976248e7a65a03712edabd62fd91da628dc1..7aedb43079415666065532703299fccc8a6c743c" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@akgrant43 pushed 1 commit.

  • 2397f46 Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/7aedb43079415666065532703299fccc8a6c743c..2397f46cf91337a7d836aa1601c1318c312ed1dd","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/7aedb43079415666065532703299fccc8a6c743c..2397f46cf91337a7d836aa1601c1318c312ed1dd","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 pushed 1 commit in #268"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/7aedb43079415666065532703299fccc8a6c743c..2397f46cf91337a7d836aa1601c1318c312ed1dd"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@akgrant43 pushed 1 commit in #268", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #268:", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ { "name": "2397f46", "value": "Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/7aedb43079415666065532703299fccc8a6c743c..2397f46cf91337a7d836aa1601c1318c312ed1dd" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@akgrant43 pushed 1 commit.

  • 309a810 1.3.2: Internalise unix to squeak time conversion for MacOS


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/2397f46cf91337a7d836aa1601c1318c312ed1dd..309a810bab7d4598b7e2650dd1b5f598d0899782","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/2397f46cf91337a7d836aa1601c1318c312ed1dd..309a810bab7d4598b7e2650dd1b5f598d0899782","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 pushed 1 commit in #268"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/2397f46cf91337a7d836aa1601c1318c312ed1dd..309a810bab7d4598b7e2650dd1b5f598d0899782"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@akgrant43 pushed 1 commit in #268", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #268:", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ { "name": "309a810", "value": "1.3.2: Internalise unix to squeak time conversion for MacOS" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/2397f46cf91337a7d836aa1601c1318c312ed1dd..309a810bab7d4598b7e2650dd1b5f598d0899782" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

@akgrant43 pushed 1 commit.

  • 84433d3 FileAttributesPlugin: Exclude faConvertUnixToLongSqueakTime on Win32


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/309a810bab7d4598b7e2650dd1b5f598d0899782..84433d3607c6b951bb278616dd40817ded05d174","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/309a810bab7d4598b7e2650dd1b5f598d0899782..84433d3607c6b951bb278616dd40817ded05d174","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 pushed 1 commit in #268"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/309a810bab7d4598b7e2650dd1b5f598d0899782..84433d3607c6b951bb278616dd40817ded05d174"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@akgrant43 pushed 1 commit in #268", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #268:", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ { "name": "84433d3", "value": "FileAttributesPlugin: Exclude faConvertUnixToLongSqueakTime on Win32" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268/files/309a810bab7d4598b7e2650dd1b5f598d0899782..84433d3607c6b951bb278616dd40817ded05d174" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Ben Coman-4
In reply to this post by Ben Coman-4
 

Merged #268.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268#event-1685044780","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268#event-1685044780","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #268."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268#event-1685044780"}}}</script> <script type="application/ld+json">{ "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268#event-1685044780" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346680632\n}" } ], "themeColor": "26292E" }</script>