[OpenSmalltalk/opensmalltalk-vm] Fix issue468 squeak3D 64bits crash (#469)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Fix issue468 squeak3D 64bits crash (#469)

Nicolas Cellier-2
 

This is an attempt at fixing #468
I have played a bit with Guardians without crash, but that's not a smoke test, I'm not good enough nor patient ;)
I don't remember performing that poorly on the ATARI 520 version of Sentinel game, but that's more than 30 years back ;)


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/469

Commit Summary

  • Fix the signature of b3dDrwBufferFunction
  • Protect against an integer overflow in b3dComputeIntersection
  • clamp initial scaledX/Y in int range
  • Avoid blitting at negative yValue offset

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/469?email_source=notifications\u0026email_token=AIJPEW5YYIKYLRAMMVRFUTLQ5TN3PA5CNFSM4KGJHYUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IF4DFGQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/469?email_source=notifications\u0026email_token=AIJPEW5YYIKYLRAMMVRFUTLQ5TN3PA5CNFSM4KGJHYUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IF4DFGQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix issue468 squeak3D 64bits crash (#469)

Stéphane Rollandin
 
> I don't remember performing that poorly on the ATARI 520 version of
> Sentinel game, but that's more than 30 years back ;)
I take this feedback as a confirmation of my feeling that the current
balance of the game makes it a bit too hard.

        Y a quelque chose qui cloche là-dedans
        J'y retourne immédiatement

:)

Stef


Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix issue468 squeak3D 64bits crash (#469)

Nicolas Cellier-2
In reply to this post by Nicolas Cellier-2
 

Merged #469 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/469?email_source=notifications\u0026email_token=AIJPEW5IQCLQLVPYMG6QNH3Q66YKHA5CNFSM4KGJHYUKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWDX7ZZQ#event-2968517862", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/469?email_source=notifications\u0026email_token=AIJPEW5IQCLQLVPYMG6QNH3Q66YKHA5CNFSM4KGJHYUKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWDX7ZZQ#event-2968517862", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>