[OpenSmalltalk/opensmalltalk-vm] Fix the minheadless VM for CI (#404)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Fix the minheadless VM for CI (#404)

Eliot Miranda-4
 

This pull request fixes the CMake based build system for the minheadless for building on CI for both, Pharo and Squeak. This also adds two variants of the minheadless vm:

  • The true headless VM variant.
  • A vm with SDL2 based display that supports standard Pharo and Squeak images, for 32 and 64 bits in Linux, Mac and Windows.

In addition to these fixes, this PR implements adds an image selection dialog for Mac and Windows when the Minheadless VM can not find automatically an image. This allows double clicking the Minheadless VM.

The automatic image search and detection in the Minheadless vm works like this now:

  • If there is an image called startup.image in the same folder as the vm executable, (or in the bundle Resources folder in the case of Mac OS X), then this image is executed always.
  • If there is not an startup.image file in these folder, the vm executable, the Mac Resource folder, or the working directory is searched for all the files with the .image extension. If only one of these files is found, then this image file is executed. If no images are found, or more than one image is found, then image selection dialog is display on Mac and Windows (on Linux, the VM just exits).

This pull request re-implements the thirdparty dependency download, configuration and build using CMake. Only the dependencies that are actually used by a VM variant are built automatically, and it is built only once. AppVeyor and Travis caches are also supported by the CMake based build system. The thirdparty dependencies that are built with CMake are placed under the .thirdparty-cache/cmake folder to avoid clashing and breaking the Makefile based build system. Building thirdparty dependencies with CMake works, but it is messy and hacky (so it is using the Makefiles). The thirdparty dependency build system should be moved into a separate repository. Third party dependencies are quite stable and do not change as frequent as the VM, so it should be easier, cleaner and faster to handle them in a separate repository.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404

Commit Summary

  • I am making sure that the CMake based scripts for the Linux version of the VM is producing the correct directory structure.
  • Generate the proper OS X bundle structure with CMake install scripts.
  • I fixed the cmake install script on Linux.
  • Use the CMake install command for generating the final directory structure.
  • I am fixing the OS X bundled plugins with the minheadless VM.
  • Cleaning up the common plugins between Pharo and Squeak.
  • I am starting to build some Pharo dependencies with CMake.
  • I implemented the compilation of the libgit2 thirdparty dependency.
  • I added the building of the SDL2 external library.
  • I added the freetype2 third party library compilation to the CMake scripts.
  • I fixed the search of freetype on linux.
  • I implemented a hack for treating the OS X version of the minheadless VM as a launcher application.
  • I added the missing Pharo dependencies to the OS X version of the VM CMake building scripts.
  • I added some convenience build directories to build the minheadless VM with SDL2 based traditional display support.
  • I added properly the minheadless vm with SDL2 support to the travis.yml
  • I am now setting the OS X SDK with the CMake build scripts.
  • I am fixing the 32 bits Linux building.
  • I added some missing compilation flags.
  • Match the OS X SDK version that are used by Makefiles scripts.
  • I fixed the warnings settings with the CMake scripts.
  • Fixing another bug with the flags.
  • I am removing more warnings for travis.
  • I commented temporarily the Travis notifications to avoid spamming the vm dev mailing list.
  • Redirect the output of the third party build tools to avoid the Travis CI too large log error message.
  • I improved the third party project login facilities.
  • I fixed the OpenSSL build install script for Mac.
  • I fixed the configuration of OpenSSL for 32 bits MacOS X.
  • I am making some more fixes for CI.
  • I am fixing the previous commit.
  • I did another fixup for Smalltalk CI.
  • I am making progress on building the windows version of the minheadless vm with cmake.
  • I fixed a minor difference between bash and sh.
  • I fixed another problem with the win32 changes on linux.
  • I managed to get the remaining dependencies compiling on 32 bits Windows.
  • Merge branch 'feature/minheadless-ci' of github.com:ronsaldo/opensmalltalk-vm into feature/minheadless-ci
  • I am fixing some compilation flags for Win64.
  • I managed to get the VM building with CMake working on Win64.
  • I did some small changes for CI.
  • Bug fixes.
  • Another fix for appveyor.
  • Fixing a build order dependenct
  • I added the missing resources to the Win32 version of the minheadless VM.
  • I am adding a missing file to the minheadless VM.
  • Keep silencing the thirdparty build logs for travis.
  • I am doing some fixes for CI.
  • Some more fixes for CI.
  • Another fix for CI.
  • Travis yml fixup.
  • I improved the automatic image search of the minheadless VM.
  • Merge branch 'Cog' into feature/minheadless-ci
  • I fixed the automatic image sarch in OS X.
  • I fixed the extra plugin search path on the minheadless.
  • I fixed the automatic image search mechanism on Windows.
  • I am restoring the Travis and AppVeyor yml files.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEW5L3DVEVMCYKWWISMDP2G6CHA5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZGVT7Q", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEW5L3DVEVMCYKWWISMDP2G6CHA5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZGVT7Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix the minheadless VM for CI (#404)

Eliot Miranda-4
 

Travis errors are not related to this PR:

curl -o ../../.thirdparty-cache/libgit2-v0.25.1.tar.gz -L https://github.com/libgit2/libgit2/archive/v0.25.1.tar.gz

% Total % Received % Xferd Average Speed Time Time Time Current

                             Dload  Upload   Total   Spent    Left  Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: github.com

make: *** [../../.thirdparty-cache/libgit2-v0.25.1.tar.gz] Error 6


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEW47GWJBUCZT7TYWBY3P2HJ4ZA5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSRG5I#issuecomment-501551989", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEW47GWJBUCZT7TYWBY3P2HJ4ZA5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSRG5I#issuecomment-501551989", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix the minheadless VM for CI (#404)

Eliot Miranda-4
In reply to this post by Eliot Miranda-4
 

Merged #404 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEWY454N2JTOK2CTCXZ3P4OXN3A5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSGFNUNA#event-2441796148", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/404?email_source=notifications\u0026email_token=AIJPEWY454N2JTOK2CTCXZ3P4OXN3A5CNFSM4HXVTOSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSGFNUNA#event-2441796148", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>