[OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
 

It's about be96d84, the other 3 commits are just noise.
There may be things left to do on Windows and Mac.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464

Commit Summary

  • Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog
  • Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog
  • Fix type inconsistencies (int vs sqInt)
  • Merge branch 'fix-type-inconsistencies-int-sqInt' into Cog

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW7JGFIXLAJDFWU4VUDQ3Y45HA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDXTPHA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW7JGFIXLAJDFWU4VUDQ3Y45HA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDXTPHA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
 

@smalltalking pushed 1 commit.

  • 335d681 Include sqMemoryAccess.h to have sqInt defined


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464/files/bf33e38b80c2a9061ad89af2ccc6b38a3bc5bc97..335d681a2f95eb9f528eed15d23ce62ad3c1cd70?email_source=notifications\u0026email_token=AIJPEW4EKNDSR4QKNSLOY5LQ3ZN2JA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM2TQNZWGQZDGNSQOVZWQIZUGQ2TKNBSGYZDKNA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464/files/bf33e38b80c2a9061ad89af2ccc6b38a3bc5bc97..335d681a2f95eb9f528eed15d23ce62ad3c1cd70?email_source=notifications\u0026email_token=AIJPEW4EKNDSR4QKNSLOY5LQ3ZN2JA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM2TQNZWGQZDGNSQOVZWQIZUGQ2TKNBSGYZDKNA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
In reply to this post by Nicolas Cellier-2
 

335d681 seems to fix the issue on windows.
The appveyor build failed because of an unrelated issue with freetype2. It's probably worth restarting it.
The travis build got into an infinite loop, even though the script exited with Done. Your build exited with 0., the job is still ''running''.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW4R57KHF3PZ54OLUNLQ3Z33NA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH72KQA#issuecomment-570402112", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW4R57KHF3PZ54OLUNLQ3Z33NA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH72KQA#issuecomment-570402112", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
In reply to this post by Nicolas Cellier-2
 

Thanks to whoever pushed the appveyor build; it finally succeeded.
I don't know why the travis builds failed, but both failures seem unrelated to these changes.
Fixes #465.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW6HV7U6RNSM2BOMP33Q35TKNA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIBRKNY#issuecomment-570627383", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW6HV7U6RNSM2BOMP33Q35TKNA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIBRKNY#issuecomment-570627383", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
In reply to this post by Nicolas Cellier-2
 

@fniephaus approved this pull request.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW4SZ7ILAO3ZEW7QM3LQ4NJVJA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQYKYNI#pullrequestreview-338734133", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEW4SZ7ILAO3ZEW7QM3LQ4NJVJA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQYKYNI#pullrequestreview-338734133", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix type inconsistencies (int vs sqInt) (#464)

Nicolas Cellier-2
In reply to this post by Nicolas Cellier-2
 

Merged #464 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEWYEFM6ZCPZKKGA7HRTQ4WWJTA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV2XVC5I#event-2930725237", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/464?email_source=notifications\u0026email_token=AIJPEWYEFM6ZCPZKKGA7HRTQ4WWJTA5CNFSM4KCFW5U2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV2XVC5I#event-2930725237", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>