[OpenSmalltalk/opensmalltalk-vm] Primitives merged back from the PharoVM branch should be reviewed (#192)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Primitives merged back from the PharoVM branch should be reviewed (#192)

Fabio Niephaus-3
 

Nice catch. The cause of the problem is that the primitives were merged
into the Cog branch from PharoVM. These came with
VMMaker.oscog-EstebanLorenzano.1317.
All primitives merged from that branch should be revisited, because
while many of those (like these) are from the original VMMaker branch,
they are flagged with <option: #Pharo>.

Levente

On Wed, 10 Jan 2018, Ricardo Moran wrote:

Hi,

For a while I've been using an old version of Squeak so recently I decided to update and I downloaded Squeak 5.1.
First of all, let me tell you I really like what you have done. I haven't been following the list too much lately so I'm only scratching the surface but this new Squeak looks and feels really nice. And most of my > preferences are already set by default so I don't have
to mess around with the settings too much. Really nice work, thank you.

One thing I noticed while I was playing with the SerialPort is that it doesn't work if I refer to the ports by name (I'm using Windows 10, by the way). This used to work in the old VM so I looked in the source code and it > seems the primitives that allow to use port

names are only compiled for Pharo:
https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/9d39149b257141914497d9c7454e3a2ce6193ec8/src/plugins/SerialPlugin/SerialPlugin.c#L41

So I downloaded the PharoVM and indeed the SerialPort works fine with port names. Is there a reason for this or is it just a bug?

Thanks,
Richo

Mailing list discussion: http://forum.world.st/SerialPort-question-regarding-port-names-td5062751.html


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Primitives merged back from the PharoVM branch should be reviewed (#192)"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/192"}}}</script>