Solaris fixes You can view, comment on, or merge this pull request online at:https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/490 Commit Summary
File Changes
Patch Links:
— |
Here's a crazy idea: can we fold this into the linux build dirs and have the sunos dir be a symlink? The specifica (like openssl no dynamic) could be dealt with in configure and the platform itself :) — |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 The 2 directories are build.sunos32x86 and build.sunos64x64. However there are also a few changes in platforms/* and plugins/* (i.e., outside of build.sunos32x86 and build.sunos64x64). I'm not sure what exactly do you have in mind, or what do you mean, when you say "fold this" ? Some of the changes in platforms/* and plugins/* are not related to the linux build dirs. David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJeoWcnAAoJEAwpOKXMq1MaLyEH/2zK0TbAaxPxyVj7dHTGEvq2 NLRpc9UOdw/97omHEuLl6T4HEabtOPWBBW5bJCjLPBdDKpEouif8UtvGjHMMxB+v SkmcWAKHMffaNTz2MWQ5U4xQWilmzV9g6Vl3bdpTLvR00mKkc0mFEVbn9300Nx5I CSxcmblajiFAcWN31wtC+CFnImQexInyJ3Q0Zv/sEMw4Id7SqHk853qiTVsAGYP4 KgVDHbP2riNUN1lL1SADYtNfFwHjCmFSiPLSIeorF3J4O85YXz0qsrCZe/TC3zYl jEoz2sRCncRep+0WSRZAgyEHpTCJBfcItlT2BBg/06MEOY5UXIDJr40cVdRA2rU= =cXaK -----END PGP SIGNATURE----- -- Sent from: http://forum.world.st/Squeak-VM-f104410.html |
In reply to this post by David T Lewis
Good idea! I would even go further and drop sunos directory altogether. Builds should be scripted based on technology rather than brands. If the variant can no longer be handled by parsing environment, then sunos can be carved into a separate directory. — |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 In any case it is necessary to distinguish between on the one hand, the "build directories" and configure script switches, and on the other hand, some changes to source files outside of the build directories. What the build.sunos directories concerns, it is possible to put those in a separate project. I could for example create a special solaris-squeak project just consisting of those build.sunos directories. The build.sunos* directories can be in an external project. David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJeoXvLAAoJEAwpOKXMq1MaNZwIAJcLhbwRvHLllve5tdzAA33O uPrRKbuMQN/t8sSqWf95iJyrgEb5a/32mkkqDNCdjdwcPoBKHjYxSUNCRQbXnr6i AkS7n2N2hL7BCpK2ZsC5jvLVyfV/ZAKhIA9BBZ5JJUe4+krjBiasYDGE4+ivnPWs pvX4aPIG33IbY+6tNkeWE1T3i6sSsbtot+0ONlnd81XLRNRxlVWicYoRzXG0/LLb Rpl7JoJJ8af6gOQHXzbPYdVXQ8Z2Az4qS1AuY+uz3HOQtrilP1EjNLBfh+cMWsVI s48L4sGT5YM8nMPouaeX3zmtsxzfytyFqPl1CzTA3LUTKXNzI5IXYHOGaUSI5BE= =k1NU -----END PGP SIGNATURE----- -- Sent from: http://forum.world.st/Squeak-VM-f104410.html |
In reply to this post by David T Lewis
@cstes pushed 1 commit.
— |
In reply to this post by David T Lewis
@cstes pushed 1 commit.
— |
In reply to this post by David T Lewis
On Apr 23, 2020, at 1:56 AM, Tobias Pape <[hidden email]> wrote:
|
> On 25.04.2020, at 16:16, Eliot Miranda <[hidden email]> wrote: > > > >> On Apr 23, 2020, at 1:56 AM, Tobias Pape <[hidden email]> wrote: >> >> >> >> Here's a crazy idea: can we fold this into the linux build dirs and have the sunos dir be a symlink? >> >> The specifica (like openssl no dynamic) could be dealt with in configure and the platform itself :) >> > > Why? The benefits of having the separate directory are strong; its own HowToBuild, decoupling. And the space overhead is minimal. I see no benefit in trying to collapse these at all. It's just another unix in the first place. FreeBSD and OpenBSD also build from the linux build dirs. But all that is for another issue/PR, so let's not get carried away here (saying that foremost to myself0 -t |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 The build directories for solaris are not really gone. I've only moved them to a separate project "solaris-squeak", and I compile in those directories (in that project), but pointing to the source code in "opensmalltalk". It's easy to move the build.sunos32x86 and build.sunos64x64 back, in the future, if that would be useful. For the moment I work with the 2 projects, and that works fine for now. David -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJepF5ZAAoJEAwpOKXMq1MaKf8H/2YbofB5AbLgcDV1po1VilrN XhQWam/6w3/NQVKzubnCPZlB5BxN3lZPuN19RhBB34kEHDoygU1qrPcZVUiqO/zu sbFDUbmeFc8MQ9PlGUlNZ5Eq71v05VzOfK5vuNl+EIrFrl/M/JHjNgTOiSFO79tH Pt25DKHf2qacMYD6Bvc1ZvTGFBxgXuRp6AjPe2QElKDjVTc5Hf6h8MrZZLUQHk0W KAU/xySHgG9FCiOKi6AdlILRet33Wx4FFoc4yxEx/P/A8IJSBA0h17745XvCDI3n mPyp8M5HkF34L/CB2kjVLJYymlZfFwudCwDfCqLfcHP7xBYyUfMCpHufuYVsD5w= =YcSK -----END PGP SIGNATURE----- -- Sent from: http://forum.world.st/Squeak-VM-f104410.html |
In reply to this post by David T Lewis
@eliotmiranda pushed 1 commit.
— |
In reply to this post by David T Lewis
@eliotmiranda pushed 1 commit.
— |
In reply to this post by David T Lewis
@eliotmiranda approved this pull request. Please add the build directories when convenient. I undid inadvertent changes to build.linux64x64/squeak.cog.spur/build.itimerheartbeat/mvm. I hope you don' mind :-) — |
In reply to this post by David T Lewis
Closed #490. — |
Free forum by Nabble | Edit this page |