[OpenSmalltalk/opensmalltalk-vm] Tag the minheadless builds with CMake with a suffix instead of a prefix. (#411)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Tag the minheadless builds with CMake with a suffix instead of a prefix. (#411)

Eliot Miranda-4
 

I just noticed that the bintray deployment script has the following regex:

{"includePattern": "../products/((newspeak|pharo|squeak).*\.(?:gz|zip|dmg))", "uploadPattern": "$1"}

Since I was tagging the minheadless with a cmake-minhdls- prefix, they build artifacts are not matching this regex. I prefer changing the prefix with a -cmake-minhdls suffix instead of messing with a potentially dangerous regex.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411

Commit Summary

  • Tag the minheadless builds with CMake with a suffix instead of a prefis.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEWZMRK4P5AZYBCTY32LP4QEQFA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G36BULA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEWZMRK4P5AZYBCTY32LP4QEQFA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G36BULA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Tag the minheadless builds with CMake with a suffix instead of a prefix. (#411)

Eliot Miranda-4
 

+1 for consistency


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEW25QCNJLCZI33URII3P4RP2LA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWEJEA#issuecomment-506217616", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEW25QCNJLCZI33URII3P4RP2LA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWEJEA#issuecomment-506217616", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Tag the minheadless builds with CMake with a suffix instead of a prefix. (#411)

Eliot Miranda-4
In reply to this post by Eliot Miranda-4
 

Merged #411 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEWYTSKHVN7ZSP5T7L2TP4UL3FA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSHBAM2A#event-2445411944", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/411?email_source=notifications\u0026email_token=AIJPEWYTSKHVN7ZSP5T7L2TP4UL3FA5CNFSM4H3XDXK2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSHBAM2A#event-2445411944", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>