[OpenSmalltalk/opensmalltalk-vm] c0304d: FilePlugin: Remove misleading check for end of lin...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] c0304d: FilePlugin: Remove misleading check for end of lin...

GitHub
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: c0304df1d8be536c0dd6f4306e56c375e6533e3c
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c0304df1d8be536c0dd6f4306e56c375e6533e3c
  Author: Holger Hans Peter Freyther <[hidden email]>
  Date:   2016-09-24 (Sat, 24 Sep 2016)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  FilePlugin: Remove misleading check for end of line

When operating on stdin sqFileReadIntoAt will read one zero or one
byte from the FILE*. The loop will exit when bytesRead is not zero
and this will happen when a character was read. There is no reason
to exit the loop differently for \r or \n.


  Commit: 3f49cd2f9a4833ea8e7d43e958bd216784204183
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3f49cd2f9a4833ea8e7d43e958bd216784204183
  Author: Nicolas Cellier <[hidden email]>
  Date:   2017-08-31 (Thu, 31 Aug 2017)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  Merge pull request #64 from zecke/Cog-remove-eol-check

FilePlugin: Remove misleading check for end of line

Integrator note: this is a minor cleanup and absolutely won't change any behaviour.
See https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/150 for an explanation of the origin of those checks, and for things remaining to change.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1102de6e73c3...3f49cd2f9a48