[OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
 

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394

Commit Summary

  • serial: Remove unused variable holding a default filename

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
 

Its easy to confirm its unused... https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=serialPortBaseName&unscoped_q=serialPortBaseName


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4ZB4QTPWOJX7MI6HDPVP2S3A5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVONIZQ#issuecomment-492622950", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4ZB4QTPWOJX7MI6HDPVP2S3A5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVONIZQ#issuecomment-492622950", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
In reply to this post by Ben Coman-4
 

That code is all over the place… __APPLE ?!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW6X5UDDV37S4RENW4TPVP7JJA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOQH7Q#issuecomment-492635134", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW6X5UDDV37S4RENW4TPVP7JJA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOQH7Q#issuecomment-492635134", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
In reply to this post by Ben Coman-4
 

Merged #394 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW2LDFVV74UGSUK4SJLPVP7JXA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOROUYSIY#event-2343143715", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW2LDFVV74UGSUK4SJLPVP7JXA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOROUYSIY#event-2343143715", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
In reply to this post by Ben Coman-4
 

That code is all over the place… __APPLE ?!
@krono, was that a response for me? Yes _APPLE is all over,
but serialPortBaseName per url search?q=serialPortBaseName is not.
Anyway I see you've merged it already. cheers.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4WWNHNCO3CEN4TE63PVQCV5A5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOSTSY#issuecomment-492644811", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4WWNHNCO3CEN4TE63PVQCV5A5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOSTSY#issuecomment-492644811", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] serial: Remove unused variable holding a default filename (#394)

Ben Coman-4
In reply to this post by Ben Coman-4
 

no, I meant the original one :)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4C4LDYR4AR2DRW3V3PVQJFXA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOXZPQ#issuecomment-492666046", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394?email_source=notifications\u0026email_token=AIJPEW4C4LDYR4AR2DRW3V3PVQJFXA5CNFSM4HKXW3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOXZPQ#issuecomment-492666046", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>